Mercurial > prosody-modules
annotate mod_c2s_limit_sessions/mod_c2s_limit_sessions.lua @ 6514:668b1f0a4dc6
mod_c2s_limit_sessions: Fix check when it's the first connection
Creation of the sessions[username] entry happens after the
"pre-resource-bind" event, before the "resource-bind" event.
Thus, for a users first connection, it may not exist.
This led to an 'attempt to index a nil value' error, fixed here.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Wed, 08 Apr 2026 15:56:38 +0200 |
| parents | fe8738747d91 |
| children |
| rev | line source |
|---|---|
|
1365
ecc948f8d47d
mod_c2s_limit_sessions: Limit number of resources a user may connect
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
1 -- mod_c2s_limit_sessions |
|
ecc948f8d47d
mod_c2s_limit_sessions: Limit number of resources a user may connect
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
2 |
|
ecc948f8d47d
mod_c2s_limit_sessions: Limit number of resources a user may connect
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
3 local next, count = next, require "util.iterators".count; |
|
ecc948f8d47d
mod_c2s_limit_sessions: Limit number of resources a user may connect
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
4 |
|
ecc948f8d47d
mod_c2s_limit_sessions: Limit number of resources a user may connect
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
5 local max_resources = module:get_option_number("max_resources", 10); |
|
ecc948f8d47d
mod_c2s_limit_sessions: Limit number of resources a user may connect
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
6 |
|
6511
fe8738747d91
mod_c2s_limit_sessions: Use pre-resource-bind for catching the condition early
Matthew Wild <mwild1@gmail.com>
parents:
6510
diff
changeset
|
7 local sessions = prosody.hosts[module.host].sessions; |
|
fe8738747d91
mod_c2s_limit_sessions: Use pre-resource-bind for catching the condition early
Matthew Wild <mwild1@gmail.com>
parents:
6510
diff
changeset
|
8 module:hook("pre-resource-bind", function(event) |
|
1366
f581210093a7
mod_c2s_limit_sessions: Fix global access
Kim Alvefur <zash@zash.se>
parents:
1365
diff
changeset
|
9 local session = event.session; |
|
6514
668b1f0a4dc6
mod_c2s_limit_sessions: Fix check when it's the first connection
Kim Alvefur <zash@zash.se>
parents:
6511
diff
changeset
|
10 if not sessions[session.username] then |
|
668b1f0a4dc6
mod_c2s_limit_sessions: Fix check when it's the first connection
Kim Alvefur <zash@zash.se>
parents:
6511
diff
changeset
|
11 return -- zero sessions |
|
668b1f0a4dc6
mod_c2s_limit_sessions: Fix check when it's the first connection
Kim Alvefur <zash@zash.se>
parents:
6511
diff
changeset
|
12 end |
|
6511
fe8738747d91
mod_c2s_limit_sessions: Use pre-resource-bind for catching the condition early
Matthew Wild <mwild1@gmail.com>
parents:
6510
diff
changeset
|
13 if count(next, sessions[session.username].sessions) >= max_resources then |
|
fe8738747d91
mod_c2s_limit_sessions: Use pre-resource-bind for catching the condition early
Matthew Wild <mwild1@gmail.com>
parents:
6510
diff
changeset
|
14 event.error = { condition = "policy-violation", text = "Too many active connections to this account" }; |
|
fe8738747d91
mod_c2s_limit_sessions: Use pre-resource-bind for catching the condition early
Matthew Wild <mwild1@gmail.com>
parents:
6510
diff
changeset
|
15 session:close(event.error); |
|
fe8738747d91
mod_c2s_limit_sessions: Use pre-resource-bind for catching the condition early
Matthew Wild <mwild1@gmail.com>
parents:
6510
diff
changeset
|
16 return false; |
|
1365
ecc948f8d47d
mod_c2s_limit_sessions: Limit number of resources a user may connect
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
17 end |
|
ecc948f8d47d
mod_c2s_limit_sessions: Limit number of resources a user may connect
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
18 end, -1); |
