changeset 13940:5f8a9e50c2fb 13.0

mod_smacks: Remove extra optional from sm element Since XEP-0198 version 1.6.3, the optional and required children of sm in stream:features have been removed entirely. They already weren’t specified before, and were only leftover from a very old version in the XML Schema. Fixes #1963
author Link Mauve <linkmauve@linkmauve.fr>
date Tue, 02 Sep 2025 00:50:25 +0200
parents dae094b392d1
children f4e16e6265e6
files doc/doap.xml plugins/mod_smacks.lua
diffstat 2 files changed, 5 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/doc/doap.xml	Sun Aug 24 19:57:43 2025 +0200
+++ b/doc/doap.xml	Tue Sep 02 00:50:25 2025 +0200
@@ -518,7 +518,7 @@
     <implements>
       <xmpp:SupportedXep>
         <xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0198.html"/>
-        <xmpp:version>1.6.2</xmpp:version>
+        <xmpp:version>1.6.3</xmpp:version>
         <xmpp:status>complete</xmpp:status>
         <xmpp:since>0.12.0</xmpp:since>
         <xmpp:note>mod_smacks</xmpp:note>
--- a/plugins/mod_smacks.lua	Sun Aug 24 19:57:43 2025 +0200
+++ b/plugins/mod_smacks.lua	Tue Sep 02 00:50:25 2025 +0200
@@ -152,16 +152,16 @@
 module:hook("stream-features",
 		function (event)
 			if can_do_smacks(event.origin, true) then
-				event.features:tag("sm", sm2_attr):tag("optional"):up():up();
-				event.features:tag("sm", sm3_attr):tag("optional"):up():up();
+				event.features:tag("sm", sm2_attr):up();
+				event.features:tag("sm", sm3_attr):up();
 			end
 		end);
 
 module:hook("s2s-stream-features",
 		function (event)
 			if can_do_smacks(event.origin, true) then
-				event.features:tag("sm", sm2_attr):tag("optional"):up():up();
-				event.features:tag("sm", sm3_attr):tag("optional"):up():up();
+				event.features:tag("sm", sm2_attr):up();
+				event.features:tag("sm", sm3_attr):up();
 			end
 		end);