http://hg.omfa.de/prosody-modules/ en-us prosody-modules: mod_smacks/mod_smacks.lua history mod_smacks/mod_smacks.lua revision history mod_smacks: Send <r> immediately from csi-flushing event http://hg.omfa.de/prosody-modules/log/e227af629736/mod_smacks/mod_smacks.lua
Using a timer serves no purpose in this case, only serves to increase
the number of write syscalls and TCP segments sent.]]> Kim Alvefur <zash@zash.se> Tue, 16 Nov 2021 13:39:49 +0100 mod_smacks: Don't forgive client counting errors http://hg.omfa.de/prosody-modules/log/367a8020bd92/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Sun, 07 Nov 2021 14:40:41 +0100 mod_smacks: Include username in offline event, mirroring Prosody 0.10+ http://hg.omfa.de/prosody-modules/log/edbd84bbd8fb/mod_smacks/mod_smacks.lua
See Prosody rev 03714861f8fc and 72a2b85c0537]]> Kim Alvefur <zash@zash.se> Sun, 12 Sep 2021 21:14:26 +0200 mod_smacks: Use 'smacks_max_inactive_unacked_stanzas' when inactive and no timer http://hg.omfa.de/prosody-modules/log/242251ce1036/mod_smacks/mod_smacks.lua
This separate limit should probably apply also when it somehow doesn't
have a timer set.]]> Kim Alvefur <zash@zash.se> Wed, 28 Jul 2021 16:06:03 +0200 mod_smacks: Fix typo in comment (thanks codespell) http://hg.omfa.de/prosody-modules/log/ab7dc5c5c782/mod_smacks/mod_smacks.lua Kim Alvefur <zash@zash.se> Tue, 27 Jul 2021 00:21:42 +0200 mod_smacks: Fix traceback on missing stanza counter http://hg.omfa.de/prosody-modules/log/921c607617b0/mod_smacks/mod_smacks.lua
This shouldn't be possible, yet it was.]]> Kim Alvefur <zash@zash.se> Thu, 22 Jul 2021 17:26:32 +0200 mod_smacks: Include timestamp in hibernation log message http://hg.omfa.de/prosody-modules/log/f6f28ceff53a/mod_smacks/mod_smacks.lua
So that I will never have to wonder "how long? since when" ever again.]]> Kim Alvefur <zash@zash.se> Mon, 07 Jun 2021 19:15:28 +0200 mod_smacks: Fix calculation of smacks timeout values http://hg.omfa.de/prosody-modules/log/4e7aa32f58d9/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Mon, 12 Apr 2021 14:50:28 +0200 mod_smacks: Fix traceback due to session being destroyed in send() http://hg.omfa.de/prosody-modules/log/53ee391ca689/mod_smacks/mod_smacks.lua
Sending something can cause the OS to notice that the connection is dead
and then the connection can be dead at this point. More likely if
opportunistic_writes is enabled.]]> Kim Alvefur <zash@zash.se> Thu, 01 Apr 2021 11:35:26 +0200 mod_smacks: Enable on s2s by default to see what breaks http://hg.omfa.de/prosody-modules/log/8bdb9805bb73/mod_smacks/mod_smacks.lua Kim Alvefur <zash@zash.se> Wed, 31 Mar 2021 22:06:23 +0200 mod_smacks: Correct field name for session http://hg.omfa.de/prosody-modules/log/8b8246031a5e/mod_smacks/mod_smacks.lua
Fixes another traceback.

I did point out that I was breaking everything.]]> Kim Alvefur <zash@zash.se> Tue, 23 Feb 2021 03:22:33 +0100 mod_smacks: Only act on CSI state changes if smacks is enabled http://hg.omfa.de/prosody-modules/log/5234d0c8883d/mod_smacks/mod_smacks.lua
Fixes attempt to get length of a nil value (local 'queue') in
request_ack_if_needed()]]> Kim Alvefur <zash@zash.se> Mon, 22 Feb 2021 16:44:40 +0100 mod_smacks: Request ack on signal of ongoing CSI flush http://hg.omfa.de/prosody-modules/log/3d593b612e07/mod_smacks/mod_smacks.lua
Should make it finally behave with mod_csi_simple from Prosody trunk]]> Kim Alvefur <zash@zash.se> Tue, 16 Feb 2021 23:16:05 +0100 mod_smacks: Explicitly request ack when leaving CSI-inactive mode http://hg.omfa.de/prosody-modules/log/e13eb0f851c8/mod_smacks/mod_smacks.lua
There may be a lot of unacked stanzas in the queue, might as well...]]> Kim Alvefur <zash@zash.se> Tue, 16 Feb 2021 22:49:44 +0100 mod_smacks: Do ask for acks while in CSI inactive mode, but less frequent http://hg.omfa.de/prosody-modules/log/2f5e52d67928/mod_smacks/mod_smacks.lua
Otherwise the unacked stanza queue just grows forever]]> Kim Alvefur <zash@zash.se> Tue, 16 Feb 2021 21:33:39 +0100 mod_smacks: Don't ask for acks while in (csi) inactive mode http://hg.omfa.de/prosody-modules/log/74da3643c62d/mod_smacks/mod_smacks.lua
The acks count as high priority events in mod_csi_simple and since
they're sent after each stanza, it negated all optimizations.]]> Kim Alvefur <zash@zash.se> Tue, 16 Feb 2021 19:16:21 +0100 mod_smacks: allow O(1) processing of delayed ack events http://hg.omfa.de/prosody-modules/log/0b9501f82e63/mod_smacks/mod_smacks.lua
This adds a stanza field to the eent if the stanza which triggered this event
is known exactly.]]> tmolitor <thilo@eightysoft.de> Sat, 30 Jan 2021 07:19:35 +0100 mod_smacks: don't store mam results in offline store http://hg.omfa.de/prosody-modules/log/22e7b3d6fcae/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Mon, 12 Oct 2020 17:56:10 +0200 mod_smacks: don't send error replys for error stanzas on session timeout http://hg.omfa.de/prosody-modules/log/362997ededb1/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Fri, 01 May 2020 22:24:10 +0200 mod_smacks: remove now unused code http://hg.omfa.de/prosody-modules/log/9ec23a457f9a/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Tue, 21 Apr 2020 11:26:43 +0200 mod_smacks: fix typo in last commit http://hg.omfa.de/prosody-modules/log/c3e9caa29857/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Mon, 20 Apr 2020 15:30:56 +0200 mod_smacks: better logging for georg http://hg.omfa.de/prosody-modules/log/4e5fde519116/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Mon, 20 Apr 2020 14:49:17 +0200 mod_smacks: Fix mam handling http://hg.omfa.de/prosody-modules/log/effe2d93a59c/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Mon, 20 Apr 2020 14:40:09 +0200 Merge commit http://hg.omfa.de/prosody-modules/log/bf5d91769f99/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Sun, 05 Apr 2020 23:39:08 +0200 mod_smacks: Update documentation and slightly adjust default values http://hg.omfa.de/prosody-modules/log/0957ba6aeb99/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Sun, 05 Apr 2020 23:37:17 +0200 mod_stanzas: tighten up stanza check and add explanatory text http://hg.omfa.de/prosody-modules/log/ebc1f1d962c5/mod_smacks/mod_smacks.lua JC Brand <jc@opkode.com> Fri, 27 Mar 2020 11:56:14 +0100 mod_smacks: also count outgoing MAM messages http://hg.omfa.de/prosody-modules/log/017f60608fc8/mod_smacks/mod_smacks.lua
mod_smacks doesn't count outgoing MAM messages, which causes warnings in Prosody such as:

> The client says it handled 41 new stanzas, but we only sent 2

It seems mod_smacks is in the wrong here and that it's too strict in trying to determine what is a valid stanza to count.

In RFC6120:

> Definition of XML Stanza: An XML stanza is the basic unit of meaning
> in XMPP. A stanza is a first-level element (at depth=1 of the stream)
> whose element name is "message", "presence", or "iq" and whose
> qualifying namespace is 'jabber:client' or 'jabber:server'.]]> JC Brand <jc@opkode.com> Thu, 26 Mar 2020 11:57:02 +0100 mod_smacks: fix logging issue in mam eventhandler http://hg.omfa.de/prosody-modules/log/e93e58b33bf6/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Tue, 10 Mar 2020 23:59:19 +0100 mod_smacks: handle mam-enabled session internally http://hg.omfa.de/prosody-modules/log/c49fea05772e/mod_smacks/mod_smacks.lua
This obsoletes mod_smacks_offline and supersedes mod_smacks_noerror with mod_smacks_nooffline_noerror]]> tmolitor <thilo@eightysoft.de> Sun, 08 Mar 2020 19:49:47 +0100 Fix bug readding stanzas to outgoing_queue on resume http://hg.omfa.de/prosody-modules/log/b5d367798570/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Thu, 09 Jan 2020 21:21:09 +0100 mod_smacks: fix bug #1405 (prevent timer from running for already destroyed sessions) http://hg.omfa.de/prosody-modules/log/58047d6f2b89/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Sun, 11 Aug 2019 02:58:56 +0200 mod_smacks: fix bug in bad client handling introduced by last commit http://hg.omfa.de/prosody-modules/log/b2f32b3c6ec1/mod_smacks/mod_smacks.lua
Use absolute h-values instead of queue-count to determine if a new
request should be sent out or if we are looping instead.]]> tmolitor <thilo@eightysoft.de> Fri, 02 Aug 2019 18:26:06 +0200 mod_smacks: fix bug for missbehaving clients sending multiple acks in a row http://hg.omfa.de/prosody-modules/log/915e32d5a147/mod_smacks/mod_smacks.lua
Missbehaving clients, sending multiple acks in a row (I'm looking at you Monal!)
triggered the ack-loop-prevention code added in 2017, leaving unacked stanzas
in the queue. This fixes the bug while still preventing ack-loops.]]> tmolitor <thilo@eightysoft.de> Tue, 30 Jul 2019 02:07:13 +0200 mod_smacks: fix prosody 0.9 compatibility http://hg.omfa.de/prosody-modules/log/c2c851722a8a/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Sun, 16 Jun 2019 02:00:12 +0200 mod_smacks: piggyback ack request onto ack response if queue is not empty, use native stoppable timers if supported http://hg.omfa.de/prosody-modules/log/fb1c8dee2ead/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Sat, 15 Jun 2019 01:34:52 +0200 mod_smacks: Raise error on out-of-range config options (thanks marc0s) http://hg.omfa.de/prosody-modules/log/3d4eefdd950a/mod_smacks/mod_smacks.lua Matthew Wild <mwild1@gmail.com> Fri, 22 Mar 2019 22:06:40 +0000 mod_smacks: apply resumed logger and type to new session, fix #1229 http://hg.omfa.de/prosody-modules/log/9ef309fb501d/mod_smacks/mod_smacks.lua Georg Lukas <georg@op-co.de> Wed, 06 Mar 2019 21:51:45 +0100 mod_smacks: improved debug logging http://hg.omfa.de/prosody-modules/log/f6319346e2a3/mod_smacks/mod_smacks.lua Georg Lukas <georg@op-co.de> Wed, 06 Mar 2019 21:44:07 +0100 mod_smacks: no crash on <a> without @h, fix #1317 http://hg.omfa.de/prosody-modules/log/1f2381492c9f/mod_smacks/mod_smacks.lua Georg Lukas <georg@op-co.de> Wed, 06 Mar 2019 21:25:47 +0100 mod_smacks: Fire event on delivery failure/success for each stanza http://hg.omfa.de/prosody-modules/log/9b6206f23151/mod_smacks/mod_smacks.lua Matthew Wild <mwild1@gmail.com> Sun, 20 Jan 2019 00:02:08 +0000 mod_smacks: Improve logging on resume so session changes are more easily tracked http://hg.omfa.de/prosody-modules/log/67f1d1f22625/mod_smacks/mod_smacks.lua Matthew Wild <mwild1@gmail.com> Wed, 08 Aug 2018 12:49:02 +0100 mod_smacks: Reduce unacked stanza log message from warn->debug http://hg.omfa.de/prosody-modules/log/14b6ad2b773f/mod_smacks/mod_smacks.lua Matthew Wild <mwild1@gmail.com> Tue, 26 Jun 2018 15:30:03 +0100 mod_smacks: Convert max number into a string before inserting it into a stanza. http://hg.omfa.de/prosody-modules/log/06e07b483805/mod_smacks/mod_smacks.lua Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> Fri, 08 Jun 2018 17:56:54 +0200 mod_smacks: defer timeouts for push enabled clients http://hg.omfa.de/prosody-modules/log/f703cc6e72df/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Fri, 08 Jun 2018 17:38:24 +0200 mod_smacks: send maximum resumption timeout to client http://hg.omfa.de/prosody-modules/log/626d2c781c66/mod_smacks/mod_smacks.lua Jonas Wielicki <jonas@wielicki.name> Thu, 07 Jun 2018 13:27:32 +0200 mod_smacks: Ensure stanza count attributes are always strings (thanks Martin) http://hg.omfa.de/prosody-modules/log/e672d1050529/mod_smacks/mod_smacks.lua Matthew Wild <mwild1@gmail.com> Sat, 17 Mar 2018 12:58:37 +0000 mod_smacks: Fix #921 http://hg.omfa.de/prosody-modules/log/dbba101601b4/mod_smacks/mod_smacks.lua See also https://mail.jabber.org/pipermail/standards/2017-May/032773.html]]> tmolitor <thilo@eightysoft.de> Sun, 27 Aug 2017 21:34:48 +0200 mod_smacks: Trigger event smacks-hibernation-end after queue resend http://hg.omfa.de/prosody-modules/log/f70c02c14161/mod_smacks/mod_smacks.lua This is more sensible and allows other modules to send out stanzas when
handling this event without messing with the order of stanzas.]]> tmolitor <thilo@eightysoft.de> Fri, 18 Aug 2017 00:56:38 +0200 mod_smacks: don't send out <r> when already hibernating http://hg.omfa.de/prosody-modules/log/91cbeb6ad987/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Fri, 14 Jul 2017 18:06:17 +0200 mod_smacks: Fix delayed_ack event http://hg.omfa.de/prosody-modules/log/eea1d5bac451/mod_smacks/mod_smacks.lua
After the first delayed ack every queued stanza should immediately
trigger the delayed_ack event.]]> tmolitor <thilo@eightysoft.de> Mon, 08 May 2017 19:36:37 +0200 Fix #889 http://hg.omfa.de/prosody-modules/log/d96831e46b64/mod_smacks/mod_smacks.lua
Some buggy clients try to resume unauthenticated sessions and
session.username is nil in this case (that caused the bug).]]> tmolitor <thilo@eightysoft.de> Mon, 24 Apr 2017 20:56:56 +0200 mod_smacks: Ignore user when writing or reading session_cache on prosody 0.9 http://hg.omfa.de/prosody-modules/log/6e01878103c0/mod_smacks/mod_smacks.lua
At least under some circumstances it seems that session.username is nil when
a user tries to resume his session in prosody 0.9.
The username is not relevant when no limiting is done (limiting the number of
entries in the session cache is only possible in prosody 0.10), so this
commit removes the usage of the username when accessing the prosody 0.9 session
cache.]]> tmolitor <thilo@eightysoft.de> Thu, 06 Apr 2017 02:12:14 +0200 mod_smacks: Prevent ack loop on misbehaving clients http://hg.omfa.de/prosody-modules/log/c110b6bfe5d1/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Wed, 15 Mar 2017 16:24:03 +0100 mod_smacks: Made module more error resistant http://hg.omfa.de/prosody-modules/log/a65260300708/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Wed, 15 Mar 2017 16:21:55 +0100 mod_smacks: Add resumed session to event "smacks-hibernation-end" http://hg.omfa.de/prosody-modules/log/362ca94192ee/mod_smacks/mod_smacks.lua
Older versions of this event only have the "intermediate" session
in event.session (the one used to resume the existing session),
but not the resumed one.
This adds event.resumed which contains the resumed one alongside
to event.session.]]> tmolitor <thilo@eightysoft.de> Sat, 11 Mar 2017 01:37:28 +0100 Implement XEP-0198 revision 1.5.2 and limit number of hibernated sessions per user http://hg.omfa.de/prosody-modules/log/ffb6646b4253/mod_smacks/mod_smacks.lua
Revision 1.5.2 allows sending h-values on resumes that fail due to hibernation timeout
and to send out a smacks ack directly before the stream close tag.
I also made the used timers stoppable even for prosody 0.10 and below, this makes
the smacks-ack-delayed event more useful.]]> tmolitor <thilo@eightysoft.de> Sun, 05 Mar 2017 20:23:53 +0100 mod_smacks: Fix some bugs with smacks-ack-delayed event triggering. http://hg.omfa.de/prosody-modules/log/d300ae5dba87/mod_smacks/mod_smacks.lua
The old code had several flaws which are addressed here.
First of all this fixes the if statement guarding the event generation
There where some timing glitches addressed by this commit as well.]]> tmolitor <thilo@eightysoft.de> Sun, 12 Feb 2017 21:23:22 +0100 mod_smacks: Send out more ack requests where needed http://hg.omfa.de/prosody-modules/log/5fbca7de2088/mod_smacks/mod_smacks.lua
Under some circumstances it was possible that more than "max_unacked_stanzas"
where left in the outgoing stanza queue without forcing an ack.
This could happen, when more stanzas entered the queue while the last ack request
was still unanswered.
Now the test "#queue > max_unacked_stanzas" is done upon receiving
an ack as well as when sending out stanzas, which fixes this bug.]]> tmolitor <thilo@eightysoft.de> Sun, 12 Feb 2017 19:27:50 +0100 mod_smacks: Check if a session is an authenticated c2s session by looking for a username (fix for change in 0.10 9f70d35a1602) http://hg.omfa.de/prosody-modules/log/5e7badecf7fe/mod_smacks/mod_smacks.lua Kim Alvefur <zash@zash.se> Thu, 15 Dec 2016 02:57:03 +0100 mod_smacks: added new event "smacks-ack-delayed" used by mod_cloud_notify and extended the readme file accordingly (also mention mod_smacks_offline and mod_smacks_noerror in readme file) http://hg.omfa.de/prosody-modules/log/4c27ebcf4cbd/mod_smacks/mod_smacks.lua tmolitor <thilo@eightysoft.de> Thu, 24 Nov 2016 00:47:32 +0100