mod_firewall: SUBSCRIBED: Flip subscription check to match documentation The documentation claims that this condition checks whether the recipient is subscribed to the sender. However, it was using the wrong method, and actually checking whether the sender was subscribed to the recipient. A quick poll of folk suggested that the documentation's approach is the right one, so this should fix the code to match the documentation. This should also fix the bundled anti-spam rules from blocking presence from JIDs that you subscribe do (but don't have a mutual subscription with).

local jid = require "util.jid";
local st = require "util.stanza";

local nick_patterns = module:get_option_array("muc_reserve_nick_patterns", {});

module:hook("muc-occupant-pre-join", function (event)
	local nick = jid.resource(event.occupant.nick);
	for k, nick_pattern in pairs(nick_patterns) do
		if nick:match(nick_pattern) then
			local reply = st.error_reply(event.stanza, "modify", "conflict", "Unacceptable nickname, please try another");
			module:send(reply);
			return true;
		end
	end
end);