Mercurial > prosody-modules
annotate mod_tlsfail/mod_tlsfail.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Wed, 29 Mar 2023 16:12:15 +0100 |
| parents | 7009e16192fa |
| children |
| rev | line source |
|---|---|
|
4434
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
1 local st = require "util.stanza"; |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
2 |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
3 local xmlns_starttls = 'urn:ietf:params:xml:ns:xmpp-tls'; |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
4 local starttls_attr = { xmlns = xmlns_starttls }; |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
5 local s2s_feature = st.stanza("starttls", starttls_attr); |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
6 local starttls_failure = st.stanza("failure", starttls_attr); |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
7 |
| 4702 | 8 module:hook("stream-features", function(event) |
| 9 local features = event.features; | |
| 10 features:add_child(s2s_feature); | |
| 11 end); | |
| 12 | |
|
4434
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
13 module:hook("s2s-stream-features", function(event) |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
14 local features = event.features; |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
15 features:add_child(s2s_feature); |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
16 end); |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
17 |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
18 -- Hook <starttls/> |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
19 module:hook("stanza/urn:ietf:params:xml:ns:xmpp-tls:starttls", function(event) |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
20 local origin = event.origin; |
| 4702 | 21 (origin.sends2s or origin.send)(starttls_failure); |
|
4434
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
22 origin:close(); |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
23 return true; |
|
f10ab82be166
mod_tlsfail: Test how servers react to starttls failure
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
24 end); |
