http://hg.omfa.de/prosody-hg/ en-us prosody-hg: util/xml.lua history util/xml.lua revision history util: Prefix module imports with prosody namespace http://hg.omfa.de/prosody-hg/log/d10957394a3c/util/xml.lua Kim Alvefur <zash@zash.se> Fri, 17 Mar 2023 16:23:16 +0100 util.xml: Add an option to allow <?processing instructions?> http://hg.omfa.de/prosody-hg/log/c78639ee6ccb/util/xml.lua
These should generally be safe to just ignore, which should be the
default behavior of Expat and LuaExpat]]> Kim Alvefur <zash@zash.se> Fri, 04 Feb 2022 20:47:39 +0100 Merge 0.11->trunk http://hg.omfa.de/prosody-hg/log/320de3e4b579/util/xml.lua Kim Alvefur <zash@zash.se> Thu, 20 Jan 2022 13:02:24 +0100 util.xml: Deduplicate handlers for restricted XML http://hg.omfa.de/prosody-hg/log/ebeb4d959fb3/util/xml.lua
Makes the code more like util.xmppstream, allowing easier comparisons if
we ever need to apply fixes in the future.]]> Kim Alvefur <zash@zash.se> Thu, 20 Jan 2022 10:51:46 +0100 util.xml: Break reference to help the GC (fix #1711) http://hg.omfa.de/prosody-hg/log/e5e0ab93d7f4/util/xml.lua
LuaExpat uses a registry reference to track handlers, which makes
it so that an upvalue like this creates a reference loop that keeps the
parser and its handlers from being garbage collected. The same issue has
affected util.xmppstream in the past.

Code for checking:

local xml_parse = require"util.xml".parse;
for i = 1, 10000 do xml_parse("<root/>") end
collectgarbage(); collectgarbage();
print(collectgarbage("count"), "KiB");

A future release of LuaExpat may fix the underlying issue there.]]> Kim Alvefur <zash@zash.se> Thu, 20 Jan 2022 09:57:20 +0100 util.xml: Do not allow doctypes, comments or processing instructions http://hg.omfa.de/prosody-hg/log/783056b4e448/util/xml.lua
Yes. This is as bad as it sounds. CVE pending.

In Prosody itself, this only affects mod_websocket, which uses util.xml
to parse the <open/> frame, thus allowing unauthenticated remote DoS
using Billion Laughs. However, third-party modules using util.xml may
also be affected by this.

This commit installs handlers which disallow the use of doctype
declarations and processing instructions without any escape hatch. It,
by default, also introduces such a handler for comments, however, there
is a way to enable comments nontheless.

This is because util.xml is used to parse human-facing data, where
comments are generally a desirable feature, and also because comments
are generally harmless.]]> Jonas Schäfer <jonas@wielicki.name> Mon, 10 Jan 2022 18:23:54 +0100 util.xml: Do not allow doctypes, comments or processing instructions http://hg.omfa.de/prosody-hg/log/53e0ae770917/util/xml.lua
Yes. This is as bad as it sounds. CVE pending.

In Prosody itself, this only affects mod_websocket, which uses util.xml
to parse the <open/> frame, thus allowing unauthenticated remote DoS
using Billion Laughs. However, third-party modules using util.xml may
also be affected by this.

This commit installs handlers which disallow the use of doctype
declarations and processing instructions without any escape hatch. It,
by default, also introduces such a handler for comments, however, there
is a way to enable comments nontheless.

This is because util.xml is used to parse human-facing data, where
comments are generally a desirable feature, and also because comments
are generally harmless.]]> Jonas Schäfer <jonas@wielicki.name> Mon, 10 Jan 2022 18:23:54 +0100 util.xml: Use variable instead of constant for consistency (thanks Thijs) http://hg.omfa.de/prosody-hg/log/2162e86029b6/util/xml.lua Matthew Wild <mwild1@gmail.com> Sun, 26 Dec 2021 20:37:20 +0000 util.xml: Fix float formatting of line and columns in error (on Lua 5.3+) http://hg.omfa.de/prosody-hg/log/1d9cd1abc660/util/xml.lua Kim Alvefur <zash@zash.se> Sat, 03 Oct 2020 16:22:56 +0200 vairious: Add annotation when an empty environment is set [luacheck] http://hg.omfa.de/prosody-hg/log/4f0f5b49bb03/util/xml.lua Kim Alvefur <zash@zash.se> Wed, 28 Feb 2018 20:06:26 +0100 util.xml: Correct stanza.namespaces table construction when duplicate prefix names are encountered in the element tree. http://hg.omfa.de/prosody-hg/log/c9af793b2d8f/util/xml.lua Waqas Hussain <waqas20@gmail.com> Sat, 05 Mar 2016 17:51:35 -0500 util.stanza, util.xml, util.xmppstream: Add support for tracking defined namespaces and their prefix (stanza.namespaces), knowing/preserving prefix names is required for some applications (thanks daurnimator) http://hg.omfa.de/prosody-hg/log/30c96a5db360/util/xml.lua Matthew Wild <mwild1@gmail.com> Tue, 08 Dec 2015 23:15:42 +0000 util.*: Remove use of module() function, make all module functions local and return them in a table at the end http://hg.omfa.de/prosody-hg/log/5de6b93d0190/util/xml.lua Kim Alvefur <zash@zash.se> Sat, 21 Feb 2015 10:36:37 +0100 util.xml: Remove unused parameter (thanks, luacheck) http://hg.omfa.de/prosody-hg/log/7da8b6bc0966/util/xml.lua Matthew Wild <mwild1@gmail.com> Wed, 06 May 2015 19:39:28 +0100 portmanager, s2smanager, sessionmanager, stanza_router, storagemanager, usermanager, util.xml: Add luacheck annotations http://hg.omfa.de/prosody-hg/log/d3023dd07cb6/util/xml.lua Matthew Wild <mwild1@gmail.com> Wed, 06 May 2015 19:20:07 +0100 Remove all trailing whitespace http://hg.omfa.de/prosody-hg/log/bd0ff8ae98a8/util/xml.lua Florian Zeitz <florob@babelmonkeys.de> Fri, 09 Aug 2013 17:48:21 +0200 util.xml: Fix module name. http://hg.omfa.de/prosody-hg/log/76e4651142e1/util/xml.lua Waqas Hussain <waqas20@gmail.com> Mon, 03 Dec 2012 10:01:46 +0500 util.xml: Initial commit; exposes parse(), which is now the canonical way to convert a string to a stanza. http://hg.omfa.de/prosody-hg/log/cc487921746b/util/xml.lua Waqas Hussain <waqas20@gmail.com> Mon, 03 Dec 2012 05:32:51 +0500