http://hg.omfa.de/prosody-hg/ en-us util/statistics.lua revision history http://hg.omfa.de/prosody-hg/log/d10957394a3c/util/statistics.lua Kim Alvefur <zash@zash.se> Fri, 17 Mar 2023 16:23:16 +0100 http://hg.omfa.de/prosody-hg/log/7d985e5bc1fb/util/statistics.lua
If buckets thresholds are to be taken as "less than or equal to", then
using the less than or equal to operator seems sensible.]]> Kim Alvefur <zash@zash.se> Mon, 27 Dec 2021 16:05:12 +0100 http://hg.omfa.de/prosody-hg/log/7ba686696250/util/statistics.lua
The buckets thresholds are to be taken as "less than or equal to".
The condition as written in the code did only "less than", not
"less than or equal to". That's fixed now.]]> Jonas Schäfer <jonas@wielicki.name> Sun, 26 Dec 2021 22:32:00 +0100 http://hg.omfa.de/prosody-hg/log/5f15ab7c6ae5/util/statistics.lua
The metric subsystem of Prosody has had some shortcomings from
the perspective of the current state-of-the-art in metric
observability.

The OpenMetrics standard [0] is a formalization of the data
model (and serialization format) of the well-known and
widely-used Prometheus [1] software stack.

The previous stats subsystem of Prosody did not map well to that
format (see e.g. [2] and [3]); the key reason is that it was
trying to do too much math on its own ([2]) while lacking
first-class support for "families" of metrics ([3]) and
structured metric metadata (despite the `extra` argument to
metrics, there was no standard way of representing common things
like "tags" or "labels").

Even though OpenMetrics has grown from the Prometheus world of
monitoring, it maps well to other popular monitoring stacks
such as:

- InfluxDB (labels can be mapped to tags and fields as necessary)
- Carbon/Graphite (labels can be attached to the metric name with
dot-separation)
- StatsD (see graphite when assuming that graphite is used as
backend, which is the default)

The util.statsd module has been ported to use the OpenMetrics
model as a proof of concept. An implementation which exposes
the util.statistics backend data as Prometheus metrics is
ready for publishing in prosody-modules (most likely as
mod_openmetrics_prometheus to avoid breaking existing 0.11
deployments).

At the same time, the previous measure()-based API had one major
advantage: It is really simple and easy to use without requiring
lots of knowledge about OpenMetrics or similar concepts. For that
reason as well as compatibility with existing code, it is preserved
and may even be extended in the future.

However, code relying on the `stats-updated` event as well as
`get_stats` from `statsmanager` will break because the data
model has changed completely; in case of `stats-updated`, the
code will simply not run (as the event was renamed in order
to avoid conflicts); the `get_stats` function has been removed
completely (so it will cause a traceback when it is attempted
to be used).

Note that the measure_*_event methods have been removed from
the module API. I was unable to find any uses or documentation
and thus deemed they should not be ported. Re-implementation is
possible when necessary.

[0]: https://openmetrics.io/
[1]: https://prometheus.io/
[2]: #959
[3]: #960]]> Jonas Schäfer <jonas@wielicki.name> Sun, 18 Apr 2021 11:47:41 +0200 http://hg.omfa.de/prosody-hg/log/d75d805c852f/util/statistics.lua
The primary goal here is to allow specifying an unit that each
statistic is measured in.]]> Kim Alvefur <zash@zash.se> Fri, 04 Jan 2019 06:56:45 +0100 http://hg.omfa.de/prosody-hg/log/bbc879eab1bf/util/statistics.lua Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> Thu, 10 Oct 2019 16:58:02 +0200 http://hg.omfa.de/prosody-hg/log/dc758422d896/util/statistics.lua Kim Alvefur <zash@zash.se> Mon, 20 Mar 2017 00:48:28 +0100 http://hg.omfa.de/prosody-hg/log/99fa40d498cc/util/statistics.lua Kim Alvefur <zash@zash.se> Tue, 05 May 2015 00:48:55 +0200 http://hg.omfa.de/prosody-hg/log/2b5ced5ca31f/util/statistics.lua Matthew Wild <mwild1@gmail.com> Fri, 30 Jan 2015 14:21:51 +0000 http://hg.omfa.de/prosody-hg/log/7b2d16c14659/util/statistics.lua Matthew Wild <mwild1@gmail.com> Wed, 21 Jan 2015 01:26:06 +0000 http://hg.omfa.de/prosody-hg/log/0e29c05c3503/util/statistics.lua Matthew Wild <mwild1@gmail.com> Tue, 20 Jan 2015 12:31:32 +0000