http://hg.omfa.de/prosody-hg/ en-us prosody-hg: util-src/poll.c history util-src/poll.c revision history util.poll: Reject file descriptors outside of FD_SETSIZE in all methods http://hg.omfa.de/prosody-hg/log/75d09be04f13/util-src/poll.c
To prevent accesses outside the bounds of the FD sets.
Previously only checked on the write, but maybe this could potentially
cause weird behavior as well?]]> Kim Alvefur <zash@zash.se> Sun, 31 May 2026 11:51:22 +0200 util.poll: Reject fd == FD_SETSIZE http://hg.omfa.de/prosody-hg/log/a331cde41c85/util-src/poll.c
FD_SETSIZE is the maximum total number of FDs supports (well, the highest
valid fd number). 0 is a valid fd number, so it supports up to 1023 if
FD_SETSIZE is 1024.

This is just a fencepost issue, fds > FD_SETSIZE were already correctly
rejected.]]> Matthew Wild <mwild1@gmail.com> Mon, 25 May 2026 16:06:19 +0100 util.poll: Rename things to clarify poll(2) limits http://hg.omfa.de/prosody-hg/log/5fe8a8e16b27/util-src/poll.c
With epoll(7), MAX_EVENTS controls how many events can be retrieved in one
epoll_wait call, while with poll(2) this MAX_WATCHED controls how many
sockets or other FDs can be watched at once.]]> Kim Alvefur <zash@zash.se> Mon, 27 Nov 2023 08:19:52 +0100 util.poll: Quadruple number of events retrieved at once from epoll http://hg.omfa.de/prosody-hg/log/8b3bf0d2ffd4/util-src/poll.c
Better performance under load maybe?

See b890ceb1c24f for previous increase]]> Kim Alvefur <zash@zash.se> Tue, 21 Nov 2023 20:45:56 +0100 util.poll: Return early if given zero timeout and no pending events http://hg.omfa.de/prosody-hg/log/649876680bf0/util-src/poll.c
Should have been part of f33887f925e1 to ensure it won't skip processing
timers at all when very busy.]]> Kim Alvefur <zash@zash.se> Tue, 21 Nov 2023 17:43:46 +0100 util: Add compat for prosody module name change to C sources http://hg.omfa.de/prosody-hg/log/a187600ec7d6/util-src/poll.c Kim Alvefur <zash@zash.se> Fri, 17 Mar 2023 18:03:07 +0100 util.poll: Include unistd.h only for epoll http://hg.omfa.de/prosody-hg/log/f5a75aaa8a25/util-src/poll.c
This defines close(), which is only used with epoll, hence we don't need
to include it when building in poll or select mode.]]> Kim Alvefur <zash@zash.se> Fri, 10 Feb 2023 00:37:05 +0100 util-src: Remove Lua 5.1 compat macros http://hg.omfa.de/prosody-hg/log/1f6f05a98fcd/util-src/poll.c
Part of #1600]]> Kim Alvefur <zash@zash.se> Fri, 01 Jul 2022 21:21:21 +0200 util.poll: Add support for the poll() API http://hg.omfa.de/prosody-hg/log/6bb2f660f689/util-src/poll.c
Might be better than select(), more portable than epoll.]]> Kim Alvefur <zash@zash.se> Wed, 23 Feb 2022 20:31:03 +0100 util.poll: Expose API (epoll or select) used http://hg.omfa.de/prosody-hg/log/cf2086a1bd45/util-src/poll.c
Could he handy to know for debugging or decisions]]> Kim Alvefur <zash@zash.se> Sun, 27 Feb 2022 14:36:43 +0100 util.poll: Restructure to make adding additional system APIs easier http://hg.omfa.de/prosody-hg/log/898554323338/util-src/poll.c Kim Alvefur <zash@zash.se> Wed, 23 Feb 2022 20:30:22 +0100 util-src: Use the luaL_pushfail API added in Lua 5.4 to highlight all failure conditions http://hg.omfa.de/prosody-hg/log/6eb5d2bb11af/util-src/poll.c
Actually just an alias of pushnil, but it does make it more obvious
where the failure conditions are, which is good for readability.]]> Kim Alvefur <zash@zash.se> Sun, 07 Jun 2020 02:25:56 +0200 util.poll: Add missing return statements in fallback mode http://hg.omfa.de/prosody-hg/log/46a7792fdac5/util-src/poll.c
These allowed modifying or deleting select() state for unregistered FDs.
During normal usage this should never happen. Modifying one that isn't
set might cause weirdness but deleting an already deleted FD isn't a
problem.]]> Kim Alvefur <zash@zash.se> Sun, 28 Jul 2019 16:17:23 +0200 util.poll: Minimize scope of methods http://hg.omfa.de/prosody-hg/log/36280801ddf1/util-src/poll.c
File scope is enough]]> Kim Alvefur <zash@zash.se> Sat, 13 Apr 2019 23:55:34 +0200 net.server_epoll: Special handling of signal interrupts http://hg.omfa.de/prosody-hg/log/2055b497b515/util-src/poll.c Kim Alvefur <zash@zash.se> Fri, 12 Oct 2018 03:22:09 +0200 net.server_epoll: Ignore ENOENT when deregitering socket http://hg.omfa.de/prosody-hg/log/33d21f020b66/util-src/poll.c
It should not really happen]]> Kim Alvefur <zash@zash.se> Fri, 12 Oct 2018 03:21:11 +0200 net.server_epoll: Graceful handling of registering already added socket http://hg.omfa.de/prosody-hg/log/ae6636052be9/util-src/poll.c Kim Alvefur <zash@zash.se> Fri, 12 Oct 2018 03:20:09 +0200 util.poll: Fix inverted logic http://hg.omfa.de/prosody-hg/log/bd178ed0459b/util-src/poll.c Kim Alvefur <zash@zash.se> Thu, 11 Oct 2018 18:56:11 +0200 util.poll: Handle failed epoll FD creation http://hg.omfa.de/prosody-hg/log/f3935aa4cc7e/util-src/poll.c Kim Alvefur <zash@zash.se> Thu, 11 Oct 2018 18:52:12 +0200 util.poll: Early return from __gc in case of no valid epoll FD http://hg.omfa.de/prosody-hg/log/9b26a50cdfe3/util-src/poll.c
This could happen if the epoll FD has already been closed or
the epoll_create call failed]]> Kim Alvefur <zash@zash.se> Thu, 11 Oct 2018 18:50:04 +0200 util.poll: Increase max epoll events per call http://hg.omfa.de/prosody-hg/log/b890ceb1c24f/util-src/poll.c
This makes the struct roughly the same size in both epoll and select
mode (64bit).

There doesn’t seem to be much guidance on an appropriate size, it does
not seem to matter too much since if there are more events they will
simply show up in the next epoll_wait call. The number of exactly
concurrent events should be fairly low most of the time anyways.]]> Kim Alvefur <zash@zash.se> Mon, 08 Oct 2018 15:33:15 +0200 util.poll: Zero FD sets watched for errors on creation http://hg.omfa.de/prosody-hg/log/352e8b75c1ae/util-src/poll.c Kim Alvefur <zash@zash.se> Sun, 07 Oct 2018 20:58:51 +0200 net.poll: Guard against negative or too large FDs http://hg.omfa.de/prosody-hg/log/6397e965a22d/util-src/poll.c Kim Alvefur <zash@zash.se> Sun, 07 Oct 2018 18:44:46 +0200 util.poll: Fix missing return for adding duplicate FD http://hg.omfa.de/prosody-hg/log/6b4d28eb19cf/util-src/poll.c Kim Alvefur <zash@zash.se> Sun, 07 Oct 2018 18:41:44 +0200 util.poll: Tweak metatable name field http://hg.omfa.de/prosody-hg/log/1ddecde4ce98/util-src/poll.c Kim Alvefur <zash@zash.se> Sat, 06 Oct 2018 18:32:57 +0200 util.poll: Fix monitoring of socket exceptions in select mode http://hg.omfa.de/prosody-hg/log/b202aa1e2d7b/util-src/poll.c
Since state->err is a set of all watched FDs, this mistake caused all
sockets to appear to have errors.]]> Kim Alvefur <zash@zash.se> Sat, 06 Oct 2018 17:19:50 +0200 util.poll: Lua 5.1 compat http://hg.omfa.de/prosody-hg/log/3429006518bf/util-src/poll.c Kim Alvefur <zash@zash.se> Sat, 15 Sep 2018 01:17:53 +0200 util.poll: Remove 'inline' from function declaration http://hg.omfa.de/prosody-hg/log/d8496858c809/util-src/poll.c
Why does this fix building?]]> Kim Alvefur <zash@zash.se> Sat, 15 Sep 2018 01:05:59 +0200 util.poll: Import poll library with epoll and select support http://hg.omfa.de/prosody-hg/log/b95ef295c66d/util-src/poll.c Kim Alvefur <zash@zash.se> Wed, 16 May 2018 23:56:34 +0200