prosody-hg: plugins/muc/muc.lib.lua history

MUC: Record timestamps and actors of affiliation changes

Thu, 26 Jun 2025 14:39:45 +0100

MUC: Record timestamps and actors of affiliation changes

This can help with things like timed affiliations or cleanup of obsolete
affiliations, identifying recent changes (e.g. to allow efficient catch-up by
clients when changes to the affiliation list occur), and such, as well as
simple auditing.

MUC: Support for filtering presence broadcasts with per-session filters

Mon, 11 Nov 2024 12:52:54 +0000

MUC: Support for filtering presence broadcasts with per-session filters

Currently no filters are defined, but could be added by modules (hint hint).

Merge 0.12->trunk

Fri, 15 Nov 2024 14:37:10 +0000

Merge 0.12->trunk

MUC: optimizations for broadcast of visitor presence (thanks Jitsi team)

Fri, 15 Nov 2024 14:36:41 +0000

MUC: optimizations for broadcast of visitor presence (thanks Jitsi team)

This avoids doing performing unnecessary work in the case of visitors joining
a MUC, no functionality changes are intended.

MUC: Record reason for affiliation changes and return in list (fixes #1227)

Sun, 08 Aug 2021 18:07:17 +0200

MUC: Record reason for affiliation changes and return in list (fixes #1227)

plugins: Prefix module imports with prosody namespace

Fri, 24 Mar 2023 13:15:28 +0100

plugins: Prefix module imports with prosody namespace

MUC: Allow kicking users with the same affiliation as the kicker (fixes #1724)

Wed, 23 Mar 2022 13:38:55 +0000

MUC: Allow kicking users with the same affiliation as the kicker (fixes #1724)

This is allowed by XEP-0045, which states:

"A moderator SHOULD NOT be allowed to revoke moderation privileges from
someone with a higher affiliation than themselves (i.e., an unaffiliated
moderator SHOULD NOT be allowed to revoke moderation privileges from an admin
or an owner, and an admin SHOULD NOT be allowed to revoke moderation
privileges from an owner)."

MUC: Switch ID algorithm for IQ relay (fixes #1266, #1435)

Tue, 05 Oct 2021 18:15:06 +0200

MUC: Switch ID algorithm for IQ relay (fixes #1266, #1435)

MUC: Remove <{muc}x> tags in some errors

Wed, 08 Dec 2021 21:55:25 +0100

MUC: Remove <{muc}x> tags in some errors

Including the payload of the stanza that caused the error is optional
and we're generally not doing it anywhere else.

MUC: Remove remaining deprecated numeric error codes

Wed, 08 Dec 2021 21:02:14 +0100

MUC: Remove remaining deprecated numeric error codes

The numeric error codes seems to have been removed from the examples in
XEP-0045 version 1.24, and were deprecated even by RFC 3920 in 2004,
only allowed for backwards compatibility.

MUC: Return a friendly textual error when trying to speak without voice

Wed, 08 Dec 2021 16:40:51 +0100

MUC: Return a friendly textual error when trying to speak without voice

I spend several minutes confused over where the bug was until I
remembered I had set myself as visitor in the previous debug session.
This would have helped.

MUC: Allow modules a chance to act prior to room destruction

Sun, 05 Dec 2021 14:49:06 +0100

MUC: Allow modules a chance to act prior to room destruction

MUC: Actually set the new affiliation data if it was previously empty

Tue, 16 Nov 2021 15:00:02 +0000

MUC: Actually set the new affiliation data if it was previously empty

MUC: Include old affiliation data in affiliation change event

Tue, 16 Nov 2021 12:57:23 +0000

MUC: Include old affiliation data in affiliation change event

MUC: Add room:set_affiliation_data()

Tue, 16 Nov 2021 12:57:04 +0000

MUC: Add room:set_affiliation_data()

MUC: Set .previous_affiliation = "none" if nil, for consistency with .affiliation

Tue, 16 Nov 2021 12:02:54 +0000

MUC: Set .previous_affiliation = "none" if nil, for consistency with .affiliation

It appears nothing currently uses this field in prosody or prosody-modules

MUC: Fix incorrect variable name (thanks luacheck)

Tue, 16 Nov 2021 11:54:32 +0000

MUC: Fix incorrect variable name (thanks luacheck)

MUC: Switch to event.allowed signaling to block event, matching muc-pre-set-role

Tue, 16 Nov 2021 11:52:36 +0000

MUC: Switch to event.allowed signaling to block event, matching muc-pre-set-role

...and fixing the logic bug that broke everything in the previous commit.

MUC: Add 'muc-pre-set-affiliation' event, allowing to block change or modify data

Tue, 16 Nov 2021 11:41:08 +0000

MUC: Add 'muc-pre-set-affiliation' event, allowing to block change or modify data

MUC: Reject full JID in affiliation queries

Fri, 17 Sep 2021 16:28:07 +0200

MUC: Reject full JID in affiliation queries

XEP-0045 states:
> Affiliations are granted, revoked, and maintained based on the user's
> bare JID, not the nick as with roles.

Therefore inclusion of a full JID in affiliation queries is invalid.

Thanks to Ge0rG and Poezio for discovering this issue.

Merge 0.11->trunk

Fri, 23 Jul 2021 17:13:06 +0200

Merge 0.11->trunk

MUC: Fix logic for access to affiliation lists

Thu, 22 Jul 2021 17:18:39 +0200

MUC: Fix logic for access to affiliation lists

Fixes https://prosody.im/security/advisory_20210722/

Backs out 4d7b925652d9

MUC: Allow overriding occupant object from groupchat message event

Thu, 25 Mar 2021 13:18:23 +0100

MUC: Allow overriding occupant object from groupchat message event

Use case: Enable module that provides a virtual occupant object for bots

Before, if there is no occupant then either some other part of MUC would
reject the message or `occupant.nick` would have caused an error.

MUC: Reject probes from non-occupants

Fri, 02 Oct 2020 16:12:47 +0200

MUC: Reject probes from non-occupants

Also test for self-probes

MUC: Add support for presence probes (fixes #1535)

Sun, 19 Apr 2020 21:49:45 +0200

MUC: Add support for presence probes (fixes #1535)

The following patch allows Prosody to respond to `probe` presences and send out the probed occupant's current presence.

This is based on line 17.3 in XEP-0045:

A MUC service MAY handle presence probes sent to the room JID or an occupant JID
(e.g, these might be sent by an occupant's home server to determine if the room is still online or to synchronize
presence information if the user or the user's server has gone offline temporarily or has started sharing presence again,
as for instance when Stanza Interception and Filtering Technology (XEP-0273) is used).

Merge 0.11->trunk

Tue, 15 Dec 2020 13:37:05 +0000

Merge 0.11->trunk

MUC: Fix logic bug causing unnecessary presence to be sent, fixes #1615 (thanks damencho)

Tue, 15 Dec 2020 13:36:08 +0000

MUC: Fix logic bug causing unnecessary presence to be sent, fixes #1615 (thanks damencho)

Merge 0.11->trunk

Wed, 07 Oct 2020 13:36:24 +0200

Merge 0.11->trunk

MUC: Preserve disco 'node' attribute (or lack thereof) in response (fix #1595) (thanks lessthan3)

Wed, 07 Oct 2020 13:33:02 +0200

MUC: Preserve disco 'node' attribute (or lack thereof) in response (fix #1595) (thanks lessthan3)

mod_muc: let event handlers modify cloned presence

Wed, 22 Apr 2020 16:12:15 +0200

mod_muc: let event handlers modify cloned presence

Updates #1533

Fixes #1533 Hats don't get sent out to own MUC user

Wed, 22 Apr 2020 16:04:03 +0200

Fixes #1533 Hats don't get sent out to own MUC user

Merge 0.11->trunk

Thu, 23 Apr 2020 13:52:19 +0100

Merge 0.11->trunk

MUC: Always include 'affiliation'/'role' attributes, defaulting to 'none' if nil

Thu, 23 Apr 2020 13:16:25 +0100

MUC: Always include 'affiliation'/'role' attributes, defaulting to 'none' if nil

MUC: Add new event 'muc-build-occupant-presence' for plugins to extend occupant presence

Sat, 11 Apr 2020 16:41:52 +0100

MUC: Add new event 'muc-build-occupant-presence' for plugins to extend occupant presence

Merge 0.11->trunk

Thu, 12 Mar 2020 20:33:27 +0000

Merge 0.11->trunk

MUC: Persist affiliation_data in new MUC format!

Thu, 12 Mar 2020 20:32:07 +0000

MUC: Persist affiliation_data in new MUC format!

Thu, 12 Mar 2020 20:32:07 +0000

MUC: Persist affiliation_data in new MUC format!

MUC: Switch to new storage format by default

Thu, 12 Mar 2020 16:10:44 +0000

MUC: Switch to new storage format by default

Changing the default setting of `new_muc_storage_format` from false to true.

The code supports reading both formats since 0.11, but servers with MUCs stored
using the new format will not be able to downgrade to 0.10 or earlier.

The new format is clearer (less nesting for the most commonly-accessed data),
and combined with the new map-store methods, allows for some operations to become
more efficient (such as finding out which MUCs on a service a given user is affiliated
with).

MUC: Support for broadcasting unavailable presence for affiliated offline users

Thu, 12 Mar 2020 16:01:31 +0000

MUC: Support for broadcasting unavailable presence for affiliated offline users

Activated when muc#roomconfig_presencebroadcast includes the "none" role.

MUC: Pass previous role to :publicise_occupant_status() when destroying a MUC

Thu, 12 Mar 2020 14:35:34 +0000

MUC: Pass previous role to :publicise_occupant_status() when destroying a MUC

MUC: Pass previous role to :publicise_occupant_status() whenever possible

Thu, 12 Mar 2020 14:10:12 +0000

MUC: Pass previous role to :publicise_occupant_status() whenever possible

Currently there is what amounts to a hack in presence_broadcast.lib.lua to
make it always broadcast presence with roles of "none". This is to ensure
that if you previously saw available presence for someone, you will also
see the unavailable presence (which always has role="none").

The correct approach is to take into account what the previous role was (
i.e. answer the question: "Was the available presence for this occupant
a role for which presence broadcast is enabled?).

The logic is already in place to do this correctly, but most call sites
do not provide the previous role (prev_role argument) of the occupant,
which causes it to not be used. In its place the hack to always broadcast
presence of role="none" has allowed things to continue to work.

The intention is that a subsequent commit will remove the unconditional
broadcast of role="none".

mod_muc: add muc-private-message event

Mon, 24 Feb 2020 14:16:45 +0100

mod_muc: add muc-private-message event

This seems to be the one place handling MUC-PMs. This event is added so that
plugins (such as muc_occupant_id) can edit them without having to redo the work.

MUC: Make note to handle configuration form errors [luacheck]

Mon, 23 Dec 2019 22:28:04 +0100

MUC: Make note to handle configuration form errors [luacheck]

MUC: Remove some unused variables [luacheck]

Mon, 23 Dec 2019 22:23:29 +0100

MUC: Remove some unused variables [luacheck]

MUC: Add missing reference to room (thanks buildbot) [luacheck]

Tue, 26 Nov 2019 00:09:51 +0100

MUC: Add missing reference to room (thanks buildbot) [luacheck]

MUC: Indicate that the room is the origin of various errors where 'from' is an occupant JID

Mon, 25 Nov 2019 23:52:45 +0100

MUC: Indicate that the room is the origin of various errors where 'from' is an occupant JID

Merge 0.11->trunk

Sat, 23 Nov 2019 23:12:01 +0100

Merge 0.11->trunk

MUC: Keep role across nickname change (fixes #1466)

Sat, 23 Nov 2019 01:05:28 +0100

MUC: Keep role across nickname change (fixes #1466)

MUC: Enforce strict resourceprep on nicknames (bye bye robot face)

Mon, 23 Sep 2019 19:13:14 +0200

MUC: Enforce strict resourceprep on nicknames (bye bye robot face)

MUC: Add controls for whose presence is broadcast (closes #1335)

Sun, 20 Oct 2019 21:58:16 +0200

MUC: Add controls for whose presence is broadcast (closes #1335)

Committed by Zash

Merge 0.11-trunk

Sun, 29 Sep 2019 20:48:58 +0200

Merge 0.11-trunk

MUC: Strip tags with MUC-related namespaces from private messages (fixes #1427)

Sun, 29 Sep 2019 20:48:00 +0200

MUC: Strip tags with MUC-related namespaces from private messages (fixes #1427)

Prevents duplication since it adds another <{muc#user}x> here

Merge 0.11->trunk

Wed, 21 Aug 2019 00:36:42 +0200

Merge 0.11->trunk

MUC: Advertise XEP-0410 support

Tue, 30 Jul 2019 08:01:22 +0200

MUC: Advertise XEP-0410 support

Unsure if the feature was in the XEP at the time of 7c1cdf5f9f83

MUC: Reflow event tables to improve readability

Wed, 19 Jun 2019 08:51:39 +0200

MUC: Reflow event tables to improve readability

Also makes it easier to read diffs of added fields.

MUC: Update error message for consistency

Mon, 18 Mar 2019 09:50:23 +0000

MUC: Update error message for consistency

MUC: Fire an event to allow affecting decision of whether to allow a role change

Sun, 24 Feb 2019 16:30:11 +0100

MUC: Fire an event to allow affecting decision of whether to allow a role change

MUC: Factor out role change permission check into its own method

Sun, 24 Feb 2019 16:18:30 +0100

MUC: Factor out role change permission check into its own method

I would like to invert this logic so that it checks if the role change
is allowed instead of checking if it is not allowed as it does now, in
order to make it easier to understand.

Merge 0.11->trunk

Mon, 04 Feb 2019 09:28:02 +0000

Merge 0.11->trunk

MUC: Add error message to error bounces when not joined to room

Mon, 04 Feb 2019 09:27:43 +0000

MUC: Add error message to error bounces when not joined to room