prosody-hg: plugins/mod_s2s/mod_s2s.lua history

mod_dialback: Remove d-w-d feature

Wed, 12 May 2021 17:22:02 +0200

mod_dialback: Remove d-w-d feature

Backs out 1d0862814bfc and 2fdd71b08126

Largely unused, undocumented and did not have enough tests to provide
confidence in its correct operation.

mod_c2s, mod_s2s, mod_component, mod_bosh, mod_websockets: Set default stanza size limits

Fri, 07 May 2021 17:03:49 +0100

mod_c2s, mod_s2s, mod_component, mod_bosh, mod_websockets: Set default stanza size limits

c2s/bosh/ws streams will default to 256KB, s2s and components to 512KB.

These values are aligned with ejabberd's default settings, which should reduce
issues related to inconsistent size limits between servers on the XMPP network.

The previous default (10MB) is excessive for any production server, and allows
significant memory usage by even unauthenticated sessions.

mod_s2s: Fix copypaste mistake in b3ae48362f78

Wed, 16 Dec 2020 08:50:20 +0100

mod_s2s: Fix copypaste mistake in b3ae48362f78

Directly sending something over s2s needs to use sends2s() but the code
copied from mod_c2s had .send()

mod_s2s: Prevent whitespace keepalives the stream has been opened

Thu, 10 Dec 2020 11:53:10 +0100

mod_s2s: Prevent whitespace keepalives the stream has been opened

This will result in the stream timing out instead, which is probably
correct if the stream has not been opened yet.

This was already done for c2s in e69df8093387

Thanks Ge0rG

mod_c2s,mod_s2s: Make stanza size limits configurable

Sun, 31 May 2020 22:39:34 +0200

mod_c2s,mod_s2s: Make stanza size limits configurable

mod_s2s: Escape invalid XML in loggin (same way as mod_c2s) fix #1574

Sat, 01 Aug 2020 12:58:37 +0200

mod_s2s: Escape invalid XML in loggin (same way as mod_c2s) fix #1574

mod_c2s,mod_s2s: Make stanza size limits configurable

Sun, 31 May 2020 22:39:34 +0200

mod_c2s,mod_s2s: Make stanza size limits configurable

mod_c2s,mod_s2s: Use a distinct stream error for hitting stanza size limit

Sun, 31 May 2020 22:25:48 +0200

mod_c2s,mod_s2s: Use a distinct stream error for hitting stanza size limit

Since this is not a real parse error, it should not be reported as such.

mod_s2s: Run stream close in async context

Fri, 08 May 2020 23:55:51 +0200

mod_s2s: Run stream close in async context

Allows async processing during stream shutdown. Fixes potential ASYNC-01
issues, however no such issues known at the time of this commit.

mod_s2s: Improve signaling of stream open events

Fri, 08 May 2020 23:54:17 +0200

mod_s2s: Improve signaling of stream open events

Makes it clearer, cleaner and easier to extend.

mod_s2s: Fix typo in comment [codespell]

Thu, 13 Feb 2020 23:03:03 +0100

mod_s2s: Fix typo in comment [codespell]

mod_s2s: Comment on the various 'reason' arguments passed to :close

Sun, 26 Jan 2020 19:52:48 +0100

mod_s2s: Comment on the various 'reason' arguments passed to :close

mod_s2s: Pass use_ipv4/use_ipv6 from config to service resolver

Sat, 25 Jan 2020 14:38:42 +0000

mod_s2s: Pass use_ipv4/use_ipv6 from config to service resolver

Backed out changeset 74d66b1be989 (not optimal API)

Sat, 25 Jan 2020 14:25:21 +0000

Backed out changeset 74d66b1be989 (not optimal API)

mod_s2s: Pass use_ipv4/ipv6 from config to connector config

Fri, 24 Jan 2020 13:49:33 +0000

mod_s2s: Pass use_ipv4/ipv6 from config to connector config

mod_s2s: Remove obsolete pre-connect buffer

Tue, 17 Dec 2019 00:34:39 +0100

mod_s2s: Remove obsolete pre-connect buffer

Originally added in c500d4cb7855

Dead code since the net.connect switch in 756b8821007a

mod_s2s: Fix name conflict introduced in c7864f970969

Tue, 10 Dec 2019 17:43:26 +0100

mod_s2s: Fix name conflict introduced in c7864f970969

mod_s2s: Invert condition to return early and reduce indentation

Wed, 04 Dec 2019 22:37:20 +0100

mod_s2s: Invert condition to return early and reduce indentation

mod_s2s: Fix mistake in 28755107c2f4

Tue, 03 Dec 2019 17:29:43 +0100

mod_s2s: Fix mistake in 28755107c2f4

mod_s2s: Refactor stream error handling on close

Sun, 01 Dec 2019 12:21:26 +0100

mod_s2s: Refactor stream error handling on close

Deduplicates the 3 log calls that log the same thing but subtly
differently. The first one would say "Disconnecting localhost" and the
last one didn't log the IP.

mod_s2s: Use stanza type check instead of duck typing

Sun, 01 Dec 2019 12:19:36 +0100

mod_s2s: Use stanza type check instead of duck typing

mod_s2s: Improve TLS handshake error messages

Sun, 01 Dec 2019 01:20:34 +0100

mod_s2s: Improve TLS handshake error messages

This should make it clearer that it's about the TLS handshake. Otherwise
it's something like "unsupported protocol" or "no shared ciphers" that
might not be that obvious.

mod_s2s: Log from session logger

Sat, 30 Nov 2019 23:33:39 +0100

mod_s2s: Log from session logger

Helps locating all messages related to a specific session

mod_s2s: Improve log message about forbidding insecure connections

Sat, 30 Nov 2019 23:29:15 +0100

mod_s2s: Improve log message about forbidding insecure connections

This new wording generator is nice.

mod_net_multiplex: Add support for using ALPN

Fri, 29 Nov 2019 23:27:51 +0100

mod_net_multiplex: Add support for using ALPN

Potentially a bit more efficient since it can jump to the selected
protocol on connect instead of waiting for some data to look at.

Adds a 'protocol' field to net providers for this purpose.

mod_s2s: Prevent unhandled stanza handler from complaining about stream features on aborted connections

Fri, 29 Nov 2019 18:15:23 +0100

mod_s2s: Prevent unhandled stanza handler from complaining about stream features on aborted connections

I have no idea why I wrote return false in e5945fb5b71f

mod_s2s: Abort outgoing connections earlier when TLS requirement isn't satisfied

Thu, 28 Nov 2019 18:30:30 +0100

mod_s2s: Abort outgoing connections earlier when TLS requirement isn't satisfied

This ensures the closure reason is accurate and not reported as an
authentication or other problem

mod_s2s: Send stream errors for cert problems on outgoing connections

Thu, 28 Nov 2019 17:32:15 +0100

mod_s2s: Send stream errors for cert problems on outgoing connections

Rationale in comment.

mod_s2s: Improve error in bounces due to cert validation problems

Wed, 27 Nov 2019 23:26:59 +0100

mod_s2s: Improve error in bounces due to cert validation problems

mod_s2s: Add error text for error replies on some s2s failures (#770)

Sat, 23 Nov 2019 01:32:53 +0100

mod_s2s: Add error text for error replies on some s2s failures (#770)

s2s: Allow passing a custom error for bouncing queued stanzas (#770)

Sat, 23 Nov 2019 01:29:03 +0100

s2s: Allow passing a custom error for bouncing queued stanzas (#770)

Since stream errors and stanza errors are different

mod_s2s: Wait for remote to close any connection allowing incoming stanzas

Mon, 18 Nov 2019 20:37:40 +0100

mod_s2s: Wait for remote to close any connection allowing incoming stanzas

Ie both s2sin and bidi-enabled s2sout.

mod_s2s: Allow passing bounce reason as an util.error object (see #770)

Fri, 08 Nov 2019 23:03:47 +0100

mod_s2s: Allow passing bounce reason as an util.error object (see #770)

This argument is currently unused in s2smanager.

mod_s2s: Only nameprep stream to/from addresses if they are present

Sat, 02 Nov 2019 15:43:17 +0100

mod_s2s: Only nameprep stream to/from addresses if they are present

Prevents traceback from nameprep(nil)

mod_s2s: Close with a stream error in case neither SASL or Dialback are available

Sun, 06 Oct 2019 21:14:53 +0200

mod_s2s: Close with a stream error in case neither SASL or Dialback are available

This both tells the remote server and users who sent any queued stanzas
why it failed.

mod_s2s: Remove warning about hostname mismatch

Sat, 07 Sep 2019 18:54:59 +0200

mod_s2s: Remove warning about hostname mismatch

It triggers on bidi-related routing where this to/from is flipped.

Removing since I don't think we have ever seen this potential bug.

mod_s2s: Insert s2sin into outgoing routing table when bidirectional

Sat, 07 Sep 2019 18:33:16 +0200

mod_s2s: Insert s2sin into outgoing routing table when bidirectional

mod_s2s: Add function to send replies on s2sout connections that support incoming traffic

Sat, 07 Sep 2019 18:32:29 +0200

mod_s2s: Add function to send replies on s2sout connections that support incoming traffic

mod_s2s: Handle authentication of s2sin and s2sout the same way

Sat, 07 Sep 2019 17:44:57 +0200

mod_s2s: Handle authentication of s2sin and s2sout the same way

mod_s2s: Remove obsolete cleanup code

Sat, 07 Sep 2019 19:00:37 +0200

mod_s2s: Remove obsolete cleanup code

These were added by s2sout.lib

Remove COMPAT with temporary luasec fork

Sun, 25 Aug 2019 23:12:55 +0200

Remove COMPAT with temporary luasec fork

The changes in the temporary fork were merged into mainline luasec ca
2013 and included in the 0.5 release in 2014.

mod_s2s: Use net.connect instead of s2sout.lib for outgoing s2s connections

Sat, 10 Nov 2018 13:37:32 +0100

mod_s2s: Use net.connect instead of s2sout.lib for outgoing s2s connections

mod_s2s: Distinguish between high and low level errors in bounces

Thu, 01 Aug 2019 05:25:34 +0200

mod_s2s: Distinguish between high and low level errors in bounces

`remote-server-not-found` is reported for problems occurring without a
reply `` having been opened, e.g. DNS records were not found or
no TCP stream could be established to a functioning XMPP entity.

`remote-server-timeout` is reported for problems that occurring after a
stream has been opened, such as configuration problems, inability to
perform TLS or unsuccessful certificate validation.

Related: #770

plugins: Remove tostring call from logging

Tue, 30 Jul 2019 02:29:36 +0200

plugins: Remove tostring call from logging

Taken care of by loggingmanager now

Mass-rewrite using lua pattern like `tostring%b()`

mod_tls: Restore querying for certificates on s2s

Mon, 11 Mar 2019 13:07:59 +0100

mod_tls: Restore querying for certificates on s2s

The 'ssl_config' setting in the mod_s2s network service is not used.
Only direct TLS ports use this currently.

core.certmanager: Do not ask for client certificates by default

Sun, 10 Mar 2019 19:58:28 +0100

core.certmanager: Do not ask for client certificates by default

Since it's mostly only mod_s2s that needs to request client
certificates it makes some sense to have mod_s2s ask for this, instead
of having eg mod_http ask to disable it.

mod_c2s, mod_s2s, mod_component: Log invalid XML escaped (fixes #734)

Tue, 15 Jan 2019 20:08:30 +0100

mod_c2s, mod_s2s, mod_component: Log invalid XML escaped (fixes #734)

See 6ed0d6224d64

mod_s2s: Indicate origin of s2s error

Mon, 08 Oct 2018 15:03:26 +0200

mod_s2s: Indicate origin of s2s error

mod_s2s: Silence all warnings instead of ignoring the entire module

Sun, 30 Sep 2018 17:49:56 +0200

mod_s2s: Silence all warnings instead of ignoring the entire module

Merge 0.10->trunk

Mon, 30 Jul 2018 15:13:54 +0100

Merge 0.10->trunk

sessionmanager, mod_s2s: Bring debug line for outgoing stanzas in line with that for incoming

Tue, 24 Jul 2018 19:07:26 +0200

sessionmanager, mod_s2s: Bring debug line for outgoing stanzas in line with that for incoming

mod_s2s: Reduce logging (#776)

Sun, 22 Jul 2018 19:45:58 +0200

mod_s2s: Reduce logging (#776)

sessionmanager, mod_s2s: Bring debug line for outgoing stanzas in line with that for incoming

Tue, 24 Jul 2018 19:07:26 +0200

sessionmanager, mod_s2s: Bring debug line for outgoing stanzas in line with that for incoming

mod_s2s: Reduce logging (#776)

Sun, 22 Jul 2018 19:45:58 +0200

mod_s2s: Reduce logging (#776)

Merge 0.10->trunk

Fri, 22 Jun 2018 14:18:36 +0200

Merge 0.10->trunk

mod_s2s: Close sockets held by resolver (#1170)

Sun, 17 Jun 2018 20:02:40 +0200

mod_s2s: Close sockets held by resolver (#1170)

mod_s2s: Add a counter for IPv6.

Sat, 09 Sep 2017 14:45:23 +0100

mod_s2s: Add a counter for IPv6.

mod_s2s: Don't use string concatenation when passing values to logging

Sun, 25 Feb 2018 11:20:56 +0100

mod_s2s: Don't use string concatenation when passing values to logging

mod_s2s: Remove tostring() in logging since this is handled by util.format now

Thu, 21 Dec 2017 07:00:56 +0100

mod_s2s: Remove tostring() in logging since this is handled by util.format now

mod_s2s: Restructure some code

Tue, 05 Dec 2017 13:24:28 +0100

mod_s2s: Restructure some code