http://hg.omfa.de/prosody-hg/ en-us prosody-hg: plugins/mod_proxy65.lua history plugins/mod_proxy65.lua revision history Merge 0.12->13.0 http://hg.omfa.de/prosody-hg/log/e3ddbf7f2d3f/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Wed, 29 Apr 2026 17:12:11 +0100 mod_proxy65: Consistently apply authorization checks http://hg.omfa.de/prosody-hg/log/4bbb17445ed9/plugins/mod_proxy65.lua
The module checked for authorization when a client asked for the address:port
of the proxy service. It did not check for authorization when processing a
request to activate a bytestream. This meant that any unauthenticated party
able to guess the IP/port and XMPP domain of a proxy65 service (generally low
difficulty) would be able to use the proxy to relay traffic between two
connections.

This factors out the permission check, and applies it to every request type.]]> Matthew Wild <mwild1@gmail.com> Wed, 29 Apr 2026 11:40:43 +0100 mod_proxy65: Don't link connections until after activation http://hg.omfa.de/prosody-hg/log/f34ad235cf3b/plugins/mod_proxy65.lua
Although the module pauses the connections, in some cases server.link() (at
least with the epoll backend) will have the effect of unpausing the connection
(because it sets new read handlers).

Many thanks to Max Hearnden for discovering and reporting this issue.]]> Matthew Wild <mwild1@gmail.com> Wed, 29 Apr 2026 11:37:21 +0100 mod_proxy65: Consistently apply authorization checks http://hg.omfa.de/prosody-hg/log/2a66728d9e29/plugins/mod_proxy65.lua
The module checked for authorization when a client asked for the address:port
of the proxy service. It did not check for authorization when processing a
request to activate a bytestream. This meant that any unauthenticated party
able to guess the IP/port and XMPP domain of a proxy65 service (generally low
difficulty) would be able to use the proxy to relay traffic between two
connections.

This factors out the permission check, and applies it to every request type.]]> Matthew Wild <mwild1@gmail.com> Wed, 29 Apr 2026 11:40:43 +0100 mod_proxy65: Don't link connections until after activation http://hg.omfa.de/prosody-hg/log/9c98cc9d9588/plugins/mod_proxy65.lua
Although the module pauses the connections, in some cases server.link() (at
least with the epoll backend) will have the effect of unpausing the connection
(because it sets new read handlers).

Many thanks to Max Hearnden for discovering and reporting this issue.]]> Matthew Wild <mwild1@gmail.com> Wed, 29 Apr 2026 11:37:21 +0100 plugins: Prefix module imports with prosody namespace http://hg.omfa.de/prosody-hg/log/74b9e05af71e/plugins/mod_proxy65.lua Kim Alvefur <zash@zash.se> Fri, 24 Mar 2023 13:15:28 +0100 Merge 0.11->trunk http://hg.omfa.de/prosody-hg/log/3bbb1af92514/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Thu, 13 May 2021 11:17:13 +0100 mod_proxy65: Restrict access to local c2s connections by default http://hg.omfa.de/prosody-hg/log/65dcc175ef5b/plugins/mod_proxy65.lua
Previously no 'proxy65_acl' option would allow unrestricted access by local or
remote JIDs.]]> Matthew Wild <mwild1@gmail.com> Wed, 12 May 2021 13:59:49 +0100 mod_proxy65: Limit dump of invalid data to 300 bytes (like mod_c2s) http://hg.omfa.de/prosody-hg/log/027af78d8125/plugins/mod_proxy65.lua Kim Alvefur <zash@zash.se> Fri, 17 Jul 2020 08:29:03 +0200 mod_proxy65: Log invalid greetings escaped instead of as base64 http://hg.omfa.de/prosody-hg/log/c079103c9172/plugins/mod_proxy65.lua
Makes it easier to see human-readable parts and thus identifying the
garbage. Also consistent with mod_c2s and others.]]> Kim Alvefur <zash@zash.se> Thu, 16 Jul 2020 10:26:36 +0200 plugins: Remove tostring call from logging http://hg.omfa.de/prosody-hg/log/0f335815244f/plugins/mod_proxy65.lua
Taken care of by loggingmanager now

Mass-rewrite using lua pattern like `tostring%b()`]]> Kim Alvefur <zash@zash.se> Tue, 30 Jul 2019 02:29:36 +0200 Merge 0.10->0.11 http://hg.omfa.de/prosody-hg/log/cc642c9c5ad5/plugins/mod_proxy65.lua Kim Alvefur <zash@zash.se> Mon, 26 Nov 2018 19:48:07 +0100 mod_proxy65: Check what port is used at the time of the query http://hg.omfa.de/prosody-hg/log/bb8486491b48/plugins/mod_proxy65.lua
Could have changed between startup and time of request]]> Kim Alvefur <zash@zash.se> Sun, 25 Nov 2018 13:16:17 +0100 mod_proxy65: Return an error if no port is open (fixes #1240) http://hg.omfa.de/prosody-hg/log/e31053344231/plugins/mod_proxy65.lua Kim Alvefur <zash@zash.se> Sun, 25 Nov 2018 13:14:05 +0100 mod_proxy65: Split module:shared() into multiple calls, multiple params may be deprecated soon http://hg.omfa.de/prosody-hg/log/6bd3602a70e2/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Tue, 07 Aug 2018 21:14:43 +0100 Fix spelling throughout the codebase [codespell] http://hg.omfa.de/prosody-hg/log/41c959c5c84b/plugins/mod_proxy65.lua Kim Alvefur <zash@zash.se> Sun, 04 Feb 2018 01:51:25 +0100 mod_proxy65: Fix all warnings from luacheck http://hg.omfa.de/prosody-hg/log/11b6aa30b3e0/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Wed, 21 Mar 2018 22:13:11 +0000 mod_proxy65: Fix passing number to stanza API (thanks mimi89999) http://hg.omfa.de/prosody-hg/log/d2556f237bc2/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Wed, 21 Mar 2018 22:10:24 +0000 mod_proxy65: Use typed config API (fix issues when options are set to unexpected types) http://hg.omfa.de/prosody-hg/log/e6968e47826d/plugins/mod_proxy65.lua Kim Alvefur <zash@zash.se> Thu, 03 Dec 2015 15:27:09 +0100 mod_proxy65: Use mod_disco http://hg.omfa.de/prosody-hg/log/f8c17af769d9/plugins/mod_proxy65.lua Florian Zeitz <florob@babelmonkeys.de> Wed, 19 Feb 2014 20:13:35 +0100 Remove all trailing whitespace http://hg.omfa.de/prosody-hg/log/bd0ff8ae98a8/plugins/mod_proxy65.lua Florian Zeitz <florob@babelmonkeys.de> Fri, 09 Aug 2013 17:48:21 +0200 mod_proxy65: Fix typo in comment http://hg.omfa.de/prosody-hg/log/b31ab26f9997/plugins/mod_proxy65.lua Kim Alvefur <zash@zash.se> Sat, 23 Mar 2013 01:42:48 +0100 mod_proxy65: Only handle service discovery requests when no node is present in the request. http://hg.omfa.de/prosody-hg/log/eeb24f1e2c84/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Tue, 26 Feb 2013 23:57:44 +0500 mod_proxy65: Fix ACL http://hg.omfa.de/prosody-hg/log/9a01c6bc435e/plugins/mod_proxy65.lua Kim Alvefur <zash@zash.se> Tue, 29 May 2012 17:20:02 +0200 mod_proxy65: Add missing import of portmanager http://hg.omfa.de/prosody-hg/log/d1dca1d12d53/plugins/mod_proxy65.lua Kim Alvefur <zash@zash.se> Sun, 27 May 2012 01:22:02 +0200 mod_proxy65: Warn about pre-0.9 config style (per host proxy65_port) http://hg.omfa.de/prosody-hg/log/31496e8227e8/plugins/mod_proxy65.lua Kim Alvefur <zash@zash.se> Sun, 27 May 2012 01:17:59 +0200 mod_proxy65: Fix traceback when proxy65 service fails to bind a port http://hg.omfa.de/prosody-hg/log/da3c1d980c04/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Fri, 27 Apr 2012 22:18:20 +0100 mod_proxy65: Add multiplex pattern. http://hg.omfa.de/prosody-hg/log/3d90264c7b3d/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Wed, 25 Apr 2012 07:55:13 +0500 mod_proxy65: Port to portmanager, make a shared module http://hg.omfa.de/prosody-hg/log/5b52b5eaa03d/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Tue, 24 Apr 2012 18:50:22 +0100 mod_proxy65: Major cleanup, better logging, handling of all error cases, less code, and other goodness. http://hg.omfa.de/prosody-hg/log/aa2e79f20962/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Sun, 06 Nov 2011 00:51:39 +0500 mod_proxy65: Apply stringprep to activation target JID. http://hg.omfa.de/prosody-hg/log/99277a1abe58/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Sat, 03 Sep 2011 01:07:35 +0500 mod_proxy65: Some more cleanup. http://hg.omfa.de/prosody-hg/log/81f5e83211dd/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Sat, 03 Sep 2011 00:37:37 +0500 mod_proxy65: Cleanup. http://hg.omfa.de/prosody-hg/log/c38f20f172b3/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Fri, 02 Sep 2011 23:50:34 +0500 mod_proxy65: Add service discovery identity and feature, to help out mod_disco when loaded on a normal host. http://hg.omfa.de/prosody-hg/log/a7d88f58abbb/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Fri, 03 Dec 2010 00:29:44 +0500 mod_proxy65: Cleaned up stanza processing a little. http://hg.omfa.de/prosody-hg/log/519f5eadf4b9/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Fri, 03 Dec 2010 00:22:11 +0500 mod_proxy65: s:len() -> #s. http://hg.omfa.de/prosody-hg/log/117778c5a7fe/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Fri, 03 Dec 2010 00:21:49 +0500 mod_proxy65: Make some globals local. http://hg.omfa.de/prosody-hg/log/07f789ac7e3c/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Fri, 03 Dec 2010 00:13:30 +0500 mod_proxy65: :sub(n):byte() -> :byte(n). http://hg.omfa.de/prosody-hg/log/8f9fac97e6e6/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Fri, 03 Dec 2010 00:12:55 +0500 mod_proxy65: Allow loading on normal hosts. http://hg.omfa.de/prosody-hg/log/2ca76b4f6404/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Fri, 03 Dec 2010 00:04:32 +0500 mod_proxy65: Updated to use sub-events. Now only hooks what it needs to. http://hg.omfa.de/prosody-hg/log/f7de887ea0be/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Fri, 03 Dec 2010 00:02:53 +0500 mod_proxy65: Give the 'iq/host' stanza handler a negative priority, to allow mod_iq to process the events first. http://hg.omfa.de/prosody-hg/log/13a1d90b4e1c/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Thu, 02 Dec 2010 16:17:44 +0500 mod_proxy65: Use module:get_option() instead of configmanager. http://hg.omfa.de/prosody-hg/log/e1259b6d7560/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Wed, 10 Nov 2010 22:02:28 +0500 prosody: Removed all references to componentmanager from Prosody, except the main componentmanager file. http://hg.omfa.de/prosody-hg/log/3e89f0509967/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Wed, 10 Nov 2010 20:59:16 +0500 mod_proxy65: Removed useless checks from the event handler. http://hg.omfa.de/prosody-hg/log/0708d42ef0d4/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Thu, 04 Nov 2010 19:26:04 +0500 mod_proxy65: Use "iq/host" event for hooking stanzas instead of the component stanza handler. http://hg.omfa.de/prosody-hg/log/f1201ff060b7/plugins/mod_proxy65.lua Waqas Hussain <waqas20@gmail.com> Thu, 04 Nov 2010 19:18:32 +0500 mod_proxy65: Use util.jid.compare() and remove some clutter http://hg.omfa.de/prosody-hg/log/9328179c9c76/plugins/mod_proxy65.lua Kim Alvefur <zash@zash.se> Fri, 16 Jul 2010 16:12:18 +0200 mod_proxy65: Send error reply to activation stanza if one or both parties were not connected to the proxy http://hg.omfa.de/prosody-hg/log/a3580f556c27/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Wed, 05 May 2010 15:33:29 +0100 mod_proxy65: Return service-unavailable error when receiving an iq we didn't understand http://hg.omfa.de/prosody-hg/log/c49be80767ee/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Wed, 05 May 2010 15:32:16 +0100 mod_proxy65: Use new server.link to link proxied connections, now works with either connection backend http://hg.omfa.de/prosody-hg/log/c20b9fe1624b/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Wed, 05 May 2010 15:31:18 +0100 mod_proxy65: Fix for old-style closing of connections (another source of tracebacks with libevent enabled) http://hg.omfa.de/prosody-hg/log/7e0c35713bf5/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Mon, 01 Mar 2010 18:07:37 +0000 mod_proxy65: Strip trailing whitespace http://hg.omfa.de/prosody-hg/log/2ca7445b882a/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Fri, 04 Dec 2009 14:41:53 +0000 mod_proxy65: Don't read data from the connection untill the proxying is activated http://hg.omfa.de/prosody-hg/log/5fe837ebe542/plugins/mod_proxy65.lua Sjoerd Simons <sjoerd.simons@collabora.co.uk> Thu, 03 Dec 2009 17:07:37 +0100 mod_proxy65: Make the proxying bidirectional http://hg.omfa.de/prosody-hg/log/e74c6740a42b/plugins/mod_proxy65.lua Sjoerd Simons <sjoerd.simons@collabora.co.uk> Thu, 03 Dec 2009 17:05:35 +0100 mod_proxy65: Use a bigger buffer for data we're proxying http://hg.omfa.de/prosody-hg/log/7dc6049a69e8/plugins/mod_proxy65.lua
A slightly larger buffer seems to preform a lot better]]> Sjoerd Simons <sjoerd.simons@collabora.co.uk> Thu, 03 Dec 2009 17:04:54 +0100 mod_proxy65: Only lock the reading side when throttling http://hg.omfa.de/prosody-hg/log/600ac8992a4c/plugins/mod_proxy65.lua Sjoerd Simons <sjoerd.simons@collabora.co.uk> Thu, 03 Dec 2009 17:02:38 +0100 mod_proxy65: Throttle connections to prevent senders flooding the server's buffers if the receiver doesn't receive fast enough http://hg.omfa.de/prosody-hg/log/21f0d80f244a/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Thu, 03 Dec 2009 14:15:30 +0000 mod_proxy65: Replace error() calls with module:log("error", ...) http://hg.omfa.de/prosody-hg/log/7ddd00260808/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Thu, 03 Dec 2009 14:13:09 +0000 mod_proxy65: Remove trailing whitespace http://hg.omfa.de/prosody-hg/log/b98b29f614ae/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Tue, 01 Dec 2009 20:18:47 +0000 mod_proxy65: Fix log:module -> module:log :) http://hg.omfa.de/prosody-hg/log/9c3564117b24/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Tue, 01 Dec 2009 20:07:07 +0000 mod_proxy65: Use new jid.join() from util.jid http://hg.omfa.de/prosody-hg/log/6e0c861dc61f/plugins/mod_proxy65.lua Matthew Wild <mwild1@gmail.com> Fri, 27 Nov 2009 18:02:24 +0000