prosody-hg: plugins/mod_pep.lua history

mod_pep: Support for node/item management commands

Tue, 07 Jan 2025 14:27:34 +0000

mod_pep: Support for node/item management commands

mod_pep: Implement 'roster' (group) access_model

Sun, 03 Dec 2023 23:19:27 +0100

mod_pep: Implement 'roster' (group) access_model

Allows e.g. restricting your vcard4 to only family or similar.

Notes: This does not include roster groups in the configuration form,
so the client will have to get them from the actual roster.

plugins: Use integer config API with interval specification where sensible

Mon, 17 Jul 2023 01:38:54 +0200

plugins: Use integer config API with interval specification where sensible

Many of these fall into a few categories:
- util.cache size, must be >= 1
- byte or item counts that logically can't be negative
- port numbers that should be in 1..0xffff

plugins: Prefix module imports with prosody namespace

Fri, 24 Mar 2023 13:15:28 +0100

plugins: Prefix module imports with prosody namespace

mod_pep: Pass node/service objects to broadcaster when resending last item

Wed, 22 Mar 2023 16:46:39 +0000

mod_pep: Pass node/service objects to broadcaster when resending last item

This gives the broadcaster access to the node configuration, which is now
important for itemreply. It probably also fixes a bug with the notify_*
node config options?

mod_pubsub, mod_pep: Support per-node configurable inclusion of publisher

Wed, 22 Mar 2023 11:39:19 +0000

mod_pubsub, mod_pep: Support per-node configurable inclusion of publisher

This matches ejabberd's behaviour, using the 'pubsub#itemreply' config option.

Although the current definition of this option in the specification is not
as clear as it could be, I think matching what existing deployments do is the
best option to resolve the ambiguity and reduce fragmentation.

We should update the spec to be clearer about how to use and interpret this
option.

The 'expose_publisher' option for mod_pubsub is now an override (always expose
or never expose). If unset, it will use the per-node config (which defaults to
not exposing).

Thanks to Link Mauve, edhelas and goffi for sparking this feature.

mod_pep: Fix typo in comment [codespell]

Fri, 04 Feb 2022 16:40:23 +0100

mod_pep: Fix typo in comment [codespell]

mod_pep: Clarify purpose of fallback service

Thu, 03 Feb 2022 10:02:26 +0100

mod_pep: Clarify purpose of fallback service

Extra-extra obvious that no interaction with this should lead to
persisted changes

mod_pep: Correct initialization of fallback service

Thu, 03 Feb 2022 09:46:19 +0100

mod_pep: Correct initialization of fallback service

I'm not sure what went wrong here, copy-paste mistake?
Doesn't matter as long as nobody can create nodes on this service.

util.pubsub: Fix item store resize to "max"

Thu, 06 Jan 2022 01:18:35 +0100

util.pubsub: Fix item store resize to "max"

Previously this would end up passing the "max" directly to the
underlying storage.

Merge 0.11->trunk

Mon, 20 Dec 2021 23:12:08 +0100

Merge 0.11->trunk

mod_pep: Wipe pubsub service on user deletion

Thu, 04 Nov 2021 01:00:06 +0100

mod_pep: Wipe pubsub service on user deletion

Data is already wiped from storage, but this ensures everything is
properly unsubscribed, possibly with notifications etc.

Clears recipient cache as well, since it is no longer relevant.

mod_pep: Prevent creation of services for non-existent users

Thu, 04 Nov 2021 00:55:59 +0100

mod_pep: Prevent creation of services for non-existent users

Using a dedicated service should give identical behavior, except for a
possible timing difference in the user existence lookup.

mod_pep: Limit possible growth of node subscription info

Thu, 04 Nov 2021 00:36:41 +0100

mod_pep: Limit possible growth of node subscription info

mod_pep: Limit possible growth of number of pubsub services

Thu, 04 Nov 2021 00:35:44 +0100

mod_pep: Limit possible growth of number of pubsub services

mod_pep: Don't pass pubsub services across reloads

Thu, 04 Nov 2021 00:33:58 +0100

mod_pep: Don't pass pubsub services across reloads

Ensures configuration is refreshed, releases some memory.

mod_pep: Set correct jid attr on node disco items

Tue, 07 Dec 2021 13:04:52 +0100

mod_pep: Set correct jid attr on node disco items

It was previously set to the hostname, not the users bare JID which
would be correct.

mod_pubsub,mod_pep: Advertise maximum number of items via XEP-0122

Wed, 20 Oct 2021 17:32:34 +0200

mod_pubsub,mod_pep: Advertise maximum number of items via XEP-0122

Clients would generally be using the "max" symbol instead of discovering
this, but this also gets us validation and earlier rejection of out of
bounds values.

mod_pubsub,mod_pep: Implement 'send_last_published_item' option #1436

Tue, 19 Oct 2021 18:11:50 +0200

mod_pubsub,mod_pep: Implement 'send_last_published_item' option #1436

Default left as 'never' in mod_pubsub to preserve the previous behavior.
Unclear if this is desirable, but can always be changed later.

In mod_pep this allows turning off the automatic resending of most
recent item.

mod_pep: Remove now unused util.cache import

Sun, 25 Jul 2021 16:31:15 +0200

mod_pep: Remove now unused util.cache import

mod_pep: Remove use of RLU cache when persist_items was set to false

Wed, 21 Jul 2021 23:02:25 +0200

mod_pep: Remove use of RLU cache when persist_items was set to false

This behavior came from some confusion over the meaning of
persist_items. The correct behavior is that items are only stored when
it is set to true. When set to false, the service becomes a "pure"
publish-subscribe service, where items are forgotten immediately after
broadcasting.

mod_pubsub,mod_pep: Support "max" as 'pubsub#max_items'

Wed, 09 Jun 2021 15:58:49 +0200

mod_pubsub,mod_pep: Support "max" as 'pubsub#max_items'

Fixes #1643

API change: The argument to archive_itemstore() changes type to integer

Merge 0.11->trunk

Sun, 16 May 2021 19:05:20 +0200

Merge 0.11->trunk

mod_pep: Remove obsolete node restoration code (now done by util.pubsub)

Sun, 16 May 2021 16:14:23 +0200

mod_pep: Remove obsolete node restoration code (now done by util.pubsub)

Originally added in 202b9951b037 but util.pubsub gained a better method
in 6c2c2fc4b8dd since then, which mod_pep uses since 9194431b6447 which
should have deleted this.

All these :create calls would have failed with a 'conflict' error, since
the nodes had already been created. This was never noticed because of
missing error handling.

Also note that this code did not restore node configuration.

Merge 0.11->trunk

Mon, 15 Feb 2021 22:30:28 +0100

Merge 0.11->trunk

mod_pep: Advertise base pubsub feature (fixes #1632)

Mon, 15 Feb 2021 16:29:13 +0100

mod_pep: Advertise base pubsub feature (fixes #1632)

Noticed while discussing feature discovery in Gajim
Thanks lovetox

Merge 0.11->trunk

Thu, 27 Feb 2020 20:05:47 +0100

Merge 0.11->trunk

mod_pubsub, mod_pep: Ensure correct number of children of (fixes #1496)

Thu, 27 Feb 2020 20:01:54 +0100

mod_pubsub, mod_pep: Ensure correct number of children of (fixes #1496)

Merge 0.11->trunk

Mon, 23 Dec 2019 20:57:10 +0100

Merge 0.11->trunk

mod_pep: Handle presence subscriptions in filter (fixes #1372)

Mon, 10 Jun 2019 13:57:09 +0200

mod_pep: Handle presence subscriptions in filter (fixes #1372)

Take two on 045209b41b3a

mod_pep: Only log when creating new pubsub services

Tue, 09 Jul 2019 15:12:32 +0200

mod_pep: Only log when creating new pubsub services

Once upon a time get_pep_service() would get called with random bare
JIDs and remote hostnames, which is why it was logged this way. This
seems to have been fixed, so it's not as useful anymore. It's still
useful to know when it creates a new service object.

mod_pep: Log node name instead of payload

Sun, 16 Jun 2019 22:02:53 +0200

mod_pep: Log node name instead of payload

Having the node logged is more useful and less problematic for privacy

Merge 0.11->trunk

Mon, 10 Jun 2019 13:22:22 +0200

Merge 0.11->trunk

mod_pep: Revert 045209b41b3a, caused a regression

Mon, 10 Jun 2019 12:58:00 +0200

mod_pep: Revert 045209b41b3a, caused a regression

Adding in all presence based subscriptions in the broadcaster caused
resend_last_item() to unintentionally send out more notifications than
it should have.

Merge 0.11->trunk

Thu, 30 May 2019 21:44:35 +0200

Merge 0.11->trunk

mod_pep: Handle presence based subscription outside of util.pubsub (fixes #1372)

Thu, 30 May 2019 15:16:56 +0200

mod_pep: Handle presence based subscription outside of util.pubsub (fixes #1372)

Subscriptions were updated for each incoming presence stanza from
contacts. Each subscription change triggered a configuration save, which
would filter out the presence based subscriptions and usually end up
replacing the existing data with identical data. With many subscribed
nodes this adds up to a fair bit of IO bound work that is avoided by
keeping them separate.

Merge 0.11->trunk

Fri, 22 Feb 2019 07:40:30 +0100

Merge 0.11->trunk

mod_pep: Simplify configuration for node data (fixes #1320)

Fri, 22 Feb 2019 07:35:44 +0100

mod_pep: Simplify configuration for node data (fixes #1320)

mod_pep: Set an 'id' on notifications

Sun, 23 Dec 2018 02:56:10 +0100

mod_pep: Set an 'id' on notifications

mod_pubsub got this in f2d35eee69c9

mod_pep: Add some spacing between blocks in broadcaster to improve readability

Sun, 23 Dec 2018 02:54:39 +0100

mod_pep: Add some spacing between blocks in broadcaster to improve readability

mod_pep: Move broadcaster code around to be more like in mod_pubsub

Sun, 23 Dec 2018 02:53:12 +0100

mod_pep: Move broadcaster code around to be more like in mod_pubsub

This eases comparing and contrasting these two modules.

mod_pep: Remove incorrect features advertised on the bare host

Thu, 01 Nov 2018 23:58:41 +0100

mod_pep: Remove incorrect features advertised on the bare host

pubsub: Set pubsub#title as name attribute in disco#items (fixes #1226)

Tue, 30 Oct 2018 18:20:54 +0100

pubsub: Set pubsub#title as name attribute in disco#items (fixes #1226)

mod_pep: Add automatic subscriptions on node creation (fixes #1222)

Sat, 20 Oct 2018 20:22:55 +0200

mod_pep: Add automatic subscriptions on node creation (fixes #1222)

Replaces automatic node creation on subscription, since this casues
problems when trying to keep nodes private or other specific settings.

mod_pep: Add PEP service owners username in configuration to ease identification

Sat, 20 Oct 2018 20:12:53 +0200

mod_pep: Add PEP service owners username in configuration to ease identification

mod_pep: Remove use of recipients table for signaling pending disco#items

Tue, 23 Oct 2018 22:54:15 +0200

mod_pep: Remove use of recipients table for signaling pending disco#items

It stored the caps hash as a string in the recipients table while
waiting for a disco#info response, then replaces it with the set of
nodes that had +notify.

This mixing of types is bad, so here it gets removed.

This can be improved once an IQ tracking API (#714) is added.

mod_pep: Add all pubsub service objects to item API in order to behave across reloads

Sat, 20 Oct 2018 20:23:23 +0200

mod_pep: Add all pubsub service objects to item API in order to behave across reloads

mod_pep: Simplify code

Sat, 18 Aug 2018 14:38:18 +0100

mod_pep: Simplify code

mod_pep: Remove feature for persistence already added elsewere

Sat, 18 Aug 2018 14:31:01 +0200

mod_pep: Remove feature for persistence already added elsewere

This is added in pubsub.lib

mod_pep: Remove already included access model feature

Sat, 18 Aug 2018 14:29:13 +0200

mod_pep: Remove already included access model feature

access-* is added in pubsub.lib based on node defaults

mod_pep: Respect setting for whether to include payload in notifications

Thu, 16 Aug 2018 15:35:46 +0200

mod_pep: Respect setting for whether to include payload in notifications

mod_pep: Respect settings for which kinds of notifications to send

Thu, 16 Aug 2018 15:34:58 +0200

mod_pep: Respect settings for which kinds of notifications to send

util.pubsub: Pass "retract" as the type of such broadcasts

Thu, 16 Aug 2018 14:32:21 +0200

util.pubsub: Pass "retract" as the type of such broadcasts

This moves some XEP-0060 awkwardness out of util.pubsub and into mod_pubsub

A retraction is broadcast in an container, whereas most other
kinds of broadcasts are in a container with a name matching the 'kind'
attribute.

mod_pep, util.pubsub: Rename restricted->outcast, none->member and add new 'none' affiliation to better match XEP-0060

Wed, 08 Aug 2018 23:20:07 +0100

mod_pep, util.pubsub: Rename restricted->outcast, none->member and add new 'none' affiliation to better match XEP-0060

mod_pubsub, mod_pep, util.pubsub: Move capability definitions into util.pubsub to avoid duplication

Wed, 08 Aug 2018 20:48:02 +0100

mod_pubsub, mod_pep, util.pubsub: Move capability definitions into util.pubsub to avoid duplication

mod_pep: Add comment explaining 'none' affiliation

Wed, 08 Aug 2018 20:40:44 +0100

mod_pep: Add comment explaining 'none' affiliation

mod_pep: Remove "subscriber" affiliation in favour of "none"

Wed, 08 Aug 2018 20:38:10 +0100

mod_pep: Remove "subscriber" affiliation in favour of "none"

It ended up with identical capabilities to "none", and isn't a standard
affiliation defined by XEP-0060 anyway.

mod_pep: Loosen restrictions on the "none" affiliation

Wed, 08 Aug 2018 21:03:37 +0200

mod_pep: Loosen restrictions on the "none" affiliation

This allows non-contacts access to data in nodes with the "open" access
model.

Thanks gerald

mod_pep: Change default affiliation in the "presence" access model to "restricted" for non-contacts

Wed, 08 Aug 2018 20:55:14 +0200

mod_pep: Change default affiliation in the "presence" access model to "restricted" for non-contacts

This lets us loosen the restrictions of the "none" affiliation, so that
the "open" access model allows anyone basic access.

mod_pep: Add comment about 'hash_map' table

Mon, 06 Aug 2018 23:20:47 +0200

mod_pep: Add comment about 'hash_map' table