prosody-hg: plugins/mod_http_file_share.lua history

mod_http_file_share: Support full Range requests

Fri, 13 Feb 2026 16:19:12 +0100

mod_http_file_share: Support full Range requests

This allows requesting smaller slices of a file, often done by video
players.

Merge 13.0->trunk

Fri, 13 Feb 2026 15:22:46 +0100

Merge 13.0->trunk

mod_http_file_share: Improve handling of Range requests

Fri, 13 Feb 2026 14:54:57 +0100

mod_http_file_share: Improve handling of Range requests

There were reports of clients always including the Range header, even
when not resuming a download. Since it is equivalent to a non-Range
request, better to simply send the whole file instead of an error.

Range requests with units other than bytes are also ignored now.

RFC 9110 states:
> An origin server MUST ignore a Range header field that contains a
> range unit it does not understand.

Merge 13.0->trunk

Thu, 02 Oct 2025 21:09:51 +0200

Merge 13.0->trunk

mod_http_file_share: Split long line [luacheck]

Thu, 02 Oct 2025 21:09:29 +0200

mod_http_file_share: Split long line [luacheck]

Merge 13.0->trunk

Thu, 02 Oct 2025 21:08:15 +0200

Merge 13.0->trunk

mod_http_file_share: Improve debug logging around unexpected file sizes

Thu, 02 Oct 2025 21:04:20 +0200

mod_http_file_share: Improve debug logging around unexpected file sizes

These didn't have any debug logging and it can be confusing that the
"file too large" is also used for a cut-off chunked upload.
Not sure if it is worth it to double those checks into > and < just for
this.

mod_http_file_share: Fix error when upload directory not created yet

Sat, 20 Sep 2025 23:48:04 +0200

mod_http_file_share: Fix error when upload directory not created yet

mod_http_file_share: Check for unexpected files in the upload directory

Sat, 04 Dec 2021 18:57:11 +0100

mod_http_file_share: Check for unexpected files in the upload directory

In case the metadata is lost or corrupted it can be handy to know what
files might have been left behind.

mod_http_file_share: Check that files are still there with correct size

Sat, 04 Dec 2021 18:56:51 +0100

mod_http_file_share: Check that files are still there with correct size

Failed uploads can leave behind unused slots. Files shouldn't change
size after they have been successfully uploaded, but might as well
double check it.

mod_http_file_share: Add media-src 'self' to Content-Security-Policy header

Fri, 18 Apr 2025 12:25:06 +0100

mod_http_file_share: Add media-src 'self' to Content-Security-Policy header

This allows certain media files to be loaded when navigated to directly in a
web browser.

Note that in some browsers (Chrome), the media gets transformed
internally into a HTML page with some basic styles, but these are blocked due
to our default-src policy of 'none' Although this could be unblocked with
style-src unsafe-inline, it is not our plan to fix this, because this would
have negative security implications.

The reason for our CSP is to prevent the file share service from being used to
host malicious HTML/CSS/JS. Yes, CSS can be malicious.

Our file share service is for uploading and downloading files, it is not a
substitute for website/content hosting.

mod_http_file_share: Explicitly reject all unsupported ranges

Sun, 23 Mar 2025 12:36:47 +0100

mod_http_file_share: Explicitly reject all unsupported ranges

Fail fast. Otherwise it sends the whole file.

mod_http_file_share: Fix off by one in Range response

Sun, 23 Mar 2025 12:21:19 +0100

mod_http_file_share: Fix off by one in Range response

See #1914

mod_http_file_share: Improve error reporting by using util.error more

Sun, 16 Mar 2025 15:20:45 +0100

mod_http_file_share: Improve error reporting by using util.error more

This should pass back the error message as well as the status code to
the client.

mod_http_file_share: Persist total storage usage when it increases (fixes #1891)

Sat, 15 Feb 2025 17:10:30 +0000

mod_http_file_share: Persist total storage usage when it increases (fixes #1891)

mod_http_file_share: Revert 9c62ffbdf2ae

Sat, 02 Nov 2024 23:08:28 +0100

mod_http_file_share: Revert 9c62ffbdf2ae

No, that wasn't running in a thread, but in a next tick timer.

mod_http_file_share: Fix expiry disabled check for new config API

Mon, 08 Apr 2024 16:44:11 +0200

mod_http_file_share: Fix expiry disabled check for new config API

Similar to 26c30844cac6

luacheckrc, mod_http_file_share: Update for module API change (once->on_ready)

Thu, 30 Nov 2023 10:14:17 +0000

luacheckrc, mod_http_file_share: Update for module API change (once->on_ready)

mod_http_file_share: Retrieve stored total in async-friendly way

Sat, 14 Oct 2023 22:43:39 +0200

mod_http_file_share: Retrieve stored total in async-friendly way

Does this run in a thread?

mod_http_file_share: Switch to the new authz API (BC)

Sat, 16 Sep 2023 14:23:08 +0200

mod_http_file_share: Switch to the new authz API (BC)

Behavior change: It becomes up to the authorization module whether to
allow requests. The default, mod_authz_internal, will allow users on the
*parent* host only, breaking use by some components.

Remaining question is whether to deprecate the `http_file_share_access`
setting or leave as a way to complement/bypass access control?

plugins: Handle how get_option_period returns "never"

Fri, 21 Jul 2023 17:23:00 +0200

plugins: Handle how get_option_period returns "never"

plugins: Use integer config API with interval specification where sensible

Mon, 17 Jul 2023 01:38:54 +0200

plugins: Use integer config API with interval specification where sensible

Many of these fall into a few categories:
- util.cache size, must be >= 1
- byte or item counts that logically can't be negative
- port numbers that should be in 1..0xffff

plugins: Switch to :get_option_period() for time range options

Sun, 16 Jul 2023 20:49:33 +0200

plugins: Switch to :get_option_period() for time range options

Improves readability ("1 day" vs 86400) and centralizes validation.

mod_http_file_share: Put 'expires' back, thought it was unused

Sun, 02 Jul 2023 14:31:00 +0200

mod_http_file_share: Put 'expires' back, thought it was unused

Removed in 536055476912 because it was not used anywhere else in the
file, but per the documentation it is meant to inform external upload
services of the expiry time of the upload itself.

mod_http_file_share: Set slot token TTL so util.jwt validates expiry

Wed, 28 Jun 2023 17:17:20 +0200

mod_http_file_share: Set slot token TTL so util.jwt validates expiry

Overrides the util.jwt default of 1h with the intended TTL of 10
minutes. Because util.jwt now has its own expiry checks, so the 'expiry'
field is no longer used and can thus be removed.

mod_http_file_share: use util.human.io.parse_duration

Thu, 28 Apr 2022 20:40:59 +0200

mod_http_file_share: use util.human.io.parse_duration

Updated by Zash, the original patch by Jonas had put the duration
parsing function in util.datetime but MattJ later did the same thing but
differently in f4d7fe919969

plugins: Prefix module imports with prosody namespace

Fri, 24 Mar 2023 13:15:28 +0100

plugins: Prefix module imports with prosody namespace

mod_http_file_share: Use correct variable name (thanks riau.sni)

Sun, 04 Sep 2022 10:01:57 +0100

mod_http_file_share: Use correct variable name (thanks riau.sni)

mod_http_file_share: Switch to new util.jwt API

Mon, 11 Jul 2022 13:49:47 +0100

mod_http_file_share: Switch to new util.jwt API

Some changes/improvements in this commit:

- Default token lifetime is now 3600s (from 300s)
- Tokens are only validated once per upload
- "iat"/"exp" are handled automatically by util.jwt

mod_http (and dependent modules): Make CORS opt-in by default (fixes #1731)

Mon, 28 Mar 2022 14:53:24 +0100

mod_http (and dependent modules): Make CORS opt-in by default (fixes #1731)

The same-origin policy enforced by browsers is a security measure that should
only be turned off when it is safe to do so. It is safe to do so in Prosody's
default modules, but people may load third-party modules that are unsafe.

Therefore we have flipped the default, so that modules must explicitly opt in
to having CORS headers added on their requests.

mod_http_file_share: Use alternate syntax for filename in Content-Disposition

Sat, 29 Jan 2022 16:11:38 +0100

mod_http_file_share: Use alternate syntax for filename in Content-Disposition

The Lua string.format %q doesn't behave correctly for all characters
that should be escaped in a quoted-string. And who knows what effects
higher Unicode might have here.

Applying percent-encoding of filenames seems like the safest way to deal
with filenames, as well as being easier than implementing the actual
quoted-string transform, which seems complicated and I'm not even sure
it covers every possible character.

Filenames can safely be assumed to be UTF-8 since they are passed in an
attribute in the query without any escaping.

mod_http_file_share: Always measure total disk usage for statistics!

Tue, 11 Jan 2022 04:15:29 +0100

mod_http_file_share: Always measure total disk usage for statistics!

Metrics available or not depending on configuration is weird, even tho
it might be expensive to calculate and it's only really needed when
there is a global quota.

Default quota is set to infinity, which is essentially what it was.

Reports NaN if there is an error, which should count as over the
infinite default quota.

mod_http_file_share: Fix to take retention time into account

Sat, 04 Dec 2021 16:48:39 +0100

mod_http_file_share: Fix to take retention time into account

It was lost in 6f4790b8deec when switching to mod_cron.

mod_http_file_share: Improve consistency of terminology in logging

Sat, 04 Dec 2021 15:03:26 +0100

mod_http_file_share: Improve consistency of terminology in logging

Prefer 'prune' over 'delete' since it more strongly implies removal of
excess.

mod_http_file_share: Rename variable for clarity

Sat, 04 Dec 2021 15:03:52 +0100

mod_http_file_share: Rename variable for clarity

mod_http_file_share: Fix deletion counter

Sat, 04 Dec 2021 14:28:04 +0100

mod_http_file_share: Fix deletion counter

Before aa60f4353001 each loop had its own counter, seems incrementing of
one of them was lost. But only one is needed anyhow.

mod_http_file_share: Back out 876e1b6d6ae4

Fri, 03 Dec 2021 10:43:02 +0100

mod_http_file_share: Back out 876e1b6d6ae4

mod_http_file_share: Recalculate total storage usage weekly instead of daily

Fri, 03 Dec 2021 09:08:23 +0100

mod_http_file_share: Recalculate total storage usage weekly instead of daily

Before mod_cron this job ran less frequently than the upload removal
job. Running them at the same frequency seems wasteful somehow, plus the
total should not drift away from the true value that fast.

mod_http_file_share: Keep track of total storage use across restarts

Fri, 03 Dec 2021 08:21:29 +0100

mod_http_file_share: Keep track of total storage use across restarts

The value needs to be known in order to determine if additional uploads
can be accepted.

mod_http_file_share: Fix measuring total storage use before it was known

Fri, 03 Dec 2021 08:16:18 +0100

mod_http_file_share: Fix measuring total storage use before it was known

Passing nil to the metrics system causes errors later.

mod_http_file_share: Keep global storage use accurate longer.

Tue, 30 Nov 2021 00:55:54 +0100

mod_http_file_share: Keep global storage use accurate longer.

Merging those loops removes the miscounting that would occur in case a
file could not be deleted, so no need to limit it to that case.

mod_http_file_share: Merge file expiry loops

Tue, 30 Nov 2021 00:53:22 +0100

mod_http_file_share: Merge file expiry loops

Not sure what the benefit of two separate loops was, perhaps reduced
memory usage by allowing archive query state to be garbage collected
before moving on to deleting files. Never measured so probably not so.

This simplifies a bit.

mod_http_file_share: Limit query to time since last expiry

Tue, 30 Nov 2021 00:52:07 +0100

mod_http_file_share: Limit query to time since last expiry

This is probably a bad idea, as files that could not be deleted for some
reason will not be tried again. I was just thinking of what the 'task'
argument could be used for.

mod_http_file_share: Switch to mod_cron for periodic tasks

Mon, 22 Nov 2021 14:54:32 +0100

mod_http_file_share: Switch to mod_cron for periodic tasks

mod_http_file_share: Move number coercion into util.dataforms

Mon, 25 Oct 2021 21:45:06 +0200

mod_http_file_share: Move number coercion into util.dataforms

mod_http_file_share: Silence luacheck warning

Sat, 23 Oct 2021 13:32:01 +0200

mod_http_file_share: Silence luacheck warning

mod_http_file_share: Clean up incomplete uploads

Sat, 23 Oct 2021 01:53:07 +0200

mod_http_file_share: Clean up incomplete uploads

If the request fails in the middle then the file~ could be left behind
because no code was invoked to delete it then. This gets rid of it when
the request is removed. It may still be left in case of an unclean
shutdown.

mod_http_file_share: Allow 'Authorization' header via CORS (thanks kawaii)

Wed, 20 Oct 2021 23:06:07 +0200

mod_http_file_share: Allow 'Authorization' header via CORS (thanks kawaii)

Can't find anything saying anything on whether this is needed or not.
kawaii reported that both Chrome and Firefox complained unless the
header was added to the list of allowed headers.

mod_http_file_share: return 401 instead of 403 if authentication failed

Tue, 19 Oct 2021 16:37:32 +0200

mod_http_file_share: return 401 instead of 403 if authentication failed

This is as per the HTTP standards [1]. Thankfully, the REQUIRED
www-authenticate header is already generated by the code.

[1]: https://datatracker.ietf.org/doc/html/rfc7235#section-3.1

mod_http_file_share: Fix measuring how long periodic task take

Tue, 14 Sep 2021 15:33:39 +0200

mod_http_file_share: Fix measuring how long periodic task take

mod_http_file_share: Measure current total usage

Sun, 12 Sep 2021 17:03:02 +0200

mod_http_file_share: Measure current total usage

In order to allow monitoring. Especially as there's not much in the way
of hard numbers on how much space gets used.

mod_http_file_share: Fix traceback in global quota debug logging (thanks Martin)

Sun, 12 Sep 2021 11:47:22 +0200

mod_http_file_share: Fix traceback in global quota debug logging (thanks Martin)

Error in util.human.units.format because of B(nil) when the global quota
is unset.

mod_http_file_share: Add optional global quota on total storage usage

Sun, 12 Sep 2021 01:38:33 +0200

mod_http_file_share: Add optional global quota on total storage usage

Before, maximum storage usage (assuming all users upload as much as they
could) would depend on the quota, retention period and number of users.
Since number of users can vary, this makes it hard to know how much
storage will be needed.

Adding a limit to the total overall storage use solves this, making it
simple to set it to some number based on what storage is actually
available.

Summary job run less often than the prune job since it touches the
entire archive; and started before the prune job since it's needed
before the first upload.

mod_http_file_share: Update comment about x-frame-options

Sun, 20 Jun 2021 16:30:24 +0200

mod_http_file_share: Update comment about x-frame-options

X-Frame-Options was replaced by the Content-Security-Policy
'frame-ancestors' directive, but Internet Explorer does not support that
part of CSP.

Since it's just one line it doesn't hurt to keep until some future
spring cleaning event :)

mod_http_file_share: Build list of measuring buckets for configured size limit

Tue, 08 Jun 2021 13:33:40 +0200

mod_http_file_share: Build list of measuring buckets for configured size limit

Creates buckets up to the configured size limit or 1TB, whichever is
smaller, e.g. {1K, 4K, 16K, ... 4M, 16M}

mod_http_file_share: Handle out of bounds Range request

Mon, 17 May 2021 14:14:25 +0200

mod_http_file_share: Handle out of bounds Range request

Turns out you can seek past the end of the file without getting an
error.

Also rejects empty range instead of sending the whole file.

mod_http_file_share: Support download resumption via Range requests

Sun, 16 May 2021 16:52:59 +0200

mod_http_file_share: Support download resumption via Range requests

Only a starting point is supported due to the way response:send_file()
sends everything it gets from the provided file handle but does not have
any way to specify how much to read.

This matches what Conversations appears to be doing.

mod_http_file_share: Include expiry time of the upload itself in token

Mon, 05 Apr 2021 17:21:18 +0200

mod_http_file_share: Include expiry time of the upload itself in token

Lets an external upload service know this so it can do expiry itself.
Could possibly have been calculated based on the token expiry or
issuance time, explicit > implicit.

mod_http_file_share: Include time of issuance in auth token

Mon, 05 Apr 2021 17:16:18 +0200

mod_http_file_share: Include time of issuance in auth token

In case an external upload service wants to have the original creation
time, or calculate the token expiry itself.

mod_http_file_share: Group related properties for readability

Mon, 05 Apr 2021 17:15:12 +0200

mod_http_file_share: Group related properties for readability