http://hg.omfa.de/prosody-hg/ en-us prosody-hg: plugins/mod_disco.lua history plugins/mod_disco.lua revision history Merge 0.12->trunk http://hg.omfa.de/prosody-hg/log/95d8875c90dc/plugins/mod_disco.lua Kim Alvefur <zash@zash.se> Sun, 17 Dec 2023 19:02:56 +0100 mod_disco: Advertise disco#info and #items on bare JIDs to fix #1664 http://hg.omfa.de/prosody-hg/log/d7857ef7843a/plugins/mod_disco.lua
Having to add these in *there* places seems less than ideal.

I would also think that advertising disco#info is a bit redundant, since
it is a requirement for everything in XMPP and if it was missing you
would get an error back.]]> Kim Alvefur <zash@zash.se> Sun, 17 Dec 2023 18:55:14 +0100 plugins: Prefix module imports with prosody namespace http://hg.omfa.de/prosody-hg/log/74b9e05af71e/plugins/mod_disco.lua Kim Alvefur <zash@zash.se> Fri, 24 Mar 2023 13:15:28 +0100 Switch to a new role-based authorization framework, removing is_admin() http://hg.omfa.de/prosody-hg/log/9061f9621330/plugins/mod_disco.lua
We began moving away from simple "is this user an admin?" permission checks
before 0.12, with the introduction of mod_authz_internal and the ability to
dynamically change the roles of individual users.

The approach in 0.12 still had various limitations however, and apart from
the introduction of roles other than "admin" and the ability to pull that info
from storage, not much actually changed.

This new framework shakes things up a lot, though aims to maintain the same
functionality and behaviour on the surface for a default Prosody
configuration. That is, if you don't take advantage of any of the new
features, you shouldn't notice any change.

The biggest change visible to developers is that usermanager.is_admin() (and
the auth provider is_admin() method) have been removed. Gone. Completely.

Permission checks should now be performed using a new module API method:

module:may(action_name, context)

This method accepts an action name, followed by either a JID (string) or
(preferably) a table containing 'origin'/'session' and 'stanza' fields (e.g.
the standard object passed to most events). It will return true if the action
should be permitted, or false/nil otherwise.

Modules should no longer perform permission checks based on the role name.
E.g. a lot of code previously checked if the user's role was prosody:admin
before permitting some action. Since many roles might now exist with similar
permissions, and the permissions of prosody:admin may be redefined
dynamically, it is no longer suitable to use this method for permission
checks. Use module:may().

If you start an action name with ':' (recommended) then the current module's
name will automatically be used as a prefix.

To define a new permission, use the new module API:

module:default_permission(role_name, action_name)
module:default_permissions(role_name, { action_name[, action_name...] })

This grants the specified role permission to execute the named action(s) by
default. This may be overridden via other mechanisms external to your module.

The built-in roles that developers should use are:

- prosody:user (normal user)
- prosody:admin (host admin)
- prosody:operator (global admin)

The new prosody:operator role is intended for server-wide actions (such as
shutting down Prosody).

Finally, all usage of is_admin() in modules has been fixed by this commit.
Some of these changes were trickier than others, but no change is expected to
break existing deployments.

EXCEPT: mod_auth_ldap no longer supports the ldap_admin_filter option. It's
very possible nobody is using this, but if someone is then we can later update
it to pull roles from LDAP somehow.]]> Matthew Wild <mwild1@gmail.com> Wed, 15 Jun 2022 12:15:01 +0100 spelling: non-existing mistakes (thanks timeless) http://hg.omfa.de/prosody-hg/log/50fcd3879482/plugins/mod_disco.lua Kim Alvefur <zash@zash.se> Mon, 07 Mar 2022 00:35:29 +0100 mod_disco: Optionally return info on admin accounts to non-contacts http://hg.omfa.de/prosody-hg/log/b3f040e57835/plugins/mod_disco.lua
If you already know the account, from say the server contact info, then
this confirms their admin status.]]> Kim Alvefur <zash@zash.se> Thu, 15 Apr 2021 15:39:35 +0200 mod_disco: Advertise anonymous users http://hg.omfa.de/prosody-hg/log/b7e15abde27f/plugins/mod_disco.lua
Can these even be seen?]]> Kim Alvefur <zash@zash.se> Sat, 04 Jul 2020 20:10:18 +0200 mod_disco: Advertise admin accounts as such via disco identity http://hg.omfa.de/prosody-hg/log/b4db17aeff01/plugins/mod_disco.lua Kim Alvefur <zash@zash.se> Sat, 04 Jul 2020 20:09:18 +0200 mod_disco: Send XEP-0115 caps in s2s stream features http://hg.omfa.de/prosody-hg/log/59cf555b4698/plugins/mod_disco.lua
Not currently used for anything, but allowed and could be used in the
future and might be used by other servers.]]> Kim Alvefur <zash@zash.se> Thu, 12 Aug 2021 19:34:17 +0200 mod_disco: Add some spacing to improve readability and code navigation http://hg.omfa.de/prosody-hg/log/ae2a11066001/plugins/mod_disco.lua Kim Alvefur <zash@zash.se> Tue, 10 Nov 2020 14:46:49 +0100 mod_disco: Simplify iq handling by hooking on iq-get/ instead of iq/. http://hg.omfa.de/prosody-hg/log/80dbb60d81e4/plugins/mod_disco.lua Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> Fri, 24 Aug 2018 20:34:18 +0200 mod_disco: Skip code specific to disco on user accounts (avoids invoking usermanager, fixes #1150) http://hg.omfa.de/prosody-hg/log/b0093d3b2d04/plugins/mod_disco.lua Kim Alvefur <zash@zash.se> Mon, 28 May 2018 21:30:32 +0200 mod_disco: Advertise in stream-features after auth (probably what was meant in 200f1f6306a7) (fixes #957) http://hg.omfa.de/prosody-hg/log/8c524b7c9017/plugins/mod_disco.lua Kim Alvefur <zash@zash.se> Thu, 27 Jul 2017 14:10:18 +0200 Merge 0.9->0.10 http://hg.omfa.de/prosody-hg/log/745e0a783055/plugins/mod_disco.lua Kim Alvefur <zash@zash.se> Sat, 27 May 2017 17:19:15 +0200 mod_disco: Add an account/registered identity on subscribed accounts, fixes #826. http://hg.omfa.de/prosody-hg/log/f0d847316723/plugins/mod_disco.lua Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> Sat, 27 May 2017 15:53:30 +0100 mod_disco: Rename variables to avoid name clash [luacheck] http://hg.omfa.de/prosody-hg/log/3b2cc22e9b5b/plugins/mod_disco.lua Kim Alvefur <zash@zash.se> Sat, 01 Apr 2017 22:30:37 +0200 Merge 0.9->0.10 http://hg.omfa.de/prosody-hg/log/15973ade9a11/plugins/mod_disco.lua Kim Alvefur <zash@zash.se> Fri, 24 Mar 2017 00:28:18 +0100 mod_disco: Correctly set the 'node' attr (fixes #449) http://hg.omfa.de/prosody-hg/log/57060d0cee4b/plugins/mod_disco.lua Kim Alvefur <zash@zash.se> Fri, 24 Mar 2017 00:25:49 +0100 plugins/various: Use type-specific config API http://hg.omfa.de/prosody-hg/log/01d6298de991/plugins/mod_disco.lua Kim Alvefur <zash@zash.se> Thu, 16 Mar 2017 20:46:06 +0100 mod_disco: Update to account for new intermediate session type (from 9f70d35a1602) http://hg.omfa.de/prosody-hg/log/200f1f6306a7/plugins/mod_disco.lua Kim Alvefur <zash@zash.se> Thu, 15 Dec 2016 07:03:52 +0100 Remove all trailing whitespace http://hg.omfa.de/prosody-hg/log/bd0ff8ae98a8/plugins/mod_disco.lua Florian Zeitz <florob@babelmonkeys.de> Fri, 09 Aug 2013 17:48:21 +0200 mod_disco: Check for host type == 'local' ('normal' never existed) http://hg.omfa.de/prosody-hg/log/9cef4b5c2fe3/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Tue, 06 Aug 2013 17:18:39 +0100 mod_disco: Allow ansering disco requests including nodes, and adding custom items to disco#items requests http://hg.omfa.de/prosody-hg/log/832ea1e9ac9e/plugins/mod_disco.lua Florian Zeitz <florob@babelmonkeys.de> Tue, 04 Jun 2013 23:59:59 +0200 mod_disco: Emit events for disco requests, which contain a node, on user accounts http://hg.omfa.de/prosody-hg/log/0439d1349dc1/plugins/mod_disco.lua Florian Zeitz <florob@babelmonkeys.de> Fri, 17 May 2013 18:35:50 +0200 hostmanager, mod_disco: Show optional 'name' option from the config in disco#items queries (fixes use-case in #292) (thanks diSabler, mva) http://hg.omfa.de/prosody-hg/log/c0c060e450be/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Sun, 05 Aug 2012 17:18:35 +0100 mod_disco: Allow configurable name in disco identity (defaults to 'Prosody') http://hg.omfa.de/prosody-hg/log/0f72123ff513/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Mon, 23 Jul 2012 12:25:33 +0100 core.modulemanager, mod_disco: Add support for XEP-0128: Service Discovery Extensions http://hg.omfa.de/prosody-hg/log/a2ee8ab82dd9/plugins/mod_disco.lua Kim Alvefur <zash@zash.se> Mon, 08 Aug 2011 18:23:53 +0200 mod_disco: Don't add caps hash to stream features on unauthenticated connections. http://hg.omfa.de/prosody-hg/log/d2c4856c7ed5/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Fri, 03 Dec 2010 00:37:54 +0500 mod_disco: Fixed: Service discovery features were not being removed on module unload (issue #205). http://hg.omfa.de/prosody-hg/log/98b55c3a3deb/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Sun, 28 Nov 2010 07:56:08 +0500 mod_disco: Updated to use hostmanager.get_children instead of componentmanager.get_children. http://hg.omfa.de/prosody-hg/log/c888328ae6b3/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Wed, 10 Nov 2010 20:31:28 +0500 mod_disco: Renamed the 'session' property of the account-disco-info and account-disco-items events to 'origin' for consistency. http://hg.omfa.de/prosody-hg/log/fb7fc154a56a/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Sun, 07 Nov 2010 20:53:08 +0500 mod_disco: Reflect requested 'node' attribute in the disco#info reply. http://hg.omfa.de/prosody-hg/log/a416d714a905/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Mon, 12 Jul 2010 00:14:48 +0500 mod_disco: Respond to disco#info to the correct caps hash node ("node#ver"). http://hg.omfa.de/prosody-hg/log/3b84a84f472a/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Sun, 11 Jul 2010 23:51:40 +0500 mod_disco: Cache disco#info reply and caps hash for host, return correct caps hash, and respond to disco#info to the caps hash node. http://hg.omfa.de/prosody-hg/log/99f56bed5228/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Sun, 11 Jul 2010 21:21:38 +0500 mod_disco: Support for putting the server's caps hash in stream:features to allow the client to cache disco#info for the server instead of requesting it at each login. http://hg.omfa.de/prosody-hg/log/c70c6d5bf270/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Fri, 09 Jul 2010 13:20:00 +0100 Merge 0.6->0.7 http://hg.omfa.de/prosody-hg/log/692b3c6c5bd2/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Mon, 22 Mar 2010 17:24:55 +0000 Update copyright headers for 2010 http://hg.omfa.de/prosody-hg/log/b7049746bd29/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Mon, 22 Mar 2010 17:06:15 +0000 mod_disco: Added option 'disco_items' to allow appending items to a host's disco#items result. http://hg.omfa.de/prosody-hg/log/4be6810914eb/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Sat, 23 Jan 2010 18:16:10 +0500 mod_disco: Handle and fire events for service discovery queries for bare account JIDs (thanks darkrain). http://hg.omfa.de/prosody-hg/log/29a30884aadd/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Mon, 21 Dec 2009 06:25:12 +0500 mod_disco: Rearranged some lines, and added a FIXME comment http://hg.omfa.de/prosody-hg/log/9b445d2427e2/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Tue, 18 Aug 2009 12:44:42 +0500 mod_disco: Removed reference to core.discomanager http://hg.omfa.de/prosody-hg/log/b062ee7865fc/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Tue, 18 Aug 2009 12:43:21 +0500 mod_disco: Removed legacy IQ hooks http://hg.omfa.de/prosody-hg/log/0e56819ee51b/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Tue, 18 Aug 2009 12:42:56 +0500 mod_disco: Handle disco#items queries using new APIs http://hg.omfa.de/prosody-hg/log/ceab61010f87/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Tue, 18 Aug 2009 12:39:00 +0500 mod_disco: Added identity server/im with name 'Prosody' http://hg.omfa.de/prosody-hg/log/255935c7a915/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Tue, 18 Aug 2009 12:38:28 +0500 mod_disco: Handle disco#info queries using new APIs http://hg.omfa.de/prosody-hg/log/53d16a28ee00/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Tue, 18 Aug 2009 12:37:40 +0500 Remove version number from copyright headers http://hg.omfa.de/prosody-hg/log/841d61be198f/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Fri, 10 Jul 2009 03:11:45 +0100 mod_disco: Convert from Windows line endings http://hg.omfa.de/prosody-hg/log/83b2e07e9039/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Thu, 09 Jul 2009 23:00:32 +0100 0.3->0.4 http://hg.omfa.de/prosody-hg/log/2c0b9e3c11c3/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Fri, 20 Mar 2009 20:16:25 +0000 Update copyright notices for 2009 http://hg.omfa.de/prosody-hg/log/90ce865eebd8/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Fri, 30 Jan 2009 17:59:26 +0000 0.2->0.3 http://hg.omfa.de/prosody-hg/log/5cccfb5da6cb/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Fri, 30 Jan 2009 17:40:25 +0000 GPL->MIT! http://hg.omfa.de/prosody-hg/log/b1885732e979/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Fri, 30 Jan 2009 17:22:56 +0000 0.1 -> 0.2 http://hg.omfa.de/prosody-hg/log/4ae3e81513f3/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Wed, 10 Dec 2008 15:44:03 +0000 Change modules to use the new add_feature module API method. http://hg.omfa.de/prosody-hg/log/3521e0851c9e/plugins/mod_disco.lua This also fixes the bug causing disco features being added to every disco reply for every host.]]> Waqas Hussain <waqas20@gmail.com> Thu, 04 Dec 2008 20:16:30 +0500 Insert copyright/license headers http://hg.omfa.de/prosody-hg/log/cccd610a0ef9/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Wed, 03 Dec 2008 14:39:07 +0000 Bumper commit for the new modulemanager API \o/ Updates all the modules, though some more changes may be in store. http://hg.omfa.de/prosody-hg/log/193f9dd64f17/plugins/mod_disco.lua Matthew Wild <mwild1@gmail.com> Thu, 27 Nov 2008 03:12:12 +0000 Modules now sending disco replies http://hg.omfa.de/prosody-hg/log/63be85693710/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Wed, 26 Nov 2008 08:27:09 +0500 Added mod_disco http://hg.omfa.de/prosody-hg/log/c747d6963d95/plugins/mod_disco.lua Waqas Hussain <waqas20@gmail.com> Sun, 23 Nov 2008 03:32:57 +0500