prosody-hg: plugins/mod_csi_simple.lua history

mod_csi_simple: Collect stats on why stanzas are held

Fri, 07 Nov 2025 00:29:44 +0100

mod_csi_simple: Collect stats on why stanzas are held

To mirror flush reasons.

mod_csi_simple: Consider own PEP event broadcasts as high priority

Fri, 25 Jul 2025 20:33:38 +0200

mod_csi_simple: Consider own PEP event broadcasts as high priority

This should help keep ones own clients in sync, e.g. with XEP-0490

Check for delivery errors earlier in order to avoid misinterpreting
payloads echoed back along with errors.

plugins: Use integer config API with interval specification where sensible

Mon, 17 Jul 2023 01:38:54 +0200

plugins: Use integer config API with interval specification where sensible

Many of these fall into a few categories:
- util.cache size, must be >= 1
- byte or item counts that logically can't be negative
- port numbers that should be in 1..0xffff

plugins: Switch to :get_option_period() for time range options

Sun, 16 Jul 2023 20:49:33 +0200

plugins: Switch to :get_option_period() for time range options

Improves readability ("1 day" vs 86400) and centralizes validation.

Merge 0.12->trunk

Mon, 01 May 2023 22:24:13 +0200

Merge 0.12->trunk

mod_csi_simple: Disable revert-to-inactive timer when going to active mode

Mon, 01 May 2023 15:10:32 +0200

mod_csi_simple: Disable revert-to-inactive timer when going to active mode

This timer shouldn't kick in in the middle of active mode.

mod_csi_simple: Clear delayed active mode timer on disable

Mon, 01 May 2023 14:52:38 +0200

mod_csi_simple: Clear delayed active mode timer on disable

It should not be there afterwards. Noticed that it seems to fire some
time after resumption claiming that the queue size is nil, implying
that it may hold a reference to an expired session somehow.

plugins: Prefix module imports with prosody namespace

Fri, 24 Mar 2023 13:15:28 +0100

plugins: Prefix module imports with prosody namespace

mod_csi_simple: Collect stats on number of stanzas per flush

Tue, 14 Jun 2022 03:31:30 +0200

mod_csi_simple: Collect stats on number of stanzas per flush

Because interesting, gives some idea about the efficiency.

plugins: Update for namespace bump in XEP-0353 v0.4.0

Tue, 11 Jan 2022 17:51:26 +0100

plugins: Update for namespace bump in XEP-0353 v0.4.0

mod_csi_simple: Skip initiating flush in all but inactive state

Sat, 20 Nov 2021 23:54:43 +0100

mod_csi_simple: Skip initiating flush in all but inactive state

Both in the flushing and active states the right thing to do is skip
directly to returning the data. Also in any unknown state, like if the
filter is somehow left behind on module unload.

mod_csi_simple: Early return on client activity while flushing buffer

Sat, 20 Nov 2021 22:50:51 +0100

mod_csi_simple: Early return on client activity while flushing buffer

Cuts down on log and measurement noise. We only want to do these things
here when initiating a flush.

mod_csi_simple: Allow some straggler traffic after flushing buffer

Sat, 20 Nov 2021 19:23:08 +0100

mod_csi_simple: Allow some straggler traffic after flushing buffer

Statistics from my server shows a high rate of very short buffer hold
times, most of which are the result of replies to pings or other iq
traffic, or mod_smacks acks and ack requests just after a flush was
completed.

This grace period should eliminate noise and quick flipping between
flushing and inactive mode.

mod_csi_simple: Skip flushing of empty buffer

Thu, 18 Nov 2021 01:57:21 +0100

mod_csi_simple: Skip flushing of empty buffer

Just adds noise

mod_csi_simple: Fire event when flushing due to client activity

Thu, 18 Nov 2021 00:39:10 +0100

mod_csi_simple: Fire event when flushing due to client activity

So that the same things happen as when triggered by an outgoing stanza

mod_csi_simple: Detach cleanly from sessions if unloaded while flushing

Tue, 16 Nov 2021 16:03:23 +0100

mod_csi_simple: Detach cleanly from sessions if unloaded while flushing

Since it changes the state to "flushing" while doing just that.
Attempting to remove the filters from a session that does not have them
should be a safe noop.

mod_csi_simple: Only act in inactive mode to prevent infinite recursion

Tue, 16 Nov 2021 13:53:30 +0100

mod_csi_simple: Only act in inactive mode to prevent infinite recursion

Definitely should not be firing an event that triggers like csi-flushing
from which it may make sense to send things, which leads right back here

mod_csi_simple: Unlock writes after event, to allow things to be queued

Tue, 16 Nov 2021 13:37:18 +0100

mod_csi_simple: Unlock writes after event, to allow things to be queued

E.g. mod_smacks could queue an , which would be more likely to be
included in the same write and TCP segment as the previously buffered
data, reducing syscalls and network packets needing to be sent.

mod_csi_simple: Provide custom set of timing buckets

Tue, 05 Oct 2021 15:49:47 +0200

mod_csi_simple: Provide custom set of timing buckets

The default of 0.001..100.0 did not feel suitable here. This might be
better. Longer is better and hold times less than a few seconds is
generally undesirable.

mod_csi_simple: convert to use new metric interface for flush reasons

Thu, 20 May 2021 14:00:54 +0200

mod_csi_simple: convert to use new metric interface for flush reasons

mod_csi_simple: s/algoritm/algorithm/ [codespell]

Fri, 05 Mar 2021 15:05:21 +0100

mod_csi_simple: s/algoritm/algorithm/ [codespell]

mod_csi_simple: Add command to test importance algorithm on stream of stanzas

Tue, 23 Feb 2021 19:52:57 +0100

mod_csi_simple: Add command to test importance algorithm on stream of stanzas

This won't include behavior provided by extra modules tho.

mod_csi_simple: Fire event when flushing queue

Tue, 16 Feb 2021 23:10:23 +0100

mod_csi_simple: Fire event when flushing queue

To let other plugins know and take some action, e.g. flushing other
buffers or whatnot.

mod_csi_simple: Set session state to 'flushing' while doing so

Tue, 16 Feb 2021 23:09:51 +0100

mod_csi_simple: Set session state to 'flushing' while doing so

May be useful for 3rd party modules.

mod_csi_simple,mod_carbons,mod_mam: Update comment about XEP-0353

Fri, 08 Jan 2021 17:32:06 +0100

mod_csi_simple,mod_carbons,mod_mam: Update comment about XEP-0353

It went back to Deferred

mod_csi_simple: Report whatever's not a stirng and not a stanza

Sun, 10 May 2020 23:12:33 +0200

mod_csi_simple: Report whatever's not a stirng and not a stanza

This is either dead code or actually a type error, but catching that
should be the responsibility of the session.send function. This type
check is left since everything after it assumes a stanza object.

These last few commits aren't meant to change any behavior and it did
mark things not stanzas as important, but those would have been mostly
raw strings which are now specially handled.

mod_csi_simple: Report whitespace keepalives

Sun, 10 May 2020 23:09:15 +0200

mod_csi_simple: Report whitespace keepalives

Single space character is sent by mod_c2s when a session has been
silent for some time. This should account for the vast majority of raw
strings passing through here. If this is not the case then having stats
to say otherwise will be interesting.

mod_csi_simple: Identify raw string data in logging and stats

Sun, 10 May 2020 23:06:21 +0200

mod_csi_simple: Identify raw string data in logging and stats

mod_csi_simple: Collect stats on flush reasons

Sat, 09 May 2020 17:47:03 +0200

mod_csi_simple: Collect stats on flush reasons

mod_csi_simple: Record stats of how long buffers are held

Sat, 09 May 2020 17:45:45 +0200

mod_csi_simple: Record stats of how long buffers are held

Telnet command `stats:show("buffer_hold"):histogram()` looks nice!

mod_csi_simple: Change debug message of client-triggered flush for coherence

Sat, 09 May 2020 17:38:13 +0200

mod_csi_simple: Change debug message of client-triggered flush for coherence

It now matches other the other source of flush reason logging.

mod_csi_simple: Reset queue counter to zero when enabling

Sat, 09 May 2020 17:07:43 +0200

mod_csi_simple: Reset queue counter to zero when enabling

For symmetry.

mod_csi_simple: Forget queue counter when disabling optimizations

Sat, 09 May 2020 17:05:46 +0200

mod_csi_simple: Forget queue counter when disabling optimizations

Otherwise it might not start from zero when enabled again.

mod_csi_simple: Fix flushing when client sent something

Sat, 09 May 2020 13:50:58 +0200

mod_csi_simple: Fix flushing when client sent something

Forgot to unset the flag afterwards, so it would only work once.

The flag is not even needed, it works as intended without it.

mod_csi_simple: Fix treating presence errors as presence updates

Sat, 09 May 2020 13:33:26 +0200

mod_csi_simple: Fix treating presence errors as presence updates

Autocomplete fail probably.

mod_csi_simple: Add comment highlighting that XEP-0353 is experimental

Sat, 09 May 2020 01:01:03 +0200

mod_csi_simple: Add comment highlighting that XEP-0353 is experimental

To make it easier to find implemented Experimental XEPs later. Also at
the time of this commit it has been Proposed as mentinoed in the
comment but hopefully that will be resolved soon.

mod_csi_simple: Fix unintentional order of rules from merge

Sat, 09 May 2020 01:01:01 +0200

mod_csi_simple: Fix unintentional order of rules from merge

Merge 0.11->trunk

Sat, 09 May 2020 00:48:22 +0200

Merge 0.11->trunk

mod_csi_simple: Consider XEP-0353: Jingle Message Initiation important

Fri, 08 May 2020 23:47:48 +0200

mod_csi_simple: Consider XEP-0353: Jingle Message Initiation important

Improves experience with VoIP calls initiated via JMI

Closes #1548

mod_csi_simple: Log reasons for not flushing

Thu, 07 May 2020 23:02:47 +0200

mod_csi_simple: Log reasons for not flushing

mod_csi_simple: Add short reasons to report

Thu, 07 May 2020 22:56:30 +0200

mod_csi_simple: Add short reasons to report

Should improve quality of debug logs

mod_csi_simple: Refactor to allow logging reason for buffer flush

Thu, 07 May 2020 21:55:29 +0200

mod_csi_simple: Refactor to allow logging reason for buffer flush

Same style as mod_mam and mod_carbons allows easy comparison.

BC: Log format changes

mod_csi_simple: Don't consider presence errors as important

Tue, 05 May 2020 23:08:47 +0200

mod_csi_simple: Don't consider presence errors as important

A large share of `` appears to be noise from large
public channels and failed presence probes. The later at least should
count as presence updates, which are currently considered unimportant.

See also 8cecb85e4bc4 which is partly reverted here. The intent there
was probably mostly about message (delivery) errors, which should be
considered important.

mod_csi_simple: Explicitly mention iq stanzas

Sun, 26 Apr 2020 11:40:48 +0200

mod_csi_simple: Explicitly mention iq stanzas

Should be more obvious that all iq stanzas are considered important.
Changes behavior for invalid things in the default namespace.

mod_csi_simple: Clarify what might not be stanzas here

Sun, 26 Apr 2020 11:13:25 +0200

mod_csi_simple: Clarify what might not be stanzas here

mod_csi_simple: Consider nonzas important

Sun, 26 Apr 2020 11:13:01 +0200

mod_csi_simple: Consider nonzas important

This case was previously handled by fall-trough at the end of the
function.

mod_csi_simple: Explicitly consider errors important

Sun, 26 Apr 2020 10:58:22 +0200

mod_csi_simple: Explicitly consider errors important

This was already the case for presence and iq stanzas but not messages.

mod_csi_simple: Consider MUC invites important

Sat, 18 Apr 2020 19:36:26 +0200

mod_csi_simple: Consider MUC invites important

Both mediated invites defined by XEP-0045: Multi-User Chat and direct
invites defined by XEP-0249: Direct MUC Invitations

mod_csi_simple: Allow configuring extra tags indicating importance

Sat, 18 Apr 2020 16:18:41 +0200

mod_csi_simple: Allow configuring extra tags indicating importance

mod_csi_simple: Make sure to disable optimizations before mod_smacks (thanks pep.)

Sun, 17 Nov 2019 17:59:56 +0100

mod_csi_simple: Make sure to disable optimizations before mod_smacks (thanks pep.)

mod_csi_simple: Always remove session filters when disabling CSI

Sat, 05 Oct 2019 16:55:58 +0200

mod_csi_simple: Always remove session filters when disabling CSI

Only guard the actual pausing of outgoing data on the method existing.
This prevents the filters from lingering in case something happened to
the connection. Removing already removed filters should be a safe noop.

mod_csi_simple: Try not to flush buffer while already flushing it

Sat, 05 Oct 2019 16:50:41 +0200

mod_csi_simple: Try not to flush buffer while already flushing it

Reduces log noice

mod_csi_simple: Remove duplicated check for connection

Sat, 28 Sep 2019 22:59:29 +0200

mod_csi_simple: Remove duplicated check for connection

mod_csi_simple: Disable optimizations on disconnect (fixes #1358)

Sun, 26 May 2019 15:04:16 +0200

mod_csi_simple: Disable optimizations on disconnect (fixes #1358)

The connection becomes invalid here, regardless of 3rd party modules
that might keep the session alive.

mod_csi_simple: Include queue size in debug messages

Mon, 25 Mar 2019 15:20:28 +0100

mod_csi_simple: Include queue size in debug messages

mod_csi_simple: Fix type in function name

Mon, 25 Mar 2019 10:32:39 +0000

mod_csi_simple: Fix type in function name

mod_csi_simple: Improve debug logs by mentioing why the buffer gets flushed

Sun, 24 Mar 2019 22:01:36 +0100

mod_csi_simple: Improve debug logs by mentioing why the buffer gets flushed

mod_csi_simple: Add some debug logging

Sun, 24 Mar 2019 20:53:49 +0100

mod_csi_simple: Add some debug logging

mod_csi_simple: Disable optimizations on unload and re-enable on load

Sun, 24 Mar 2019 20:43:15 +0100

mod_csi_simple: Disable optimizations on unload and re-enable on load

mod_csi_simple: Separate out functions to enable/disable optimizations

Sun, 24 Mar 2019 20:41:25 +0100

mod_csi_simple: Separate out functions to enable/disable optimizations

This allows reusing this logic outside the events. Letting the functions
be module globals makes it easier to access from eg the telnet console.