prosody-hg: plugins/mod_c2s.lua history

Merge 13.0->trunk

Wed, 29 Apr 2026 17:12:59 +0100

Merge 13.0->trunk

Merge 0.12->13.0

Wed, 29 Apr 2026 17:12:11 +0100

Merge 0.12->13.0

mod_c2s: Remove timers immediately on disconnection

Thu, 16 Apr 2026 18:59:56 +0100

mod_c2s: Remove timers immediately on disconnection

mod_c2s, mod_s2s: Add configurable limit for stanza max child elements

Thu, 16 Apr 2026 18:53:34 +0100

mod_c2s, mod_s2s: Add configurable limit for stanza max child elements

mod_c2s,mod_s2s: Introduce separate pre-authentication stanza size limit

Tue, 07 Apr 2026 20:35:41 +0200

mod_c2s,mod_s2s: Introduce separate pre-authentication stanza size limit

This should prevent unauthenticated resource use via the XML parser.

Merge 13.0->trunk

Tue, 21 Apr 2026 16:23:34 +0100

Merge 13.0->trunk

mod_c2s, mod_smacks: Refactor session/connection cleanup

Tue, 21 Apr 2026 16:22:43 +0100

mod_c2s, mod_smacks: Refactor session/connection cleanup

mod_smacks was preventing mod_c2s cleanup by directly modifying the mod_c2s
sessions table. It did this to avoid mod_c2s trying to destroy the session
when the connection was closed.

The code that does IP counting in mod_limits was experiencing counter drift,
likely because of mod_smacks disassociating the session from the connection
before the c2s-closed event is fired.

This change has mod_c2s skip the session cleanup if it sees the 'hibernating'
property is set on the session. This is a less invasive way of performing the
same thing. Importantly, c2s-closed still gets to run and fire with the
original session object.

It might be desirable to remove the 'hibernating' check here and switch to a
more generic event-driven design (where mod_smacks can inhibit cleanup by
adding an event handler). This change was deemed too large for a minor
release, but may be made in trunk.

Merge 13.0->trunk

Fri, 17 Apr 2026 14:35:32 +0100

Merge 13.0->trunk

mod_c2s: Remove timers immediately on disconnection

Thu, 16 Apr 2026 18:59:56 +0100

mod_c2s: Remove timers immediately on disconnection

mod_c2s, mod_s2s: Add configurable limit for stanza max child elements

Thu, 16 Apr 2026 18:53:34 +0100

mod_c2s, mod_s2s: Add configurable limit for stanza max child elements

mod_c2s: Fire a c2s-connected event

Thu, 16 Apr 2026 16:11:44 +0100

mod_c2s: Fire a c2s-connected event

We already fire events for most of the other connection callbacks, this one
was missing, but is useful.

mod_c2s,mod_s2s: Introduce separate pre-authentication stanza size limit

Tue, 07 Apr 2026 20:35:41 +0200

mod_c2s,mod_s2s: Introduce separate pre-authentication stanza size limit

This should prevent unauthenticated resource use via the XML parser.

mod_c2s: Fix typo

Wed, 01 Oct 2025 17:39:20 +0200

mod_c2s: Fix typo

mod_c2s: Improve user-facing error reporting when unable to proceed

Wed, 01 Oct 2025 17:25:15 +0200

mod_c2s: Improve user-facing error reporting when unable to proceed

"No stream features to proceed with" isn't easy to understand for users,
with "stream features" being jargon and the whole thing being about the
technical aspect of XMPP stream negotiation.

The log messages aimed at admins are hopefully easier understood.

These cases occur when either connection security (i.e. mod_tls or
certificate settings) or authentication (mod_saslauth, auth provider) is
misconfigured or not loaded.

mod_c2s: Avoid calling module:context() with unknown hosts

Tue, 05 Aug 2025 13:11:28 +0100

mod_c2s: Avoid calling module:context() with unknown hosts

Related to e6c6f58dfda1, a0faff6ba853 and #605

mod_c2s: Code formatting change

Tue, 11 Mar 2025 18:37:16 +0000

mod_c2s: Code formatting change

Although we do sometimes use single-line if blocks, I'm expanding this one to
make it easier to compare with the duplicated (but modified) code in
mod_websocket that we plan to de-duplicate one day.

mod_c2s: Add debug log when disconnecting all user sessions

Thu, 06 Feb 2025 12:40:11 +0000

mod_c2s: Add debug log when disconnecting all user sessions

mod_c2s, mod_s2s: Support for queuing callbacks to run in session thread

Thu, 21 Nov 2024 17:02:07 +0000

mod_c2s, mod_s2s: Support for queuing callbacks to run in session thread

This allows certain session-specific code that needs to run in the async
context, but is itself triggered outside of that context (e.g. timers), to
be queued.

An example of this is the session destruction code of mod_smacks, when the
hibernation timeout is reached.

mod_c2s,mod_s2s: Advertise idle-seconds per XEP-0478

Sat, 03 Aug 2024 16:28:59 +0200

mod_c2s,mod_s2s: Advertise idle-seconds per XEP-0478

This is the time after liveness checks are performed via the respective
read-timeout event, which by default involves sending a space character
but could be overridden e.g. as is done by mod_smacks.

Only advertised, unsure what we would do with it.

mod_c2s: Fix error on role change on Components (thanks Menel)

Sat, 17 Feb 2024 19:07:57 +0100

mod_c2s: Fix error on role change on Components (thanks Menel)

mod_c2s: Make c2s_timeout timer reachable to allow access from other modules

Sun, 03 Dec 2023 15:46:33 +0100

mod_c2s: Make c2s_timeout timer reachable to allow access from other modules

E.g. the timeout could be extended under certain conditions.

mod_saslauth, mod_c2s: Disable tls-server-end-point channel binding by default

Thu, 26 Oct 2023 15:14:39 +0100

mod_saslauth, mod_c2s: Disable tls-server-end-point channel binding by default

This channel binding method is now enabled when a hash is manually set in the
config, or it attempts to discover the hash automatically if the value is the
special string "auto".

A related change to mod_c2s prevents complicated certificate lookups in the
client connection hot path - this work now happens only when this channel
binding method is used. I'm not aware of anything else that uses ssl_cfg (vs
ssl_ctx).

Rationale for disabling by default:

- Minor performance impact in automatic cert detection
- This method is weak against a leaked/stolen private key (other methods such
as 'tls-exporter' would not be compromised in such a case)

Rationale for keeping the implementation:

- For some deployments, this may be the only method available (e.g. due to
TLS offloading in another process/server).

mod_c2s: Add session.ssl_cfg/ssl_ctx for direct TLS connections

Wed, 07 Sep 2022 11:29:00 +0100

mod_c2s: Add session.ssl_cfg/ssl_ctx for direct TLS connections

plugins: Handle how get_option_period returns "never"

Fri, 21 Jul 2023 17:23:00 +0200

plugins: Handle how get_option_period returns "never"

plugins: Use integer config API with interval specification where sensible

Mon, 17 Jul 2023 01:38:54 +0200

plugins: Use integer config API with interval specification where sensible

Many of these fall into a few categories:
- util.cache size, must be >= 1
- byte or item counts that logically can't be negative
- port numbers that should be in 1..0xffff

plugins: Switch to :get_option_period() for time range options

Sun, 16 Jul 2023 20:49:33 +0200

plugins: Switch to :get_option_period() for time range options

Improves readability ("1 day" vs 86400) and centralizes validation.

core.sessionmanager: Delay closing a replaced connection after replacement

Sun, 07 May 2023 12:27:55 +0200

core.sessionmanager: Delay closing a replaced connection after replacement

Closing the session invokes ondisconnect and session close logic,
including mod_smacks hibernation and the timer that destroys the session
after a timeout.

By closing the connection after it has been detached from the sessions
table it will no longer invoke the ondetach handler, which should
prevent the above problem.

mod_c2s,mod_s2s: Fix tag name for SLA (thanks mjk)

Wed, 03 May 2023 18:02:11 +0200

mod_c2s,mod_s2s: Fix tag name for SLA (thanks mjk)

The (still not published) XEP-xxxx: Stream Limits Advertisement uses the
element to advertise the maximum octet size of top level
stream elements. "size" was probably a leftover of an even earlier
version of the (Proto)XEP.

plugins: Prefix module imports with prosody namespace

Fri, 24 Mar 2023 13:15:28 +0100

plugins: Prefix module imports with prosody namespace

mod_c2s: Disconnect accounts when they are disabled

Thu, 23 Feb 2023 16:28:57 +0100

mod_c2s: Disconnect accounts when they are disabled

We decided that at the first stage, accounts that are disabled should
simply be prevented from authenticating, thus they should also be
prevented from having connected sessions. Since this is aimed to be a
moderation action for cases of abuse, they shouldn't be allowed to
continue being connected.

mod_c2s,mod_s2s: Adapt to XEP-xxxx: Stream Limits Advertisement

Thu, 20 Oct 2022 14:04:56 +0200

mod_c2s,mod_s2s: Adapt to XEP-xxxx: Stream Limits Advertisement

Thanks MattJ

mod_c2s: Advertise stanza size limit to clients

Tue, 16 Mar 2021 18:17:05 +0100

mod_c2s: Advertise stanza size limit to clients

Should help clients avoid sending stanzas that will get their stream
killed. Custom namespace while ironing out the protocol.

My spoon is too big!

mod_c2s: Include stream attributes in stream-features event

Fri, 14 Oct 2022 11:21:16 +0100

mod_c2s: Include stream attributes in stream-features event

We need this to access 'from' in SASL2/FAST.

mod_smacks: Long overdue cleanup of resumption code, fixes some old TODOs

Fri, 26 Aug 2022 17:04:15 +0100

mod_smacks: Long overdue cleanup of resumption code, fixes some old TODOs

mod_authz_internal, and more: New iteration of role API

Wed, 17 Aug 2022 16:38:53 +0100

mod_authz_internal, and more: New iteration of role API

These changes to the API (hopefully the last) introduce a cleaner separation
between the user's primary (default) role, and their secondary (optional)
roles.

To keep the code sane and reduce complexity, a data migration is needed for
people using stored roles in 0.12. This can be performed with

prosodyctl mod_authz_internal migrate

net: isolate LuaSec-specifics

Wed, 27 Apr 2022 17:44:14 +0200

net: isolate LuaSec-specifics

For this, various accessor functions are now provided directly on the
sockets, which reach down into the LuaSec implementation to obtain the
information.

While this may seem of little gain at first, it hides the implementation
detail of the LuaSec+LuaSocket combination that the actual socket and
the TLS layer are separate objects.

The net gain here is that an alternative implementation does not have to
emulate that specific implementation detail and "only" has to expose
LuaSec-compatible data structures on the new functions.

mod_c2s,mod_s2s: Fix error on shutdown (Thanks Martin)

Tue, 22 Feb 2022 14:17:27 +0100

mod_c2s,mod_s2s: Fix error on shutdown (Thanks Martin)

Since there are two calls to done() that can happen, if the timing is
right (or wrong) both can happen, which previously triggered an error.

mod_c2s,mod_s2s: Wrap callback to improve tracebacks

Tue, 22 Feb 2022 12:35:31 +0100

mod_c2s,mod_s2s: Wrap callback to improve tracebacks

Should make traces point here instead of timer dispatch, making
debugging easier

mod_c2s: Ignore unused event payload [luacheck]

Fri, 18 Feb 2022 23:13:01 +0100

mod_c2s: Ignore unused event payload [luacheck]

mod_c2s,mod_s2s: Wait for sessions to close before proceeding with shutdown steps

Thu, 17 Feb 2022 03:49:47 +0100

mod_c2s,mod_s2s: Wait for sessions to close before proceeding with shutdown steps

Ensures unavailable presence and other outgoing stanzas are sent.

Waiting for c2s sessions to close first before proceeding to disable and
close s2s ensures that unavailable presence can go out, even if it
requires dialback to complete first.

mod_c2s: Close ports in a separate, earlier event from closing sessions

Fri, 18 Feb 2022 14:25:22 +0100

mod_c2s: Close ports in a separate, earlier event from closing sessions

Lets other things step in and do things while c2s ports are closed, e.g.
mod_smacks, or other modules with port handlers that forward to c2s.

mod_c2s,mod_s2s: Disable and close port listeners before closing sessions

Fri, 11 Feb 2022 21:36:53 +0100

mod_c2s,mod_s2s: Disable and close port listeners before closing sessions

This ensures no new clients can start connecting during shutdown

mod_c2s: Fire pre-closing event regardless of connected state

Sat, 18 Dec 2021 13:43:57 +0100

mod_c2s: Fire pre-closing event regardless of connected state

With mod_smacks, a session can outlive the connection, so whether the
event is fired should not hinge on whether the session is connected or
not.

Helps mod_smacks remove some state.

mod_c2s: Add event just before closing as session

Wed, 01 Dec 2021 15:06:48 +0100

mod_c2s: Add event just before closing as session

To allow modules to do things just before the session is closed. The
'(pre-)resource-unbind' events are fired after the stream is closed,
leaving no way to send something.

mod_c2s: Disconnect user sessions on a role change event

Fri, 12 Nov 2021 13:26:05 +0000

mod_c2s: Disconnect user sessions on a role change event

The overlapping logic for deletion and password changed has been merged into
a single function.

mod_c2s,etc: Identify stanza object with appropriate function

Sun, 24 Oct 2021 15:17:01 +0200

mod_c2s,etc: Identify stanza object with appropriate function

Better than duck typing, in case anyone ever passes a non-stanza table
with a 'name' field.

mod_c2s: Rename Direct TLS listener 'c2s_direct_tls' for clarity

Thu, 09 Sep 2021 22:14:43 +0200

mod_c2s: Rename Direct TLS listener 'c2s_direct_tls' for clarity

And to follow existing naming practices better than 'legacy_ssl' did.

mod_c2s,mod_s2s: Indicate stanza size violation with condition from XEP-0205 (thanks mjk)

Mon, 06 Sep 2021 23:21:25 +0200

mod_c2s,mod_s2s: Indicate stanza size violation with condition from XEP-0205 (thanks mjk)

Merge 0.11->trunk

Thu, 26 Aug 2021 16:42:42 +0100

Merge 0.11->trunk

mod_c2s: Indicate stream secure state in error text when no stream features to offer

Tue, 06 Jul 2021 08:18:28 +0100

mod_c2s: Indicate stream secure state in error text when no stream features to offer

mod_c2s,mod_s2s: Fire event just before writes

Mon, 16 Aug 2021 12:45:14 +0200

mod_c2s,mod_s2s: Fire event just before writes

Could allow e.g. a XEP-0198 implementation to efficiently send ack
requests at optimal times without using timers or nextTick.

mod_c2s: Guard against LuaSec not returning TLS info (thanks Martin)

Mon, 21 Jun 2021 13:36:05 +0200

mod_c2s: Guard against LuaSec not returning TLS info (thanks Martin)

The :info() method has been observed to return nothing ... sometimes.
Unclear what causes it. Perhaps the TLS connection was shut down or
hasn't fully settled?

The LuaSec code has code paths that return nothing or nil, error, so it
is best to guard against it.

mod_c2s: Log the same messages for Direct TLS as with starttls

Sun, 20 Jun 2021 18:15:59 +0200

mod_c2s: Log the same messages for Direct TLS as with starttls

^C^V

mod_c2s: Update a comment to reflect Direct TLS

Sun, 20 Jun 2021 18:14:18 +0200

mod_c2s: Update a comment to reflect Direct TLS

mod_c2s: Add a Direct TLS listener

Sun, 20 Jun 2021 16:51:08 +0200

mod_c2s: Add a Direct TLS listener

This only differs from 'legacy_ssl' in name, at least on the server
side. For clients this is the one that uses SRV records.

mod_c2s,mod_s2s: Collect stats on TLS versions and ciphers

Wed, 16 Jun 2021 00:00:17 +0200

mod_c2s,mod_s2s: Collect stats on TLS versions and ciphers

Merge 0.11->trunk

Thu, 13 May 2021 11:17:13 +0100

Merge 0.11->trunk

mod_c2s, mod_s2s, mod_component, mod_bosh, mod_websockets: Set default stanza size limits

Fri, 07 May 2021 17:03:49 +0100

mod_c2s, mod_s2s, mod_component, mod_bosh, mod_websockets: Set default stanza size limits

c2s/bosh/ws streams will default to 256KB, s2s and components to 512KB.

These values are aligned with ejabberd's default settings, which should reduce
issues related to inconsistent size limits between servers on the XMPP network.

The previous default (10MB) is excessive for any production server, and allows
significant memory usage by even unauthenticated sessions.

mod_c2s: Port to new OpenMetrics API

Sun, 18 Apr 2021 12:34:17 +0200

mod_c2s: Port to new OpenMetrics API

mod_c2s: Fix traceback if session was destroyed while opening stream (thanks Ge0rG)

Wed, 14 Apr 2021 16:02:47 +0200

mod_c2s: Fix traceback if session was destroyed while opening stream (thanks Ge0rG)

Could happen with the 'opportunistic_writes' setting, since then the
stream opening is written directly to the socket, which can in turn
trigger session destruction if the socket somehow got closed just after
the other sent their stream header.

Error happens later when it tries to `hosts[session.host == nil].events`