http://hg.omfa.de/prosody-hg/ en-us plugins/mod_bookmarks.lua revision history http://hg.omfa.de/prosody-hg/log/84ee435f284e/plugins/mod_bookmarks.lua Matthew Wild <mwild1@gmail.com> Fri, 08 Nov 2024 10:31:25 +0000 http://hg.omfa.de/prosody-hg/log/d6545c533ce2/plugins/mod_bookmarks.lua
Previously the error messages said that it failed to "publish" to PEP, but
sometimes a sync involves removing items, which can be confusing.

The log was also the same for both legacy PEP and private XML bookmarks.
Having different log messages makes it easier to debug the cause and location
of any sync errors.]]> Matthew Wild <mwild1@gmail.com> Fri, 08 Nov 2024 10:28:29 +0000 http://hg.omfa.de/prosody-hg/log/1a915c2e0fa4/plugins/mod_bookmarks.lua
It appears that when:

1) The user has no bookmarks 2 node in PEP
2) The client publishes an empty bookmark set to a legacy bookmarks location
3) mod_bookmarks will attempt to purge items from the non-existent node and
log an error about the failure (item-not-found).

This new code will suppress an item-not-found error from the purge operation
in the empty-bookmarks case, and adds a log message for any other error (this
is helpful because the existing log message confusingly says it was an error
*publishing* to the node, which isn't always accurate).]]> Matthew Wild <mwild1@gmail.com> Fri, 08 Nov 2024 10:24:42 +0000 http://hg.omfa.de/prosody-hg/log/74b9e05af71e/plugins/mod_bookmarks.lua Kim Alvefur <zash@zash.se> Fri, 24 Mar 2023 13:15:28 +0100 http://hg.omfa.de/prosody-hg/log/1832b6c9c6ed/plugins/mod_bookmarks.lua
This is happens if the account is new and doesn't have any bookmarks
yet, which is not a problem.

Rarely seen since most clients currently use the older version of
XEP-0084 stored in XEP-0049 rather than in PEP, but at least one
(Converse.js )does.

One scenario in which this would show up often is with Converse.js as a
guest chat using anonymous authentication, where all "accounts" would
always be new and not have any bookmarks. This scenario probably does
not need to have mod_bookmarks at all, but if enabled globally it would
likely become loaded onto the VirtualHost unless explicitly disabled.]]> Kim Alvefur <zash@zash.se> Tue, 26 Jul 2022 23:44:33 +0200 http://hg.omfa.de/prosody-hg/log/57792ed670e7/plugins/mod_bookmarks.lua Kim Alvefur <zash@zash.se> Fri, 04 Feb 2022 16:39:35 +0100 http://hg.omfa.de/prosody-hg/log/0aa99a6dfb3e/plugins/mod_bookmarks.lua
Found by accidentally publishing {urn:xmpp:bookmarks:0}conference
instead of :1 due to testing this earlier for the blocking.

By the principle of garbage in, garbage out, just generate a bookmark
from the item id / JID and carry on with a warning.]]> Kim Alvefur <zash@zash.se> Tue, 11 Jan 2022 00:06:48 +0100 http://hg.omfa.de/prosody-hg/log/024cc878f472/plugins/mod_bookmarks.lua
Having both the :0 and :1 nodes would be especially awkward, since there
is no upgrade path for this case. In theory, these should be rare since
no clients should have been doing XEP-0402 unless mod_bookmarks(2) was
enabled. This was guesstimated to be rare with most clients doing
XEP-0048 with Private XML.]]> Kim Alvefur <zash@zash.se> Mon, 10 Jan 2022 22:15:55 +0100 http://hg.omfa.de/prosody-hg/log/2515033c2a74/plugins/mod_bookmarks.lua
Should save some cycles and not log the debug message on every login.]]> Kim Alvefur <zash@zash.se> Mon, 10 Jan 2022 00:13:17 +0100 http://hg.omfa.de/prosody-hg/log/b2923a3b4e02/plugins/mod_bookmarks.lua Kim Alvefur <zash@zash.se> Mon, 10 Jan 2022 00:11:36 +0100 http://hg.omfa.de/prosody-hg/log/750abaf99baf/plugins/mod_bookmarks.lua
For compatibility with clients relying on the notifications]]> Kim Alvefur <zash@zash.se> Sun, 09 Jan 2022 18:42:22 +0100 http://hg.omfa.de/prosody-hg/log/17cffaa78f48/plugins/mod_bookmarks.lua
Might be nice to reduce amount of things happening on connect once
all users has upgraded]]> Kim Alvefur <zash@zash.se> Sat, 08 Jan 2022 00:32:33 +0100 http://hg.omfa.de/prosody-hg/log/ae5988739990/plugins/mod_bookmarks.lua
See 1dc00ca6ee9d]]> Kim Alvefur <zash@zash.se> Sat, 08 Jan 2022 00:30:26 +0100 http://hg.omfa.de/prosody-hg/log/0939675955f1/plugins/mod_bookmarks.lua Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> Thu, 06 Jan 2022 00:59:40 +0100 http://hg.omfa.de/prosody-hg/log/bbbf0dd90b6d/plugins/mod_bookmarks.lua Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> Tue, 04 Jan 2022 23:16:02 +0100 http://hg.omfa.de/prosody-hg/log/b63bb2c4b6d9/plugins/mod_bookmarks.lua Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> Tue, 04 Jan 2022 23:04:14 +0100