http://hg.omfa.de/prosody-hg/ en-us prosody-hg: plugins/mod_admin_shell.lua history plugins/mod_admin_shell.lua revision history Merge 13.0->trunk http://hg.omfa.de/prosody-hg/log/4f4c346e4f39/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Tue, 19 May 2026 19:27:43 +0100 mod_admin_shell: Don't echo password back to the client http://hg.omfa.de/prosody-hg/log/2a050069f37b/plugins/mod_admin_shell.lua
Unintentional debugging introduced in 0e9e3efa381f]]> Matthew Wild <mwild1@gmail.com> Tue, 19 May 2026 19:24:53 +0100 Merge 13.0->trunk http://hg.omfa.de/prosody-hg/log/c1469296190d/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Fri, 17 Apr 2026 14:35:32 +0100 mod_admin_shell: Show help listing when specifying only a section name http://hg.omfa.de/prosody-hg/log/d666e7cd8609/plugins/mod_admin_shell.lua
This is significantly better than showing 'table:0x.....'.]]> Matthew Wild <mwild1@gmail.com> Thu, 16 Apr 2026 18:16:05 +0100 Merge 13.0->trunk http://hg.omfa.de/prosody-hg/log/7008869fcce2/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Thu, 02 Apr 2026 20:54:46 +0100 mod_admin_shell: Fail user creation/modification if new password fails saslprep http://hg.omfa.de/prosody-hg/log/0e9e3efa381f/plugins/mod_admin_shell.lua
This saves us from setting an invalid password and preventing the new account
from authenticating.]]> Matthew Wild <mwild1@gmail.com> Thu, 02 Apr 2026 20:53:04 +0100 Merge 13.0->trunk http://hg.omfa.de/prosody-hg/log/44a8c8d4146a/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Tue, 31 Mar 2026 12:25:20 +0100 mod_admin_shell: Improve per-host command cleanup http://hg.omfa.de/prosody-hg/log/b9688ac25255/plugins/mod_admin_shell.lua
In some cases, host command handlers were not being cleaned up after the
source module was unloaded, for example. This is because mod_admin_shell saw
that the handler being removed did not match the installed handler. But this
is expected for the new per-host commands, because the installed handler is a
wrapper function which routes between the hosts.

The wrapper function itself also held a reference via upvalue to the first
command object which added it, just so it could read the argument names and
such. This could cause command objects, and anything referenced by the
handler, to stay around in memory longer than expected, even after a module
has been unloaded or a host deactivated.

The new logic breaks out the handler function to eliminate any unexpected
upvalues. It improves the cleanup logic when a command is removed. Finally,
it also cleans up commands when mod_admin_shell itself is unloaded.]]> Matthew Wild <mwild1@gmail.com> Fri, 27 Mar 2026 12:43:10 +0000 Merge 13.0->trunk http://hg.omfa.de/prosody-hg/log/f20bb1c53652/plugins/mod_admin_shell.lua Kim Alvefur <zash@zash.se> Sat, 21 Feb 2026 17:08:11 +0100 mod_admin_shell: Make cert index search path relative to config file http://hg.omfa.de/prosody-hg/log/2aeb5dcb36bf/plugins/mod_admin_shell.lua
Otherwise it defaults to something relative to the working directory,
wherever that is? Data directory maybe?]]> Kim Alvefur <zash@zash.se> Sat, 21 Feb 2026 17:05:48 +0100 mod_admin_shell: Include timestamps with logs in debug:ping() http://hg.omfa.de/prosody-hg/log/0dd917830523/plugins/mod_admin_shell.lua
Makes it easier to see get a feel for if it pauses on something and how
long things like DNS lookups and connection attempts take.]]> Kim Alvefur <zash@zash.se> Tue, 06 Jan 2026 19:14:47 +0100 Merge 13.0->trunk http://hg.omfa.de/prosody-hg/log/071779f7645c/plugins/mod_admin_shell.lua Kim Alvefur <zash@zash.se> Fri, 05 Dec 2025 17:53:52 +0100 mod_admin_shell: Ensure JIDs are normalized in xmpp:ping() http://hg.omfa.de/prosody-hg/log/5ad86978ae78/plugins/mod_admin_shell.lua Kim Alvefur <zash@zash.se> Fri, 05 Dec 2025 17:53:10 +0100 mod_admin_shell: Also relax JID requirements in debug:ping() http://hg.omfa.de/prosody-hg/log/d539016e6b21/plugins/mod_admin_shell.lua Kim Alvefur <zash@zash.se> Fri, 05 Dec 2025 17:51:21 +0100 Merge 13.0->trunk http://hg.omfa.de/prosody-hg/log/015c8c75f8cf/plugins/mod_admin_shell.lua Kim Alvefur <zash@zash.se> Fri, 05 Dec 2025 17:29:53 +0100 mod_admin_shell: Allow pinging any JID with xmpp:ping() http://hg.omfa.de/prosody-hg/log/8d90a83603d6/plugins/mod_admin_shell.lua
Feature requested by MattJ.

Argument that users don't expect s2s-only pings.]]> Kim Alvefur <zash@zash.se> Mon, 01 Dec 2025 16:35:11 +0100 mod_admin_shell: Add config:dump() command to display the in-memory configuration http://hg.omfa.de/prosody-hg/log/d520cee2bbdb/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Tue, 07 Oct 2025 12:15:19 +0100 mod_admin_shell: Add debug:ping() which prints debug logs until pong http://hg.omfa.de/prosody-hg/log/a2d4c71f5066/plugins/mod_admin_shell.lua
Essentially a verbose version of xmpp:ping(), but more useful for
debugging s2s issues without having to watch (and have enabled) debug
logs at the same time and try to pick out where the start and end are.]]> Kim Alvefur <zash@zash.se> Sun, 05 Oct 2025 11:08:27 +0200 prosodyctl shell: Output TSV when output is not a TTY http://hg.omfa.de/prosody-hg/log/b1e7d3f571b1/plugins/mod_admin_shell.lua
This is meant to make it easier to use in scripts.

CSV would have been nice but requires escaping of fields containing ",",
but this implementation simply ignores this and assumes fields will not
contain tabs.]]> Kim Alvefur <zash@zash.se> Sun, 31 Aug 2025 00:47:25 +0200 mod_admin_shell: Skip adding margin for tables in non-repl use http://hg.omfa.de/prosody-hg/log/88f5ea4c28ce/plugins/mod_admin_shell.lua
Since it is there to account for the '| ' prefix added by the shell in
interactive mode it is not needed when in non-interactive mode.]]> Kim Alvefur <zash@zash.se> Sun, 31 Aug 2025 00:41:59 +0200 mod_admin_shell: Fix matching logic in s2s:close (Thanks Menel) http://hg.omfa.de/prosody-hg/log/f44f2a8a8c37/plugins/mod_admin_shell.lua
It was matching 'from' on the wrong field and the boolean logic was
wrong.]]> Kim Alvefur <zash@zash.se> Mon, 28 Apr 2025 19:41:19 +0200 mod_admin_shell: Add role:list() and role:show() commands http://hg.omfa.de/prosody-hg/log/a071b20ccc0f/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Fri, 04 Apr 2025 16:50:25 +0100 mod_admin_shell: Visual tweaks to the output of debug:cert_index() http://hg.omfa.de/prosody-hg/log/e78e79f1b5f5/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Thu, 03 Apr 2025 19:58:57 +0100 mod_admin_shell: Add debug:cert_index() command http://hg.omfa.de/prosody-hg/log/3ee95eb17045/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Thu, 03 Apr 2025 16:54:02 +0100 mod_admin_shell, prosodyctl shell: Report command failure when no password entered (fixes #1907) http://hg.omfa.de/prosody-hg/log/c8e534b4f2e2/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Mon, 31 Mar 2025 17:30:50 +0100 prosodyctl shell: More reliable detection of REPL/interactive mode (fixes #1895) http://hg.omfa.de/prosody-hg/log/a28349b8a387/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Thu, 13 Mar 2025 11:37:11 +0000 mod_admin_shell: Remove outdated help text (fixes #1898) http://hg.omfa.de/prosody-hg/log/5cc4a3e0335c/plugins/mod_admin_shell.lua
The ! commands have been broken for some time, and we're not going to
implement them right now. If we want fancier editing, we can now do that on
the client side (with readline and stuff).

Also removes mention of telnet!]]> Matthew Wild <mwild1@gmail.com> Thu, 13 Mar 2025 11:35:39 +0000 mod_admin_shell: Improve help listing in non-REPL mode http://hg.omfa.de/prosody-hg/log/46e7cc4de5e6/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Mon, 17 Feb 2025 19:10:48 +0000 mod_admin_shell: Fix simple command execution (e.g. help) http://hg.omfa.de/prosody-hg/log/42367f7e6e94/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Mon, 17 Feb 2025 19:10:26 +0000 mod_admin_shell: Set flag on session when in REPL mode http://hg.omfa.de/prosody-hg/log/5e8a707f1dbf/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Mon, 17 Feb 2025 19:09:11 +0000 mod_admin_shell: Improved error handling for shell-invoked commands http://hg.omfa.de/prosody-hg/log/c133635d0bc6/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Mon, 17 Feb 2025 18:25:52 +0000 mod_admin_shell, util.prosodyctl.shell: Process command-line args on server-side, with argparse support http://hg.omfa.de/prosody-hg/log/1465b1e305df/plugins/mod_admin_shell.lua
This allow a shell-command to provide a 'flags' field, which will automatically
cause the parameters to be fed through argparse.

The rationale is to make it easier for more complex commands to be invoked
from the command line (`prosodyctl shell foo bar ...`). Until now they were
limited to accepting a list of strings, and any complex argument processing
was non-standard and awkward to implement.]]> Matthew Wild <mwild1@gmail.com> Mon, 17 Feb 2025 17:02:35 +0000 mod_admin_shell: Remove duplicated line http://hg.omfa.de/prosody-hg/log/a00d0e2dc33a/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Thu, 13 Feb 2025 17:05:36 +0000 mod_admin_shell: Rename user:setrole to user:set_roles http://hg.omfa.de/prosody-hg/log/b9fce1651699/plugins/mod_admin_shell.lua
This is more readable and accessible, and it will only be harder to change
after release.]]> Matthew Wild <mwild1@gmail.com> Thu, 13 Feb 2025 16:20:42 +0000 mod_admin_shell: Hide secondary role commands, focus on primary roles http://hg.omfa.de/prosody-hg/log/026a75a443de/plugins/mod_admin_shell.lua
Secondary roles are an advanced feature without any strong use cases
currently. Having multiple ways to manage roles is confusing.

Now the 'user:role' command will just show the primary role if that is all
there is, but will list secondary roles too if there are any (which in 99.9%
of cases there won't be).]]> Matthew Wild <mwild1@gmail.com> Thu, 13 Feb 2025 16:18:59 +0000 mod_admin_shell: Support for hiding certain commands from default help listing http://hg.omfa.de/prosody-hg/log/4c1f26b4883b/plugins/mod_admin_shell.lua
Useful for e.g. deprecated commands.]]> Matthew Wild <mwild1@gmail.com> Thu, 13 Feb 2025 16:16:19 +0000 mod_admin_shell: Fix result handling of user addrole/delrole commands http://hg.omfa.de/prosody-hg/log/8f43b954bdac/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Thu, 13 Feb 2025 15:54:39 +0000 mod_admin_shell: Fix column alignment in 'help roles' http://hg.omfa.de/prosody-hg/log/d980c3e03637/plugins/mod_admin_shell.lua Kim Alvefur <zash@zash.se> Sun, 02 Feb 2025 14:12:52 +0100 mod_admin_shell: Fix help forgetting arguments http://hg.omfa.de/prosody-hg/log/c749a751b4a5/plugins/mod_admin_shell.lua
The array:pluck() method mutates the args, replacing the table items
with the resulting strings. On later runs I assume it tries to index the
string, which returns nil, emptying the array.]]> Kim Alvefur <zash@zash.se> Sun, 02 Feb 2025 13:33:17 +0100 mod_admin_shell: Remove log statement intended for development only http://hg.omfa.de/prosody-hg/log/ff13dd315e68/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Thu, 16 Jan 2025 11:35:19 +0000 mod_admin_shell: Remove redundant 'mod_' prefix from debug message http://hg.omfa.de/prosody-hg/log/74a8006ee7f6/plugins/mod_admin_shell.lua Kim Alvefur <zash@zash.se> Wed, 08 Jan 2025 08:41:15 +0100 mod_admin_shell: Fix reporting origin module for commands http://hg.omfa.de/prosody-hg/log/6e5124f72e9a/plugins/mod_admin_shell.lua
The field `_provided_by` comes from module:provides(), but these items
comes from moduel:add_item(), which include the originating module as a
'source' field of the event. However, this is absent when items are
retrieved at a later time than the initial event.]]> Kim Alvefur <zash@zash.se> Wed, 08 Jan 2025 08:11:02 +0100 mod_admin_shell: user:password(): Support prompting for password if none given http://hg.omfa.de/prosody-hg/log/2cd43975a15c/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Tue, 07 Jan 2025 19:25:12 +0000 mod_admin_shell: user:create(): Reject promise with error message on failure http://hg.omfa.de/prosody-hg/log/62aca6adcfd3/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Tue, 07 Jan 2025 19:24:05 +0000 mod_admin_shell: Mark event as handled when requested input is submitted http://hg.omfa.de/prosody-hg/log/85e8cc6870ae/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Tue, 07 Jan 2025 19:23:23 +0000 mod_admin_shell: user:create(): request password via prompt if none given http://hg.omfa.de/prosody-hg/log/abbdcef552fb/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Tue, 07 Jan 2025 18:17:57 +0000 mod_admin_shell: Add session method to request (password) input from shell client http://hg.omfa.de/prosody-hg/log/f57872788424/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Tue, 07 Jan 2025 18:17:30 +0000 mod_admin_shell: Don't pause async thread while waiting for promise result http://hg.omfa.de/prosody-hg/log/382d1a92006f/plugins/mod_admin_shell.lua
This allows us to continue sending/receiving on the session, for example if
the promise will be resolved by other data that the client is going to send.

Specifically, this allows the repl-request-input to work without a deadlock.

It does open the door to interleaved commands/results, which may not be a good
thing overall, but can be restricted separately if necessary (e.g. a flag on
the session).]]> Matthew Wild <mwild1@gmail.com> Tue, 07 Jan 2025 18:15:50 +0000 mod_admin_shell: stats:show(): Friendlier error message when statistics disabled http://hg.omfa.de/prosody-hg/log/67c9fc643873/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Sat, 28 Dec 2024 18:35:24 +0000 mod_admin_shell: Report when a module is already loaded http://hg.omfa.de/prosody-hg/log/f77c247258cc/plugins/mod_admin_shell.lua
Hopefully less confusing than "Module loaded onto 0 hosts"]]> Kim Alvefur <zash@zash.se> Fri, 15 Nov 2024 15:52:37 +0100 mod_admin_shell: Refactor end of module:load http://hg.omfa.de/prosody-hg/log/d8f7a8a26965/plugins/mod_admin_shell.lua
Meant to improve clarity and make improving easier]]> Kim Alvefur <zash@zash.se> Fri, 15 Nov 2024 15:48:07 +0100 mod_admin_shell: Reject attempt to add or remove roles for unrelated hosts http://hg.omfa.de/prosody-hg/log/67288253d9a2/plugins/mod_admin_shell.lua
The three-argument version seems to be a left-over from 0.12]]> Kim Alvefur <zash@zash.se> Fri, 01 Nov 2024 13:10:45 +0100 mod_admin_shell: Allow assigning roles to arbitrary JIDs when supported http://hg.omfa.de/prosody-hg/log/cc67109ce502/plugins/mod_admin_shell.lua
mod_authz_internal does not support this]]> Kim Alvefur <zash@zash.se> Fri, 01 Nov 2024 13:07:25 +0100 mod_admin_shell: Prevent traceback due to type error http://hg.omfa.de/prosody-hg/log/4bf889e94831/plugins/mod_admin_shell.lua
Here too]]> Kim Alvefur <zash@zash.se> Mon, 26 Aug 2024 22:26:59 +0200 Merge 0.12->trunk http://hg.omfa.de/prosody-hg/log/ae65f199f408/plugins/mod_admin_shell.lua Kim Alvefur <zash@zash.se> Sat, 27 Apr 2024 15:59:46 +0200 mod_admin_shell: Allow matching on host or bare JID in c2s:show http://hg.omfa.de/prosody-hg/log/b2b090181270/plugins/mod_admin_shell.lua
Only supporting exact match on full JID isn't helpful if you want to
list sessions per host or user.

Backport of 430333198e4c

Fixes #1857]]> Kim Alvefur <zash@zash.se> Fri, 31 Mar 2023 22:01:27 +0200 mod_admin_shell: Add connection created time http://hg.omfa.de/prosody-hg/log/9eb081616842/plugins/mod_admin_shell.lua
This adds an output format option to show the time that the connection was created.

Ref #1852]]> aidan@jmad.org Wed, 03 Apr 2024 21:56:03 -0700 mod_admin_shell: Fix linter issues http://hg.omfa.de/prosody-hg/log/83f3076965f6/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Wed, 29 Nov 2023 17:49:20 +0000 mod_admin_shell: Remove verbose logging http://hg.omfa.de/prosody-hg/log/b1f5a5531564/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Wed, 29 Nov 2023 17:33:56 +0000 mod_admin_shell: Remove timer:info() (it's been debug:timers() for some time) http://hg.omfa.de/prosody-hg/log/e8429d2faea4/plugins/mod_admin_shell.lua Matthew Wild <mwild1@gmail.com> Wed, 29 Nov 2023 17:22:18 +0000