http://hg.omfa.de/prosody-hg/ en-us prosody-hg: plugins/adhoc/adhoc.lib.lua history plugins/adhoc/adhoc.lib.lua revision history mod_adhoc: Remove "mod_" prefix from permission action name http://hg.omfa.de/prosody-hg/log/3174308d127e/plugins/adhoc/adhoc.lib.lua
Other places doesn't have "mod_" there, why should it here?]]> Kim Alvefur <zash@zash.se> Sun, 02 Apr 2023 21:58:53 +0200 plugins: Prefix module imports with prosody namespace http://hg.omfa.de/prosody-hg/log/74b9e05af71e/plugins/adhoc/adhoc.lib.lua Kim Alvefur <zash@zash.se> Fri, 24 Mar 2023 13:15:28 +0100 Switch to a new role-based authorization framework, removing is_admin() http://hg.omfa.de/prosody-hg/log/9061f9621330/plugins/adhoc/adhoc.lib.lua
We began moving away from simple "is this user an admin?" permission checks
before 0.12, with the introduction of mod_authz_internal and the ability to
dynamically change the roles of individual users.

The approach in 0.12 still had various limitations however, and apart from
the introduction of roles other than "admin" and the ability to pull that info
from storage, not much actually changed.

This new framework shakes things up a lot, though aims to maintain the same
functionality and behaviour on the surface for a default Prosody
configuration. That is, if you don't take advantage of any of the new
features, you shouldn't notice any change.

The biggest change visible to developers is that usermanager.is_admin() (and
the auth provider is_admin() method) have been removed. Gone. Completely.

Permission checks should now be performed using a new module API method:

module:may(action_name, context)

This method accepts an action name, followed by either a JID (string) or
(preferably) a table containing 'origin'/'session' and 'stanza' fields (e.g.
the standard object passed to most events). It will return true if the action
should be permitted, or false/nil otherwise.

Modules should no longer perform permission checks based on the role name.
E.g. a lot of code previously checked if the user's role was prosody:admin
before permitting some action. Since many roles might now exist with similar
permissions, and the permissions of prosody:admin may be redefined
dynamically, it is no longer suitable to use this method for permission
checks. Use module:may().

If you start an action name with ':' (recommended) then the current module's
name will automatically be used as a prefix.

To define a new permission, use the new module API:

module:default_permission(role_name, action_name)
module:default_permissions(role_name, { action_name[, action_name...] })

This grants the specified role permission to execute the named action(s) by
default. This may be overridden via other mechanisms external to your module.

The built-in roles that developers should use are:

- prosody:user (normal user)
- prosody:admin (host admin)
- prosody:operator (global admin)

The new prosody:operator role is intended for server-wide actions (such as
shutting down Prosody).

Finally, all usage of is_admin() in modules has been fixed by this commit.
Some of these changes were trickier than others, but no change is expected to
break existing deployments.

EXCEPT: mod_auth_ldap no longer supports the ldap_admin_filter option. It's
very possible nobody is using this, but if someone is then we can later update
it to pull roles from LDAP somehow.]]> Matthew Wild <mwild1@gmail.com> Wed, 15 Jun 2022 12:15:01 +0100 adhoc: Include stanza and origin in adhoc event data http://hg.omfa.de/prosody-hg/log/16a49f04d507/plugins/adhoc/adhoc.lib.lua
This allows easier access to these, which could be useful for all sorts
of reasons]]> Kim Alvefur <zash@zash.se> Mon, 06 Mar 2017 15:19:35 +0100 adhoc.lib: Tweak to allow using util.error objects http://hg.omfa.de/prosody-hg/log/6b541d3c4c1b/plugins/adhoc/adhoc.lib.lua
Since util.stanza supports util.error objects via duck-typing and adhoc
errors look enough like util.error objects, they should able to pass as
such. This will allow converting adhoc commands to use util.error.]]> Kim Alvefur <zash@zash.se> Sun, 31 Jan 2021 21:11:55 +0100 mod_adhoc: Improve permission setting (fix #1482) BC http://hg.omfa.de/prosody-hg/log/421b2f8369fd/plugins/adhoc/adhoc.lib.lua
Rename 'user' permission mode to 'any' for clarity, too easily mistaken
for what the 'local_user' setting does.

It is also removed as a default and made a required argument.]]> Kim Alvefur <zash@zash.se> Fri, 20 Dec 2019 22:47:34 +0100 adhoc.lib: Rename other variable to avoid name clash [luacheck] http://hg.omfa.de/prosody-hg/log/d88dc6827675/plugins/adhoc/adhoc.lib.lua Kim Alvefur <zash@zash.se> Tue, 12 Dec 2017 17:51:12 +0100 Backed out changeset 84c117cdd048, broke things http://hg.omfa.de/prosody-hg/log/a6f58305411e/plugins/adhoc/adhoc.lib.lua Kim Alvefur <zash@zash.se> Tue, 12 Dec 2017 17:49:30 +0100 mod_adhoc/adhoc.lib: Rename variable to avoid name clash [luacheck] http://hg.omfa.de/prosody-hg/log/84c117cdd048/plugins/adhoc/adhoc.lib.lua Kim Alvefur <zash@zash.se> Tue, 05 Dec 2017 12:32:25 +0100 mod_adhoc/adhoc.lib: instantiate table with all fields http://hg.omfa.de/prosody-hg/log/2b91da49285a/plugins/adhoc/adhoc.lib.lua Kim Alvefur <zash@zash.se> Mon, 06 Mar 2017 15:09:22 +0100 mod_lastactivity, mod_legacyauth, mod_presence, mod_saslauth, mod_tls: Use the newer stanza:get_child APIs and optimize away some table lookups http://hg.omfa.de/prosody-hg/log/76699a0ae4c4/plugins/adhoc/adhoc.lib.lua Kim Alvefur <zash@zash.se> Fri, 04 Jul 2014 22:52:34 +0200 adhoc.lib: Don't build error reply from reply stanza http://hg.omfa.de/prosody-hg/log/ebc074918173/plugins/adhoc/adhoc.lib.lua Kim Alvefur <zash@zash.se> Wed, 24 Jul 2013 21:49:36 +0200 mod_adhoc: Add support for specifying a default action http://hg.omfa.de/prosody-hg/log/4d939d2b1574/plugins/adhoc/adhoc.lib.lua Florian Zeitz <florob@babelmonkeys.de> Thu, 02 Aug 2012 21:28:14 +0200 Hopefully inert commit to clean up logging across a number of modules, removing all cases of concatenation when building log messages http://hg.omfa.de/prosody-hg/log/5243b74a4cbb/plugins/adhoc/adhoc.lib.lua Matthew Wild <mwild1@gmail.com> Mon, 23 Jul 2012 17:32:33 +0100 adhoc.lib: Make some globals local http://hg.omfa.de/prosody-hg/log/6f689c155186/plugins/adhoc/adhoc.lib.lua Kim Alvefur <zash@zash.se> Wed, 18 Jul 2012 21:18:17 +0200 adhoc.lib: Default actions to 'complete' (replacement for rev 52b6901cabb0) http://hg.omfa.de/prosody-hg/log/b66e73793cb7/plugins/adhoc/adhoc.lib.lua Kim Alvefur <zash@zash.se> Fri, 11 May 2012 21:41:47 +0100 Backed out changeset 52b6901cabb0 (to be replaced) http://hg.omfa.de/prosody-hg/log/33458e1d84c8/plugins/adhoc/adhoc.lib.lua Matthew Wild <mwild1@gmail.com> Fri, 11 May 2012 21:35:02 +0100 mod_adhoc: Always allow at least the "complete" action http://hg.omfa.de/prosody-hg/log/52b6901cabb0/plugins/adhoc/adhoc.lib.lua Florian Zeitz <florob@babelmonkeys.de> Fri, 13 Apr 2012 00:39:00 +0200 Monster whitespace commit (beware the whitespace monster). http://hg.omfa.de/prosody-hg/log/bc139431830b/plugins/adhoc/adhoc.lib.lua Waqas Hussain <waqas20@gmail.com> Sat, 16 Oct 2010 23:00:42 +0500 mod_adhoc: Fix passing data to util.dataforms http://hg.omfa.de/prosody-hg/log/66910810a9f7/plugins/adhoc/adhoc.lib.lua Florian Zeitz <florob@babelmonkeys.de> Wed, 01 Sep 2010 22:44:30 +0200 mod_adhoc: Add capability to pass data to forms http://hg.omfa.de/prosody-hg/log/c9294e190bb6/plugins/adhoc/adhoc.lib.lua Florian Zeitz <florob@babelmonkeys.de> Sat, 10 Jul 2010 01:17:07 +0200 mod_adhoc/adhoc.lib: Add copyright header http://hg.omfa.de/prosody-hg/log/a5c3a82d677e/plugins/adhoc/adhoc.lib.lua Matthew Wild <mwild1@gmail.com> Fri, 11 Jun 2010 12:18:27 +0100 mod_adhoc/adhoc.lib: Handle errors according to XEP http://hg.omfa.de/prosody-hg/log/0abb73c43bc8/plugins/adhoc/adhoc.lib.lua Matthew Wild <mwild1@gmail.com> Fri, 11 Jun 2010 12:17:57 +0100 mod_adhoc: Imported from prosody-modules, thanks Florob! http://hg.omfa.de/prosody-hg/log/b3772f9bc359/plugins/adhoc/adhoc.lib.lua Matthew Wild <mwild1@gmail.com> Wed, 09 Jun 2010 21:27:43 +0100