prosody-hg: net/server_select.lua history

Use util.time.now() consistently instead of socket.gettime()

Fri, 30 Jan 2026 14:08:53 +0100

Use util.time.now() consistently instead of socket.gettime()

various: Do not mutate loop variables as they are treated as const in Lua 5.5

Fri, 23 Feb 2024 18:44:13 +0100

various: Do not mutate loop variables as they are treated as const in Lua 5.5

Loop variables are treated as in Lua 5.5 and can't be modified
without declaring another local.

Ref https://github.com/lua/lua/commit/b2f7b3b79f3117885b265575f6c5dbf934757797

net: Prefix module imports with prosody namespace

Fri, 17 Mar 2023 16:23:12 +0100

net: Prefix module imports with prosody namespace

net.server: Fix multiple return values

Fri, 03 Jun 2022 17:51:42 +0200

net.server: Fix multiple return values

return foo and foo() crops multiple return values to a single one, so
any second return values etc were last, mostly error details.

Introduced in 7e9ebdc75ce4

net.server_select: Restore dependency on LuaSec to soft for tests

Wed, 27 Apr 2022 21:45:36 +0200

net.server_select: Restore dependency on LuaSec to soft for tests

server_select is used in e.g. storagemanager tests, and some of the CI
runners are lacking LuaSec, which resulted in failures.

net: refactor sslconfig to not depend on LuaSec

Sat, 02 Apr 2022 11:15:33 +0200

net: refactor sslconfig to not depend on LuaSec

This now requires that the network backend exposes a tls_builder
function, which essentially wraps the former util.sslconfig.new()
function, passing a factory to create the eventual SSL context.

That allows a net.server backend to pick whatever it likes as SSL
context factory, as long as it understands the config table passed by
the SSL config builder. Heck, a backend could even mock and replace the
entire SSL config builder API.

net: isolate LuaSec-specifics

Wed, 27 Apr 2022 17:44:14 +0200

net: isolate LuaSec-specifics

For this, various accessor functions are now provided directly on the
sockets, which reach down into the LuaSec implementation to obtain the
information.

While this may seem of little gain at first, it hides the implementation
detail of the LuaSec+LuaSocket combination that the actual socket and
the TLS layer are separate objects.

The net gain here is that an alternative implementation does not have to
emulate that specific implementation detail and "only" has to expose
LuaSec-compatible data structures on the new functions.

net.server: Add a predrain callaback just before writes

Mon, 16 Aug 2021 12:34:52 +0200

net.server: Add a predrain callaback just before writes

Allows sneaking in things in the write buffer just before it's sent to
the network stack. For example ack requests, compression flushes or
other things that make sense to send after stanzas or other things.
This ensures any additional trailing data sent is included in the same
write, and possibly the same TCP packet. Other methods used such as
timers or nextTick might not have the same effect as it depends on
scheduling.

Merge 0.11->trunk

Tue, 15 Sep 2020 09:09:06 +0100

Merge 0.11->trunk

net.server: Backport client parts of SNI support from trunk (#409)

Mon, 17 Aug 2020 23:01:14 +0200

net.server: Backport client parts of SNI support from trunk (#409)

Partial backports of the following commits from trunk:

6c804b6b2ca2 net.http: Pass server name along for SNI (fixes #1408)
75d2874502c3 net.server_select: SNI support (#409)
9a905888b96c net.server_event: Add SNI support (#409)
adc0672b700e net.server_epoll: Add support for SNI (#409)
d4390c427a66 net.server: Handle server name (SNI) as extra argument

net.server_select: Fix traceback (thanks eta)

Sun, 23 Aug 2020 22:19:29 +0200

net.server_select: Fix traceback (thanks eta)

The `socket` here is unreferenced on disconnect. Calling :resume_writes
after that causes an error when `addsocket()` tries to use it as a table
index.

net.server_select: Pass conn/handler to readbuffer/sendbuffer

Mon, 01 Jun 2020 13:41:41 +0100

net.server_select: Pass conn/handler to readbuffer/sendbuffer

The internal implementations don't use it, but this causes onreadable
and onwritable of watchfd to receive the conn as they do in other
backends.

net.server_select: Ensure onconnect is always called before onincoming

Mon, 01 Jun 2020 13:38:47 +0100

net.server_select: Ensure onconnect is always called before onincoming

This changes the code to call onconnect when the first data is sucessfully
read or written, instead of simply when the socket first becomes writable.

A writable socket can mean a connection error, and if the client already
sent some data it may get passed to onincoming before processing writable
sockets. This fixes the issue.

net.server_select: Remove prefix added to TLS handshaker errors

Sun, 01 Dec 2019 01:21:58 +0100

net.server_select: Remove prefix added to TLS handshaker errors

For consistency. None of the other implementations do this.

net.server: Handle server name (SNI) as extra argument

Sun, 01 Sep 2019 01:58:38 +0200

net.server: Handle server name (SNI) as extra argument

Code added in 75d2874502c3, 9a905888b96c and adc0672b700e uses this field.

See #409 and #1408

net.server: Accept and save an 'extra' field for client connections

Sun, 01 Sep 2019 01:55:55 +0200

net.server: Accept and save an 'extra' field for client connections

This lets code attach some extra data to be attached to client
connections.

Fix various spelling mistakes [codespell]

Fri, 03 May 2019 20:54:24 +0200

Fix various spelling mistakes [codespell]

net.server_select: Fix write pause/resume functions

Sun, 24 Mar 2019 20:12:22 +0100

net.server_select: Fix write pause/resume functions

Nothing would happen if the write buffer was empty.

Also simplified the code because it took too long to understand what
`if _sendlistlen ~= tmp then` did.

net.server: Only add alternate SNI contexts if at least one is provided

Mon, 11 Mar 2019 13:00:51 +0100

net.server: Only add alternate SNI contexts if at least one is provided

Fixes use of when a client sends SNI, which would send no certificate otherwise.

net.server_select: SNI support (#409)

Sun, 10 Mar 2019 19:32:33 +0100

net.server_select: SNI support (#409)

net.server: New API for creating server listeners

Thu, 13 Sep 2018 21:16:37 +0200

net.server: New API for creating server listeners

server.listen(interface, port, listeners, options);

Merge 0.11->trunk

Sun, 18 Nov 2018 01:30:20 +0100

Merge 0.11->trunk

net.server_select: Fix IP validation to use correct variable (thanks quest)

Sat, 17 Nov 2018 16:26:40 +0100

net.server_select: Fix IP validation to use correct variable (thanks quest)

Copy-paste mistake most likely. Not caught because server_select is ignored by luacheck.

net.server: Add an API for holding writes of outgoing data

Thu, 25 Oct 2018 15:12:59 +0200

net.server: Add an API for holding writes of outgoing data

net.server_select: Still allow buffering outgoing data on write-locked connections

Sun, 28 Oct 2018 17:11:18 +0100

net.server_select: Still allow buffering outgoing data on write-locked connections

net.server_select: Replace use of deprecated :lock_read in server.link

Sun, 28 Oct 2018 17:08:50 +0100

net.server_select: Replace use of deprecated :lock_read in server.link

net.server_select: Deprecate :lock method

Sun, 28 Oct 2018 16:55:21 +0100

net.server_select: Deprecate :lock method

Exists only in server_select and I found nothing using it

server_select: Fix :lock method

Sun, 28 Oct 2018 16:54:08 +0100

server_select: Fix :lock method

This always unlocks reading.

I don't believe this is used anywhere. server_event does not implement this.

net.server_select: Move code from :lock_read into :pause and :resume

Sun, 28 Oct 2018 16:53:10 +0100

net.server_select: Move code from :lock_read into :pause and :resume

net.server_select: Deprecate connection:lock_read() method

Sun, 28 Oct 2018 16:49:28 +0100

net.server_select: Deprecate connection:lock_read() method

net.server: Swich method for connecting sockets with remotes

Fri, 12 Oct 2018 17:36:34 +0200

net.server: Swich method for connecting sockets with remotes

LuaSocket TCP sockets have have both :connect and :setpeername, which
are the exact same function, however UDP sockets only have :setpeername.
Switching to :setpeername allows most of this code to be generic wrt
TCP/UDP.

net.server: Remove socket constructor fallback

Fri, 12 Oct 2018 16:24:49 +0200

net.server: Remove socket constructor fallback

Should no longer be needed

net.server: Require IP address as argument to addclient (no DNS names)

Thu, 11 Oct 2018 15:48:30 +0200

net.server: Require IP address as argument to addclient (no DNS names)

The net.connect API should be used to resolve DNS names first

net.connect: Fix passing request table to new listener

Wed, 26 Sep 2018 17:36:53 +0200

net.connect: Fix passing request table to new listener

This could be a return value from ondetach

net.server: Call a 'onattach' callback when replacing listeners

Wed, 26 Sep 2018 14:25:59 +0200

net.server: Call a 'onattach' callback when replacing listeners

net.server: Set default read timeout to 14 minutes (fixes #971)

Fri, 06 Jul 2018 19:02:19 +0200

net.server: Set default read timeout to 14 minutes (fixes #971)

net.server: Add watchfd, a simple API for watching file descriptors

Wed, 09 May 2018 16:15:40 +0200

net.server: Add watchfd, a simple API for watching file descriptors

net.server_select: Allow setquitting("once") to allow resuming the loop later

Tue, 10 Apr 2018 20:40:07 +0100

net.server_select: Allow setquitting("once") to allow resuming the loop later

Fix spelling throughout the codebase [codespell]

Sun, 04 Feb 2018 01:51:25 +0100

Fix spelling throughout the codebase [codespell]

net.server_select: Better detection of errors for outgoing connections

Fri, 23 Feb 2018 15:30:00 +0000

net.server_select: Better detection of errors for outgoing connections

On connection failure, a socket is marked readable and writable. So
to detect initial connection failures (connection refused, etc.) we
now watch for sockets becoming readable during initial connection,
and also read from readable sockets before writing to writable
sockets.

This should fix 'onconnect' being called for outgoing connections
that actually failed.

Merge 0.10->trunk

Sat, 26 Nov 2016 20:11:03 +0100

Merge 0.10->trunk

Merge 0.9->0.10

Thu, 24 Nov 2016 14:18:25 +0100

Merge 0.9->0.10

net.server_select: Prevent writes after a handler is closed (fixes #783 I hope)

Tue, 22 Nov 2016 15:28:24 +0100

net.server_select: Prevent writes after a handler is closed (fixes #783 I hope)

Merge 0.10 -> trunk

Thu, 28 Jul 2016 09:39:50 +0100

Merge 0.10 -> trunk

net.server_select: remove unused import [luacheck]

Thu, 28 Jul 2016 16:14:39 +0800

net.server_select: remove unused import [luacheck]

Merge 0.10->trunk

Thu, 14 Jul 2016 13:41:02 +0200

Merge 0.10->trunk

net.server_select: remove unused one-letter loop variable [luacheck]

Thu, 14 Jul 2016 18:49:38 +0800

net.server_select: remove unused one-letter loop variable [luacheck]

Merge 0.10->trunk

Fri, 08 Jul 2016 22:01:10 +0200

Merge 0.10->trunk

net.server_select: remove unused one-letter loop variables [luacheck]

Sat, 09 Jul 2016 00:37:34 +0800

net.server_select: remove unused one-letter loop variables [luacheck]

Merge 0.10->trunk

Tue, 29 Mar 2016 15:38:14 +0200

Merge 0.10->trunk

net.server_select: Remove do-nothing os_difftime calls [backported from trunk]

Mon, 19 Jan 2015 14:01:11 -0500

net.server_select: Remove do-nothing os_difftime calls [backported from trunk]

Merge 0.10->trunk

Fri, 22 Jan 2016 15:03:02 +0100

Merge 0.10->trunk

Merge 0.9->0.10

Fri, 22 Jan 2016 14:49:05 +0100

Merge 0.9->0.10

server_select: Add logging of when servers are paused and resumed

Fri, 22 Jan 2016 02:00:43 +0100

server_select: Add logging of when servers are paused and resumed

server_select: Pause and mark server as full if accepting a client fails (fixes #597)

Fri, 22 Jan 2016 02:00:27 +0100

server_select: Pause and mark server as full if accepting a client fails (fixes #597)

server_select: Retry accepting clients from full servers after 10s (matches libevent behaviour)

Fri, 22 Jan 2016 01:59:25 +0100

server_select: Retry accepting clients from full servers after 10s (matches libevent behaviour)

server_select: Keep track of which server listeners are full

Fri, 22 Jan 2016 01:58:39 +0100

server_select: Keep track of which server listeners are full

Merge 0.10->trunk

Sun, 10 Jan 2016 03:57:17 +0100

Merge 0.10->trunk

net.server_select: Add 'server' method to client connections (present in server_event)

Sat, 09 Jan 2016 23:54:19 +0100

net.server_select: Add 'server' method to client connections (present in server_event)

Merge 0.10->trunk

Mon, 04 Jan 2016 09:09:15 +0000

Merge 0.10->trunk