prosody-hg: core/sessionmanager.lua history

Use util.time.now() consistently instead of socket.gettime()

Fri, 30 Jan 2026 14:08:53 +0100

Use util.time.now() consistently instead of socket.gettime()

core.sessionmanager: Delay closing a replaced connection after replacement

Sun, 07 May 2023 12:27:55 +0200

core.sessionmanager: Delay closing a replaced connection after replacement

Closing the session invokes ondisconnect and session close logic,
including mod_smacks hibernation and the timer that destroys the session
after a timeout.

By closing the connection after it has been detached from the sessions
table it will no longer invoke the ondetach handler, which should
prevent the above problem.

sessionmanager: Preserve 'since' property of original session after resumption

Wed, 29 Mar 2023 13:01:53 +0100

sessionmanager: Preserve 'since' property of original session after resumption

core: Prefix module imports with prosody namespace

Fri, 17 Mar 2023 16:23:07 +0100

core: Prefix module imports with prosody namespace

Merge 0.12->trunk

Thu, 09 Feb 2023 22:34:05 +0000

Merge 0.12->trunk

sessionmanager: Improve logging around session destruction

Thu, 09 Feb 2023 15:09:03 +0000

sessionmanager: Improve logging around session destruction

core.sessionmanager: Mark session as destroyed to prevent reentry

Thu, 19 Jan 2023 21:40:09 +0100

core.sessionmanager: Mark session as destroyed to prevent reentry

If it reaches this point, then the session will be most definitely be
destroyed, so try to prevent destroy_session() from being called again.

core.sessionmanager: Skip log when (not) destroying destroyed sessions

Thu, 19 Jan 2023 21:38:14 +0100

core.sessionmanager: Skip log when (not) destroying destroyed sessions

On regular disconnects, is sent, then
sessionmanager.destroy_session() is called, then
sessionmanager.destroy_session() is called again when the TCP connection
is closed, from ondisconnect in mod_c2s.

It is a bit annoying and doesn't really tell you much.

sessionmanager: Fire event before retiring old session

Thu, 29 Dec 2022 16:25:00 +0000

sessionmanager: Fire event before retiring old session

This allows for modules to update fields, which is generally better than
maintaining this hard-coded list of transferable properties here.

sessionmanager: Pluck sasl_handler from old session when resuming (fixes #1785)

Thu, 29 Dec 2022 16:23:08 +0000

sessionmanager: Pluck sasl_handler from old session when resuming (fixes #1785)

mod_smacks: Long overdue cleanup of resumption code, fixes some old TODOs

Fri, 26 Aug 2022 17:04:15 +0100

mod_smacks: Long overdue cleanup of resumption code, fixes some old TODOs

mod_authz_internal, and more: New iteration of role API

Wed, 17 Aug 2022 16:38:53 +0100

mod_authz_internal, and more: New iteration of role API

These changes to the API (hopefully the last) introduce a cleaner separation
between the user's primary (default) role, and their secondary (optional)
roles.

To keep the code sane and reduce complexity, a data migration is needed for
people using stored roles in 0.12. This can be performed with

prosodyctl mod_authz_internal migrate

mod_authz_internal: Use util.roles, some API changes and config support

Tue, 19 Jul 2022 18:02:02 +0100

mod_authz_internal: Use util.roles, some API changes and config support

This commit was too awkward to split (hg record didn't like it), so:

- Switch to the new util.roles lib to provide a consistent representation of
a role object.

- Change API method from get_role_info() to get_role_by_name() (touches
sessionmanager and usermanager)

- Change get_roles() to get_user_roles(), take a username instead of a JID
This is more consistent with all other usermanager API methods.

- Support configuration of custom roles and permissions via the config file
(to be documented).

Switch to a new role-based authorization framework, removing is_admin()

Wed, 15 Jun 2022 12:15:01 +0100

Switch to a new role-based authorization framework, removing is_admin()

We began moving away from simple "is this user an admin?" permission checks
before 0.12, with the introduction of mod_authz_internal and the ability to
dynamically change the roles of individual users.

The approach in 0.12 still had various limitations however, and apart from
the introduction of roles other than "admin" and the ability to pull that info
from storage, not much actually changed.

This new framework shakes things up a lot, though aims to maintain the same
functionality and behaviour on the surface for a default Prosody
configuration. That is, if you don't take advantage of any of the new
features, you shouldn't notice any change.

The biggest change visible to developers is that usermanager.is_admin() (and
the auth provider is_admin() method) have been removed. Gone. Completely.

Permission checks should now be performed using a new module API method:

module:may(action_name, context)

This method accepts an action name, followed by either a JID (string) or
(preferably) a table containing 'origin'/'session' and 'stanza' fields (e.g.
the standard object passed to most events). It will return true if the action
should be permitted, or false/nil otherwise.

Modules should no longer perform permission checks based on the role name.
E.g. a lot of code previously checked if the user's role was prosody:admin
before permitting some action. Since many roles might now exist with similar
permissions, and the permissions of prosody:admin may be redefined
dynamically, it is no longer suitable to use this method for permission
checks. Use module:may().

If you start an action name with ':' (recommended) then the current module's
name will automatically be used as a prefix.

To define a new permission, use the new module API:

module:default_permission(role_name, action_name)
module:default_permissions(role_name, { action_name[, action_name...] })

This grants the specified role permission to execute the named action(s) by
default. This may be overridden via other mechanisms external to your module.

The built-in roles that developers should use are:

- prosody:user (normal user)
- prosody:admin (host admin)
- prosody:operator (global admin)

The new prosody:operator role is intended for server-wide actions (such as
shutting down Prosody).

Finally, all usage of is_admin() in modules has been fixed by this commit.
Some of these changes were trickier than others, but no change is expected to
break existing deployments.

EXCEPT: mod_auth_ldap no longer supports the ldap_admin_filter option. It's
very possible nobody is using this, but if someone is then we can later update
it to pull roles from LDAP somehow.

core.sessionmanager: Add a dummy rawsend() method to resting sessions

Thu, 15 Apr 2021 15:12:35 +0200

core.sessionmanager: Add a dummy rawsend() method to resting sessions

Should fix a traceback on attempted use after destruction, in case where
opportunistic_writes was in use.

Thanks Ge0rG

sessionmanager: Support passing an auth scope to make_authenticated

Wed, 05 Feb 2020 17:56:20 +0000

sessionmanager: Support passing an auth scope to make_authenticated

core.sessionmanager: Require that client-requested resources pass strict resourceprep

Sat, 02 Nov 2019 15:39:01 +0100

core.sessionmanager: Require that client-requested resources pass strict resourceprep

core.sessionmanager: Fix traceback from passing nil to resourceprep

Sat, 02 Nov 2019 13:24:33 +0100

core.sessionmanager: Fix traceback from passing nil to resourceprep

core.sessionmanager: Remove tostring call from logging

Tue, 30 Jul 2019 02:19:27 +0200

core.sessionmanager: Remove tostring call from logging

Taken care of by loggingmanager now

core/sessionmanager: Remove unnecessary fallback in make_authenticated

Sat, 01 Jun 2019 15:00:35 +0200

core/sessionmanager: Remove unnecessary fallback in make_authenticated

core.sessionmanager: Use util.session to create sessions

Fri, 29 Mar 2019 23:05:08 +0100

core.sessionmanager: Use util.session to create sessions

sessionmanager: Split byte-level sending into separate session.rawsend

Sun, 24 Mar 2019 08:18:19 +0000

sessionmanager: Split byte-level sending into separate session.rawsend

Merge 0.10->trunk

Mon, 30 Jul 2018 15:13:54 +0100

Merge 0.10->trunk

sessionmanager, mod_s2s: Bring debug line for outgoing stanzas in line with that for incoming

Tue, 24 Jul 2018 19:07:26 +0200

sessionmanager, mod_s2s: Bring debug line for outgoing stanzas in line with that for incoming

sessionmanager: Log top tag of outgoing stanzas on c2s (#776)

Sun, 22 Jul 2018 19:41:29 +0200

sessionmanager: Log top tag of outgoing stanzas on c2s (#776)

sessionmanager, mod_s2s: Bring debug line for outgoing stanzas in line with that for incoming

Tue, 24 Jul 2018 19:07:26 +0200

sessionmanager, mod_s2s: Bring debug line for outgoing stanzas in line with that for incoming

sessionmanager: Log top tag of outgoing stanzas on c2s (#776)

Sun, 22 Jul 2018 19:41:29 +0200

sessionmanager: Log top tag of outgoing stanzas on c2s (#776)

sessionmanager: Generate shorter random resoures

Tue, 29 May 2018 06:51:52 +0200

sessionmanager: Generate shorter random resoures

core: Use prosody.hosts instead of _G.hosts for consistency

Thu, 29 Mar 2018 16:58:06 +0200

core: Use prosody.hosts instead of _G.hosts for consistency

vairious: Add annotation when an empty environment is set [luacheck]

Wed, 28 Feb 2018 20:06:26 +0100

vairious: Add annotation when an empty environment is set [luacheck]

Merge 0.10 -> trunk

Fri, 28 Jul 2017 23:47:38 +0100

Merge 0.10 -> trunk

sessionmanager: Revert session.type if binding fails due to roster load error

Fri, 28 Jul 2017 23:45:05 +0100

sessionmanager: Revert session.type if binding fails due to roster load error

Merge 0.10->trunk

Mon, 06 Mar 2017 01:14:32 +0100

Merge 0.10->trunk

core: Allow select core modules to mutate some globals (needs luacheck 1.19)

Sat, 04 Mar 2017 20:09:28 +0100

core: Allow select core modules to mutate some globals (needs luacheck 1.19)

core: Split some very long lines [luacheck]

Sat, 04 Mar 2017 17:49:48 +0100

core: Split some very long lines [luacheck]

Merge 0.10->trunk

Wed, 14 Dec 2016 01:47:19 +0100

Merge 0.10->trunk

core.sessionmanager, mod_saslauth: Introduce intermediate session type for authenticated but unbound sessions so that resource binding is not treated as a normal stanza

Tue, 13 Dec 2016 18:15:17 +0100

core.sessionmanager, mod_saslauth: Introduce intermediate session type for authenticated but unbound sessions so that resource binding is not treated as a normal stanza

Merge 0.10->trunk

Wed, 13 Jul 2016 18:43:33 +0200

Merge 0.10->trunk

Merge 0.9->0.10

Wed, 13 Jul 2016 18:43:28 +0200

Merge 0.9->0.10

sessionmanager: Make session.send() return true unless there really is an error [backported from 0.10]

Mon, 21 Sep 2015 23:19:48 +0200

sessionmanager: Make session.send() return true unless there really is an error [backported from 0.10]

Merge 0.10->trunk

Thu, 17 Mar 2016 18:04:43 +0100

Merge 0.10->trunk

mod_c2s: Remove use of util.async

Thu, 17 Mar 2016 12:47:24 +0100

mod_c2s: Remove use of util.async

sessionmanager: Demote write error to debug message

Thu, 05 Nov 2015 13:35:16 +0100

sessionmanager: Demote write error to debug message

sessionmanager: Clarify log message when failing to write data to connection

Wed, 04 Nov 2015 12:21:46 +0100

sessionmanager: Clarify log message when failing to write data to connection

sessionmanager: Make session.send() return true unless there really is an error

Mon, 21 Sep 2015 23:19:48 +0200

sessionmanager: Make session.send() return true unless there really is an error

core.*: Remove use of module() function

Sat, 21 Feb 2015 10:42:19 +0100

core.*: Remove use of module() function

sessionmanager: Rename argument to avoid name clash with local variable [luacheck]

Wed, 06 May 2015 19:58:33 +0100

sessionmanager: Rename argument to avoid name clash with local variable [luacheck]

sessionmanager: Rename unused loop variables to '_' [luacheck]

Wed, 06 May 2015 19:58:03 +0100

sessionmanager: Rename unused loop variables to '_' [luacheck]

portmanager, s2smanager, sessionmanager, stanza_router, storagemanager, usermanager, util.xml: Add luacheck annotations

Wed, 06 May 2015 19:20:07 +0100

portmanager, s2smanager, sessionmanager, stanza_router, storagemanager, usermanager, util.xml: Add luacheck annotations

sessionmanager: Rename parameter to avoid varible name conflict

Fri, 03 Apr 2015 19:31:05 +0100

sessionmanager: Rename parameter to avoid varible name conflict

Merge 0.9->0.10

Thu, 26 Mar 2015 16:48:39 +0000

Merge 0.9->0.10

sessionmanager: Return 'not-allowed' error instead of the non-existent 'already-bound' error when client tries to bind a resource twice on the same stream (thanks Flow) fixes issue #484.

Tue, 24 Mar 2015 15:57:46 +0000

sessionmanager: Return 'not-allowed' error instead of the non-existent 'already-bound' error when client tries to bind a resource twice on the same stream (thanks Flow) fixes issue #484.

sessionmanager: Add pre-resource-bind event that would let plugins have a say in resource binding

Fri, 30 Jan 2015 15:38:54 +0100

sessionmanager: Add pre-resource-bind event that would let plugins have a say in resource binding

sessionmanager: Access bare_session and full_sessions through 'prosody'

Tue, 20 Jan 2015 11:31:58 +0000

sessionmanager: Access bare_session and full_sessions through 'prosody'

core.sessionmanager: Set a fake thread on destroyed sessions, fixes traceback if stanzas are emitted after a session is destroyed (thanks Sven Blumenstein)

Thu, 11 Sep 2014 00:09:07 +0200

core.sessionmanager: Set a fake thread on destroyed sessions, fixes traceback if stanzas are emitted after a session is destroyed (thanks Sven Blumenstein)

Remove all trailing whitespace

Fri, 09 Aug 2013 17:48:21 +0200

Remove all trailing whitespace

sessionmanager, s2smanager: Remove unused imports

Thu, 11 Apr 2013 17:35:39 +0100

sessionmanager, s2smanager: Remove unused imports

sessionmanager, s2smanager: Remove open_session tracing

Mon, 08 Apr 2013 15:53:18 +0100

sessionmanager, s2smanager: Remove open_session tracing

core.*: Complete removal of all traces of the "core" section and section-related code.

Sat, 23 Mar 2013 02:33:15 +0100

core.*: Complete removal of all traces of the "core" section and section-related code.

s2smanager: Generate session names used for logging the same way everywhere

Thu, 24 Jan 2013 00:58:17 +0100

s2smanager: Generate session names used for logging the same way everywhere