http://hg.omfa.de/prosody-hg/ en-us prosody-hg: core/portmanager.lua history core/portmanager.lua revision history portmanager: Add debug log message to state which certificate we end up using http://hg.omfa.de/prosody-hg/log/98e68a68c1da/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Thu, 03 Apr 2025 12:03:24 +0100 portmanager: Take automatic cert selection into account when setting SNI cert http://hg.omfa.de/prosody-hg/log/fd7b0adada05/core/portmanager.lua
This fixes (another) issue with the fix in 4ea7bd7325be, where it no longer
checked the automatic cert index for an appropriate certificate.]]> Matthew Wild <mwild1@gmail.com> Thu, 03 Apr 2025 12:02:45 +0100 portmanager: Use alternate host (if any) for SNI (many thanks Zaak!) http://hg.omfa.de/prosody-hg/log/21c58b1d5b47/core/portmanager.lua
This was an oversight in the fix for #1915 in commit 4ea7bd7325be (though it
seems commit 7e9ebdc75ce4 was the first to introduce this bug).]]> Matthew Wild <mwild1@gmail.com> Wed, 02 Apr 2025 16:13:55 +0100 core.portmanager: Restore use of per-host 'ssl' for SNI hosts. Fixes #1915. http://hg.omfa.de/prosody-hg/log/4ea7bd7325be/core/portmanager.lua
This was an unintentional regression, as per-host 'ssl' options became valid
in 0.12 when SNI support was added for direct TLS ports. While we encourage
most people to use the simpler automatic certificate selection (and it seems
most do, given the overlooking of this bug), there are likely always going to
be use cases for manually-configured certificates.

The issue was introduced in commit 7e9ebdc75ce4 which inadvertently removed
the per-host option checking for SNI.]]> Kim Alvefur <zash@zash.se> Sat, 29 Mar 2025 22:25:19 +0100 portmanager: Expose API to get at SSL/TLS config for a given interface/port http://hg.omfa.de/prosody-hg/log/140f7926946b/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Wed, 07 Sep 2022 11:26:42 +0100 core.portmanager: Join strings broken into multiple lines http://hg.omfa.de/prosody-hg/log/84c7779618b6/core/portmanager.lua
Improves readability. Reduces line count. What's not to like?

The code style and luacheck rules allows longer lines, and these strings
aren't long enough to need breaking into multiple lines like this.]]> Kim Alvefur <zash@zash.se> Sat, 29 Jul 2023 02:04:24 +0200 core.portmanager: Hint at HTTP servers for conflicts over port 443 http://hg.omfa.de/prosody-hg/log/7748dfb201de/core/portmanager.lua
Since 443 is just as much a web port as port 80 these days, if not more.

What's with port 81 here?]]> Kim Alvefur <zash@zash.se> Sat, 29 Jul 2023 02:00:55 +0200 core: Prefix module imports with prosody namespace http://hg.omfa.de/prosody-hg/log/ead41e25ebc0/core/portmanager.lua Kim Alvefur <zash@zash.se> Fri, 17 Mar 2023 16:23:07 +0100 net: isolate LuaSec-specifics http://hg.omfa.de/prosody-hg/log/7e9ebdc75ce4/core/portmanager.lua
For this, various accessor functions are now provided directly on the
sockets, which reach down into the LuaSec implementation to obtain the
information.

While this may seem of little gain at first, it hides the implementation
detail of the LuaSec+LuaSocket combination that the actual socket and
the TLS layer are separate objects.

The net gain here is that an alternative implementation does not have to
emulate that specific implementation detail and "only" has to expose
LuaSec-compatible data structures on the new functions.]]> Jonas Schäfer <jonas@wielicki.name> Wed, 27 Apr 2022 17:44:14 +0200 core.portmanager: Fix traceback on attempt to get non-existent service http://hg.omfa.de/prosody-hg/log/8119a58b3a5c/core/portmanager.lua
If there's no such interface:port then `data` is nil and `data.service`
errors.]]> Kim Alvefur <zash@zash.se> Tue, 22 Feb 2022 13:41:05 +0100 core.portmanager: Also reload per-SNI certificates http://hg.omfa.de/prosody-hg/log/081e550b973a/core/portmanager.lua Kim Alvefur <zash@zash.se> Thu, 10 Jun 2021 15:33:52 +0200 core.portmanager: Reload direct TLS certificates after config reload http://hg.omfa.de/prosody-hg/log/7e1ca18fdfb3/core/portmanager.lua
This should re-create all contexts the same way as when the service was
activated, which reloads certificates.]]> Kim Alvefur <zash@zash.se> Thu, 10 Jun 2021 15:30:54 +0200 core.portmanager: Factor out base TLS context creation for reuse http://hg.omfa.de/prosody-hg/log/f6f1b50cbedf/core/portmanager.lua
Thinking I can use this to reload certificates after config reload]]> Kim Alvefur <zash@zash.se> Thu, 10 Jun 2021 15:21:07 +0200 core.portmanager: Fix race condition in initialization of SNI cert map http://hg.omfa.de/prosody-hg/log/5aafb832c91b/core/portmanager.lua
Under some circumstances when hosts and modules are loaded in some
certain order, entries end up missing from the SNI map. This manifests
in e.g. `curl https://localhost:5281/` giving an error about
"unrecognized name".

The `service` argument is `nil` when invoked from the "host-activated"
event, leading it to iterating over every service. And then it would not
be fetching e.g. `http_host` from the config, which explains why https
would sometimes not work due to the missing name entry.

Because when `service` is included, this limits the iteration to
matching entries, while also returning the same value as the `name` loop
variable. Because `name == service when service != nil` we can use name
instead in the body of the loop.]]> Kim Alvefur <zash@zash.se> Fri, 28 May 2021 17:09:22 +0200 core.portmanager: Use existing http_host for https SNI mapping http://hg.omfa.de/prosody-hg/log/fb9bd9fa4356/core/portmanager.lua Kim Alvefur <zash@zash.se> Wed, 05 May 2021 17:54:44 +0200 core.portmanager: Allow overriding expected SNI name per service http://hg.omfa.de/prosody-hg/log/180c5951e7e4/core/portmanager.lua
E.g.

VirtualHost"example.com"
https_name = "xmpp.example.com"]]> Kim Alvefur <zash@zash.se> Wed, 05 May 2021 17:52:51 +0200 core.portmanager: Log SNI hosts, services looked for http://hg.omfa.de/prosody-hg/log/77785c5d6773/core/portmanager.lua
To highlight how many these are]]> Kim Alvefur <zash@zash.se> Tue, 02 Mar 2021 21:47:09 +0100 portmanager: Don't auto-start network services under prosodyctl http://hg.omfa.de/prosody-hg/log/85f1cbfd364a/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Wed, 05 Feb 2020 17:41:40 +0000 core.portmanager: Ignore unused return variable [luacheck] http://hg.omfa.de/prosody-hg/log/71b82567245c/core/portmanager.lua Kim Alvefur <zash@zash.se> Mon, 23 Dec 2019 21:26:51 +0100 core.portmanager: Complete error message for SNI TLS context problems http://hg.omfa.de/prosody-hg/log/7341d2f4749a/core/portmanager.lua Kim Alvefur <zash@zash.se> Sat, 30 Nov 2019 16:40:04 +0100 core.portmanager: Fix TLS context inheritance for SNI hosts (completes SNI support) http://hg.omfa.de/prosody-hg/log/fbeb7a3fc4eb/core/portmanager.lua Kim Alvefur <zash@zash.se> Fri, 29 Nov 2019 23:24:14 +0100 core.portmanager: Don't set the first TLS context with a cert as main context http://hg.omfa.de/prosody-hg/log/9af6ab2623b0/core/portmanager.lua
Don't think this works and it's apparently acceptable to require SNI these days.]]> Kim Alvefur <zash@zash.se> Fri, 29 Nov 2019 23:22:29 +0100 core.portmanager: Remove unused local [luacheck] http://hg.omfa.de/prosody-hg/log/1dbabbebb53c/core/portmanager.lua Kim Alvefur <zash@zash.se> Tue, 30 Jul 2019 02:20:27 +0200 core.portmanager: Remove tostring call from logging http://hg.omfa.de/prosody-hg/log/c8fbb7f2fc0d/core/portmanager.lua
Taken care of by loggingmanager now]]> Kim Alvefur <zash@zash.se> Tue, 30 Jul 2019 02:19:54 +0200 Merge 0.11->trunk http://hg.omfa.de/prosody-hg/log/ca01c449357f/core/portmanager.lua Kim Alvefur <zash@zash.se> Wed, 24 Apr 2019 18:06:48 +0200 core.portmanager: Log debug message for each kind of TLS context created http://hg.omfa.de/prosody-hg/log/240d3f1f7dee/core/portmanager.lua Kim Alvefur <zash@zash.se> Tue, 23 Apr 2019 19:21:06 +0200 core.portmanager: Collect per-host certificates for SNI http://hg.omfa.de/prosody-hg/log/70e56f126177/core/portmanager.lua Kim Alvefur <zash@zash.se> Fri, 14 Sep 2018 01:30:56 +0200 core.portmanager: Record TLS config for each port http://hg.omfa.de/prosody-hg/log/b923053e69ba/core/portmanager.lua Kim Alvefur <zash@zash.se> Wed, 10 Oct 2018 17:23:03 +0200 core.portmanager: Reduce scope of variable http://hg.omfa.de/prosody-hg/log/789395f027f1/core/portmanager.lua
Not sure why it was all the way out there, seems like there would have
been unexpected behaviour from that]]> Kim Alvefur <zash@zash.se> Wed, 10 Oct 2018 17:22:08 +0200 core.portmanager: Use server.listen API http://hg.omfa.de/prosody-hg/log/e487197ba8a5/core/portmanager.lua Kim Alvefur <zash@zash.se> Thu, 13 Sep 2018 21:17:37 +0200 vairious: Add annotation when an empty environment is set [luacheck] http://hg.omfa.de/prosody-hg/log/4f0f5b49bb03/core/portmanager.lua Kim Alvefur <zash@zash.se> Wed, 28 Feb 2018 20:06:26 +0100 core: Split some very long lines [luacheck] http://hg.omfa.de/prosody-hg/log/24170d74b00b/core/portmanager.lua Kim Alvefur <zash@zash.se> Sat, 04 Mar 2017 17:49:48 +0100 portmanager: Set default read size back to 4K http://hg.omfa.de/prosody-hg/log/d6f12056afda/core/portmanager.lua Kim Alvefur <zash@zash.se> Wed, 04 May 2016 15:31:32 +0200 Merge 0.9->0.10 http://hg.omfa.de/prosody-hg/log/ec17115e3721/core/portmanager.lua Kim Alvefur <zash@zash.se> Mon, 11 Jan 2016 15:33:18 +0100 core: Increase default read size to "all of it", in practice 8K (size of LuaSockets buffer) http://hg.omfa.de/prosody-hg/log/0386ccf20ac7/core/portmanager.lua Kim Alvefur <zash@zash.se> Sun, 10 Jan 2016 23:25:00 +0100 portmanager: Lower the priority of module-supplied TLS options http://hg.omfa.de/prosody-hg/log/daaa52b3f45f/core/portmanager.lua Kim Alvefur <zash@zash.se> Tue, 08 Dec 2015 20:12:38 +0100 portmanager: Add forward declarations http://hg.omfa.de/prosody-hg/log/d64c1f3c7e2e/core/portmanager.lua Kim Alvefur <zash@zash.se> Wed, 08 Apr 2015 00:45:26 +0200 core.*: Remove use of module() function http://hg.omfa.de/prosody-hg/log/6236668da30a/core/portmanager.lua Kim Alvefur <zash@zash.se> Sat, 21 Feb 2015 10:42:19 +0100 portmanager: Remove unused argument from function [luacheck] http://hg.omfa.de/prosody-hg/log/1d4fb397e561/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Wed, 13 May 2015 17:08:34 +0100 portmanager: Rename variable to avoid name conflict [luacheck] http://hg.omfa.de/prosody-hg/log/d1ee04683689/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Wed, 13 May 2015 17:08:20 +0100 portmanager: Add luacheck annotations http://hg.omfa.de/prosody-hg/log/c5b512cddda0/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Wed, 13 May 2015 17:07:30 +0100 portmanager, s2smanager, sessionmanager, stanza_router, storagemanager, usermanager, util.xml: Add luacheck annotations http://hg.omfa.de/prosody-hg/log/d3023dd07cb6/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Wed, 06 May 2015 19:20:07 +0100 portmanager: Remove unused import of pairs() http://hg.omfa.de/prosody-hg/log/46d7ede2e037/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Tue, 20 Jan 2015 11:31:04 +0000 core.portmanager: Simplify and take advantage of new ssl config merging in certmanager http://hg.omfa.de/prosody-hg/log/cb12ff49503d/core/portmanager.lua Kim Alvefur <zash@zash.se> Thu, 03 Jul 2014 15:33:11 +0200 Merge 0.9->0.10 http://hg.omfa.de/prosody-hg/log/7a5ddbaf758d/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Wed, 02 Apr 2014 17:41:38 +0100 portmanager: Make maximum read size configurable, and default to 4KB http://hg.omfa.de/prosody-hg/log/a97591d2e1ad/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Sun, 30 Mar 2014 08:44:55 +0100 Remove all trailing whitespace http://hg.omfa.de/prosody-hg/log/bd0ff8ae98a8/core/portmanager.lua Florian Zeitz <florob@babelmonkeys.de> Fri, 09 Aug 2013 17:48:21 +0200 portmanager: Also include the interface the service is listening on http://hg.omfa.de/prosody-hg/log/557583904dc5/core/portmanager.lua Kim Alvefur <zash@zash.se> Mon, 29 Apr 2013 19:40:39 +0200 portmanager: Include port numbers the service is listening on in the info logs. http://hg.omfa.de/prosody-hg/log/cce17bcb7c94/core/portmanager.lua Waqas Hussain <waqas20@gmail.com> Mon, 29 Apr 2013 22:03:17 +0500 portmanager: import pairs() (thanks Maranda) http://hg.omfa.de/prosody-hg/log/53b16286509a/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Fri, 05 Apr 2013 13:06:26 +0100 portmanager: add logic to allow specification of service default values for ssl config and / or overrides. http://hg.omfa.de/prosody-hg/log/1b20095eb230/core/portmanager.lua Marco Cirillo <maranda@lightwitch.org> Thu, 04 Apr 2013 23:36:30 +0000 portmanager: Log error and fail to bind when port is invalid (not a number) http://hg.omfa.de/prosody-hg/log/13454b2b86bf/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Sun, 31 Mar 2013 12:27:28 +0100 portmanager: Add use_ipv4 option, default to true. http://hg.omfa.de/prosody-hg/log/613959dbd0b2/core/portmanager.lua Kim Alvefur <zash@zash.se> Wed, 27 Mar 2013 23:48:39 +0100 portmanager: use_ipv6 defaults to true if luasocket has ipv6 support http://hg.omfa.de/prosody-hg/log/0d49a4e9963b/core/portmanager.lua Kim Alvefur <zash@zash.se> Wed, 27 Mar 2013 23:32:34 +0100 portmanager: Make sure foo_ports is a table http://hg.omfa.de/prosody-hg/log/d20861bf900b/core/portmanager.lua Kim Alvefur <zash@zash.se> Thu, 31 Jan 2013 15:48:55 +0100 portmanager: Return first service with the specified name from get_service() (instead of the array of possible services) (thanks xnyhps) http://hg.omfa.de/prosody-hg/log/079e4cb23f89/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Tue, 04 Dec 2012 20:08:44 +0000 portmanager: Support 'local_interfaces' config option (default for private listeners like components, telnet, etc.) (thanks mva) http://hg.omfa.de/prosody-hg/log/71a5a6a6c74c/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Fri, 10 Aug 2012 16:31:51 +0100 portmanager: Remove unused import of 'pairs' http://hg.omfa.de/prosody-hg/log/aab64739022e/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Sun, 29 Jul 2012 02:27:07 +0100 portmanager: Show a friendly error message when initializing SSL fails (thanks MattJ for the entire patch that I fixed one line in) http://hg.omfa.de/prosody-hg/log/b27ba2c83dd4/core/portmanager.lua Kim Alvefur <zash@zash.se> Wed, 25 Jul 2012 20:31:14 +0200 portmanager: Match service against service_info (:iter() doesn't match values) http://hg.omfa.de/prosody-hg/log/a7c799a7a34b/core/portmanager.lua Matthew Wild <mwild1@gmail.com> Tue, 22 May 2012 14:33:06 +0100