Mercurial > prosody-hg
view plugins/mod_vcard.lua @ 14157:f881ed0ee8bd 0.12
moduleapi: Use multitable add/remove instead of set
multitable:set() does not clear intermediate keys when setting the last one to
nil. This meant that the event_handlers multitable for every module was not
properly cleaning up the object and event name from the table when calling
:unhook_object_event().
This combined badly with e.g. mod_bookmarks, which uses this extensively to
add/remove hooks dynamically for mod_pep services. The multitable kept a
reference to every mod_pep service object ever created, causing a memory leak.
The multitable:remove() function clears intermediate keys when they are empty,
so we've switched to using that now.
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Fri, 17 Apr 2026 17:39:06 +0100 |
| parents | f1cf8c08a09d |
| children | 74b9e05af71e |
line wrap: on
line source
-- Prosody IM -- Copyright (C) 2008-2010 Matthew Wild -- Copyright (C) 2008-2010 Waqas Hussain -- -- This project is MIT/X11 licensed. Please see the -- COPYING file in the source package for more information. -- local st = require "util.stanza" local jid_split = require "util.jid".split; local vcards = module:open_store(); module:add_feature("vcard-temp"); local function handle_vcard(event) local session, stanza = event.origin, event.stanza; local to = stanza.attr.to; if stanza.attr.type == "get" then local vCard; if to then local node = jid_split(to); vCard = st.deserialize(vcards:get(node)); -- load vCard for user or server else vCard = st.deserialize(vcards:get(session.username));-- load user's own vCard end if vCard then session.send(st.reply(stanza):add_child(vCard)); -- send vCard! else session.send(st.error_reply(stanza, "cancel", "item-not-found")); end else -- stanza.attr.type == "set" if not to then if vcards:set(session.username, st.preserialize(stanza.tags[1])) then session.send(st.reply(stanza)); else -- TODO unable to write file, file may be locked, etc, what's the correct error? session.send(st.error_reply(stanza, "wait", "internal-server-error")); end else session.send(st.error_reply(stanza, "auth", "forbidden")); end end return true; end module:hook("iq/bare/vcard-temp:vCard", handle_vcard); module:hook("iq/host/vcard-temp:vCard", handle_vcard);
