Mercurial > prosody-hg
view spec/util_iterators_spec.lua @ 12659:c0eea4f6c739
usermanager: Add back temporary is_admin to warn about deprecated API usage
Goal: Introduce role-auth with minimal disruption
is_admin() is unsafe in a system with per-session permissions, so it has been
deprecated.
Roll-out approach:
1) First, log a warning when is_admin() is used. It should continue to
function normally, backed by the new role API. Nothing is really using
per-session authz yet, so there is minimal security concern.
The 'strict_deprecate_is_admin' global setting can be set to 'true' to
force a hard failure of is_admin() attempts (it will log an error and
always return false).
2) In some time (at least 1 week), but possibly longer depending on the number
of affected deployments: switch 'strict_deprecate_is_admin' to 'true' by
default. It can still be disabled for systems that need it.
3) Further in the future, before the next release, the option will be removed
and is_admin() will be permanently disabled.
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Mon, 15 Aug 2022 15:25:07 +0100 |
| parents | a9592107021b |
| children | e894677359e5 |
line wrap: on
line source
local iter = require "util.iterators"; describe("util.iterators", function () describe("join", function () it("should produce a joined iterator", function () local expect = { "a", "b", "c", 1, 2, 3 }; local output = {}; for x in iter.join(iter.values({"a", "b", "c"})):append(iter.values({1, 2, 3})) do table.insert(output, x); end assert.same(output, expect); end); end); describe("sorted_pairs", function () it("should produce sorted pairs", function () local orig = { b = 1, c = 2, a = "foo", d = false }; local n, last_key = 0, nil; for k, v in iter.sorted_pairs(orig) do n = n + 1; if last_key then assert(k > last_key, "Expected "..k.." > "..last_key) end assert.equal(orig[k], v); last_key = k; end assert.equal("d", last_key); assert.equal(4, n); end); it("should allow a custom sort function", function () local orig = { b = 1, c = 2, a = "foo", d = false }; local n, last_key = 0, nil; for k, v in iter.sorted_pairs(orig, function (a, b) return a > b end) do n = n + 1; if last_key then assert(k < last_key, "Expected "..k.." > "..last_key) end assert.equal(orig[k], v); last_key = k; end assert.equal("a", last_key); assert.equal(4, n); end); end); end);
