Mercurial > prosody-hg
view util/xtemplate.lua @ 13801:a5d5fefb8b68 13.0
mod_tls: Enable Prosody's certificate checking for incoming s2s connections (fixes #1916) (thanks Damian, Zash)
Various options in Prosody allow control over the behaviour of the certificate
verification process For example, some deployments choose to allow falling
back to traditional "dialback" authentication (XEP-0220), while others verify
via DANE, hard-coded fingerprints, or other custom plugins.
Implementing this flexibility requires us to override OpenSSL's default
certificate verification, to allow Prosody to verify the certificate itself,
apply custom policies and make decisions based on the outcome.
To enable our custom logic, we have to suppress OpenSSL's default behaviour of
aborting the connection with a TLS alert message. With LuaSec, this can be
achieved by using the verifyext "lsec_continue" flag.
We also need to use the lsec_ignore_purpose flag, because XMPP s2s uses server
certificates as "client" certificates (for mutual TLS verification in outgoing
s2s connections).
Commit 99d2100d2918 moved these settings out of the defaults and into mod_s2s,
because we only really need these changes for s2s, and they should be opt-in,
rather than automatically applied to all TLS services we offer.
That commit was incomplete, because it only added the flags for incoming
direct TLS connections. StartTLS connections are handled by mod_tls, which was
not applying the lsec_* flags. It previously worked because they were already
in the defaults.
This resulted in incoming s2s connections with "invalid" certificates being
aborted early by OpenSSL, even if settings such as `s2s_secure_auth = false`
or DANE were present in the config.
Outgoing s2s connections inherit verify "none" from the defaults, which means
OpenSSL will receive the cert but will not terminate the connection when it is
deemed invalid. This means we don't need lsec_continue there, and we also
don't need lsec_ignore_purpose (because the remote peer is a "server").
Wondering why we can't just use verify "none" for incoming s2s? It's because
in that mode, OpenSSL won't request a certificate from the peer for incoming
connections. Setting verify "peer" is how you ask OpenSSL to request a
certificate from the client, but also what triggers its built-in verification.
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Tue, 01 Apr 2025 17:26:56 +0100 |
| parents | 0f7e7311eebf |
| children |
line wrap: on
line source
local s_gsub = string.gsub; local s_match = string.match; local s_sub = string.sub; local t_concat = table.concat; local st = require("prosody.util.stanza"); local function render(template, root, escape, filters) escape = escape or st.xml_escape; return (s_gsub(template, "(%s*)(%b{})(%s*)", function(pre_blank, block, post_blank) local inner = s_sub(block, 2, -2); if inner:sub(1, 1) == "-" then pre_blank = ""; inner = inner:sub(2); end if inner:sub(-1, -1) == "-" then post_blank = ""; inner = inner:sub(1, -2); end local path, pipe, pos = s_match(inner, "^([^|]+)(|?)()"); if not (type(path) == "string") then return end local value if path == "." then value = root; elseif path == "#" then value = root:get_text(); else value = root:find(path); end local is_escaped = false; while pipe == "|" do local func, args, tmpl, p = s_match(inner, "^(%w+)(%b())(%b{})()", pos); if not func then func, args, p = s_match(inner, "^(%w+)(%b())()", pos); end if not func then func, tmpl, p = s_match(inner, "^(%w+)(%b{})()", pos); end if not func then func, p = s_match(inner, "^(%w+)()", pos); end if not func then break end if tmpl then tmpl = s_sub(tmpl, 2, -2); end if args then args = s_sub(args, 2, -2); end if func == "each" and tmpl then if not st.is_stanza(value) then return pre_blank .. post_blank end if not args then value, args = root, path; end local ns, name = s_match(args, "^(%b{})(.*)$"); if ns then ns = s_sub(ns, 2, -2); else name, ns = args, nil; end if ns == "" then ns = nil; end if name == "" then name = nil; end local out, i = {}, 1; for c in (value):childtags(name, ns) do out[i], i = render(tmpl, c, escape, filters), i + 1; end value = t_concat(out); is_escaped = true; elseif func == "and" and tmpl then local condition = value; if args then condition = root:find(args); end if condition then value = render(tmpl, root, escape, filters); is_escaped = true; end elseif func == "or" and tmpl then local condition = value; if args then condition = root:find(args); end if not condition then value = render(tmpl, root, escape, filters); is_escaped = true; end elseif filters and filters[func] then local f = filters[func]; value, is_escaped = f(value, args, tmpl); else error("No such filter function: " .. func); end pipe, pos = s_match(inner, "^(|?)()", p); end if type(value) == "string" then if not is_escaped then value = escape(value); end return pre_blank .. value .. post_blank elseif st.is_stanza(value) then value = value:get_text(); if value then return pre_blank .. escape(value) .. post_blank end end return pre_blank .. post_blank end)) end return { render = render }
