view HACKERS @ 14181:6fb6e383123f 13.0

util.signal: Fix signalfd closure on non-Linux systems The loop was incorrect for 0-indexed arrays. It started at signalfd_num, which is the total number of signalfds, and decremented to 1 (condition was >0). So if 1 signalfd was registered, it would check only signalfds[1]. At capacity (32 signalfds) it would read past the end of the array. In every case, it would always skip the entry at position [0], leading to a leak. The swap-with-tail removal of the matched item used the post-decrement operator, leading to accessing the array slot just beyond the tail. Finally, it didn't break after finding a match. Probably harmless, but there isn't expected to be more than a single entry per fd, as far as I can tell.
author Matthew Wild <mwild1@gmail.com>
date Mon, 25 May 2026 16:02:39 +0100
parents 54147de1d1b1
children
line wrap: on
line source

Welcome hackers!

This project accepts and *encourages* contributions. If you would like to get 
involved you can join us on our mailing list and discussion rooms. More 
information on these at https://prosody.im/discuss

Patches are welcome, though before sending we would appreciate if you read 
docs/coding_style.md for guidelines on how to format your code, and other tips.

Documentation for developers can be found at https://prosody.im/doc/developers

Have fun :)