prosody-hg: plugins/mod_bosh.lua comparison

comparison plugins/mod_bosh.lua @ 5720:449399a7e136

Merge

author	Matthew Wild <mwild1@gmail.com>
date	Sat, 29 Jun 2013 14:45:47 +0100
parents	ebdbf4cf0b2f
children	8de1f9290588

comparison

equal deleted inserted replaced

-:84025249fc04
+:449399a7e136
 -- Prosody IM
 -- Copyright (C) 2008-2010 Matthew Wild
 -- Copyright (C) 2008-2010 Waqas Hussain
 --
 -- This project is MIT/X11 licensed. Please see the
 -- COPYING file in the source package for more information.
 --
 module:set_global(); -- Global module
 local BOSH_DEFAULT_POLLING = module:get_option_number("bosh_max_polling", 5);
 local BOSH_DEFAULT_REQUESTS = module:get_option_number("bosh_max_requests", 2);
 local bosh_max_wait = module:get_option_number("bosh_max_wait", 120);
 local consider_bosh_secure = module:get_option_boolean("consider_bosh_secure");
-local default_headers = { ["Content-Type"] = "text/xml; charset=utf-8" };
 local cross_domain = module:get_option("cross_domain_bosh", false);
-if cross_domain then
-	default_headers["Access-Control-Allow-Methods"] = "GET, POST, OPTIONS";
+if cross_domain == true then cross_domain = "*"; end
-	default_headers["Access-Control-Allow-Headers"] = "Content-Type";
+if type(cross_domain) == "table" then cross_domain = table.concat(cross_domain, ", "); end
-	default_headers["Access-Control-Max-Age"] = "7200";
-	if cross_domain == true then
-		default_headers["Access-Control-Allow-Origin"] = "*";
-	elseif type(cross_domain) == "table" then
-		cross_domain = table.concat(cross_domain, ", ");
-	end
-	if type(cross_domain) == "string" then
-		default_headers["Access-Control-Allow-Origin"] = cross_domain;
-	end
-end
 local trusted_proxies = module:get_option_set("trusted_proxies", {"127.0.0.1"})._items;
 local function get_ip_from_request(request)
 	local ip = request.conn:ip();
 -- All sessions, and sessions that have no requests open
 local sessions, inactive_sessions = module:shared("sessions", "inactive_sessions");
 -- Used to respond to idle sessions (those with waiting requests)
-local waiting_requests = {};
+local waiting_requests = module:shared("waiting_requests");
 function on_destroy_request(request)
 	log("debug", "Request destroyed: %s", tostring(request));
 	waiting_requests[request] = nil;
 	local session = sessions[request.context.sid];
 	if session then
 			(session.log or log)("debug", "BOSH session marked as inactive (for %ds)", max_inactive);
 		end
 	end
 end
-function handle_OPTIONS(request)
+local function set_cross_domain_headers(response)
-	local headers = {};
+	local headers = response.headers;
-	for k,v in pairs(default_headers) do headers[k] = v; end
+	headers.access_control_allow_methods = "GET, POST, OPTIONS";
-	headers["Content-Type"] = nil;
+	headers.access_control_allow_headers = "Content-Type";
-	return { headers = headers, body = "" };
+	headers.access_control_max_age = "7200";
+	headers.access_control_allow_origin = cross_domain;
+	return response;
+end
+function handle_OPTIONS(event)
+	if cross_domain and event.request.headers.origin then
+		set_cross_domain_headers(event.response);
+	end
+	return "";
 end
 function handle_POST(event)
 	log("debug", "Handling new request %s: %s\n----------", tostring(event.request), tostring(event.request.body));
 	local body = request.body;
 	local context = { request = request, response = response, notopen = true };
 	local stream = new_xmpp_stream(context, stream_callbacks);
 	response.context = context;
+	local headers = response.headers;
+	headers.content_type = "text/xml; charset=utf-8";
+	if cross_domain and event.request.headers.origin then
+		set_cross_domain_headers(response);
+	end
 	-- stream:feed() calls the stream_callbacks, so all stanzas in
 	-- the body are processed in this next line before it returns.
 	-- In particular, the streamopened() stream callback is where
 	-- much of the session logic happens, because it's where we first
 	-- get to see the 'sid' of this request.
-	stream:feed(body);
+	if not stream:feed(body) then
+		module:log("warn", "Error parsing BOSH payload")
+		return 400;
+	end
 	-- Stanzas (if any) in the request have now been processed, and
 	-- we take care of the high-level BOSH logic here, including
 	-- giving a response or putting the request "on hold".
 	local session = sessions[context.sid];
 		end
 		local r = session.requests;
 		log("debug", "Session %s has %d out of %d requests open", context.sid, #r, session.bosh_hold);
 		log("debug", "and there are %d things in the send_buffer:", #session.send_buffer);
-		for i, thing in ipairs(session.send_buffer) do
-			log("debug", "    %s", tostring(thing));
-		end
 		if #r > session.bosh_hold then
 			-- We are holding too many requests, send what's in the buffer,
 			log("debug", "We are holding too many requests, so...");
 			if #session.send_buffer > 0 then
 				log("debug", "...sending what is in the buffer")
 			return nil;
 		else
 			return true; -- Inform http server we shall reply later
 		end
 	end
+	module:log("warn", "Unable to associate request with a session (incomplete request?)");
+	return 400;
 end
 local function bosh_reset_stream(session) session.notopen = true; end
 		log("info", "Disconnecting client, <stream:error> is: %s", tostring(close_reply));
 	end
 	local response_body = tostring(close_reply);
 	for _, held_request in ipairs(session.requests) do
-		held_request.headers = default_headers;
 		held_request:send(response_body);
 	end
-	sessions[session.sid]  = nil;
+	sessions[session.sid] = nil;
 	inactive_sessions[session] = nil;
 	sm_destroy_session(session);
 end
 -- Handle the <body> tag in the request payload.
 			t_insert(session.send_buffer, tostring(s));
 			local oldest_request = r[1];
 			if oldest_request and not session.bosh_processing then
 				log("debug", "We have an open request, so sending on that");
-				oldest_request.headers = default_headers;
 				local body_attr = { xmlns = "http://jabber.org/protocol/httpbind",
 					["xmlns:stream"] = "http://etherx.jabber.org/streams";
 					type = session.bosh_terminate and "terminate" or nil;
 					sid = sid;
 				};
 	local session = sessions[sid];
 	if not session then
 		-- Unknown sid
 		log("info", "Client tried to use sid '%s' which we don't know about", sid);
-		response.headers = default_headers;
 		response:send(tostring(st.stanza("body", { xmlns = xmlns_bosh, type = "terminate", condition = "item-not-found" })));
 		context.notopen = nil;
 		return;
 	end
 	if session.notopen then
 		local features = st.stanza("stream:features");
 		hosts[session.host].events.fire_event("stream-features", { origin = session, features = features });
 		fire_event("stream-features", session, features);
-		session.send(tostring(features));
+		session.send(features);
 		session.notopen = nil;
 	end
 end
 function stream_callbacks.handlestanza(context, stanza)
 		stanza = session.filter("stanzas/in", stanza);
 		core_process_stanza(session, stanza);
 	end
 end
-function stream_callbacks.streamclosed(request)
+function stream_callbacks.streamclosed(context)
-	local session = sessions[request.sid];
+	local session = sessions[context.sid];
 	if session then
 		session.bosh_processing = false;
 		if #session.send_buffer > 0 then
 			session.send("");
 		end
 function stream_callbacks.error(context, error)
 	log("debug", "Error parsing BOSH request payload; %s", error);
 	if not context.sid then
 		local response = context.response;
-		response.headers = default_headers;
 		response.status_code = 400;
 		response:send();
 		return;
 	end
 	else
 		session:close({ condition = "bad-format", text = "Error processing stream" });
 	end
 end
-local dead_sessions = {};
+local dead_sessions = module:shared("dead_sessions");
 function on_timer()
 	-- log("debug", "Checking for requests soon to timeout...");
 	-- Identify requests timing out within the next few seconds
 	local now = os_time() + 3;
 	for request, reply_before in pairs(waiting_requests) do

Mercurial > prosody-hg

comparison plugins/mod_bosh.lua @ 5720:449399a7e136