annotate spec/util_bitcompat_spec.lua @ 12659:c0eea4f6c739

usermanager: Add back temporary is_admin to warn about deprecated API usage Goal: Introduce role-auth with minimal disruption is_admin() is unsafe in a system with per-session permissions, so it has been deprecated. Roll-out approach: 1) First, log a warning when is_admin() is used. It should continue to function normally, backed by the new role API. Nothing is really using per-session authz yet, so there is minimal security concern. The 'strict_deprecate_is_admin' global setting can be set to 'true' to force a hard failure of is_admin() attempts (it will log an error and always return false). 2) In some time (at least 1 week), but possibly longer depending on the number of affected deployments: switch 'strict_deprecate_is_admin' to 'true' by default. It can still be disabled for systems that need it. 3) Further in the future, before the next release, the option will be removed and is_admin() will be permanently disabled.
author Matthew Wild <mwild1@gmail.com>
date Mon, 15 Aug 2022 15:25:07 +0100
parents c640717e01ca
children 9912baa541c0
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
12366
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
1 describe("util.bitcompat", function ()
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
2 -- bitcompat will pass through to an appropriate implementation. Our
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
3 -- goal here is to check that whatever implementation is in use passes
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
4 -- these basic sanity checks.
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
5
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
6 local bit = require "util.bitcompat";
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
7
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
8 it("bor works", function ()
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
9 assert.equal(0xF0FF, bit.bor(0xF000, 0x00F0, 0x000F));
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
10 end);
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
11
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
12 it("band works", function ()
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
13 assert.equal(0x0F, bit.band(0xFF, 0x1F, 0x0F));
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
14 end);
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
15
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
16 it("bxor works", function ()
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
17 assert.equal(0x13, bit.bxor(0x10, 0x0F, 0x0C));
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
18 end);
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
19
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
20 it("rshift works", function ()
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
21 assert.equal(0x0F, bit.rshift(0xFF, 4));
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
22 end);
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
23
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
24 it("lshift works", function ()
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
25 assert.equal(0xFF00, bit.lshift(0xFF, 8));
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
26 end);
c640717e01ca util.bitcompat: Add some simple tests
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
27 end);