annotate spec/net_http_server_spec.lua @ 12659:c0eea4f6c739

usermanager: Add back temporary is_admin to warn about deprecated API usage Goal: Introduce role-auth with minimal disruption is_admin() is unsafe in a system with per-session permissions, so it has been deprecated. Roll-out approach: 1) First, log a warning when is_admin() is used. It should continue to function normally, backed by the new role API. Nothing is really using per-session authz yet, so there is minimal security concern. The 'strict_deprecate_is_admin' global setting can be set to 'true' to force a hard failure of is_admin() attempts (it will log an error and always return false). 2) In some time (at least 1 week), but possibly longer depending on the number of affected deployments: switch 'strict_deprecate_is_admin' to 'true' by default. It can still be disabled for systems that need it. 3) Further in the future, before the next release, the option will be removed and is_admin() will be permanently disabled.
author Matthew Wild <mwild1@gmail.com>
date Mon, 15 Aug 2022 15:25:07 +0100
parents ee01578c67cb
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
8413
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
1 describe("net.http.server", function ()
8687
ee01578c67cb net.http.server: Prevent loading of net.server in tests (breaks unrelated tests for some reason)
Kim Alvefur <zash@zash.se>
parents: 8413
diff changeset
2 package.loaded["net.server"] = {}
8413
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
3 local server = require "net.http.server";
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
4 describe("events", function ()
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
5 it("should work with util.helpers", function ()
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
6 -- See #1044
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
7 server.add_handler("GET host/foo/*", function () end, 0);
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
8 server.add_handler("GET host/foo/bar", function () end, 0);
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
9 local helpers = require "util.helpers";
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
10 assert.is.string(helpers.show_events(server._events));
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
11 end);
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
12 end);
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
13 end);