annotate plugins/mod_posix.lua @ 14181:6fb6e383123f 13.0

util.signal: Fix signalfd closure on non-Linux systems The loop was incorrect for 0-indexed arrays. It started at signalfd_num, which is the total number of signalfds, and decremented to 1 (condition was >0). So if 1 signalfd was registered, it would check only signalfds[1]. At capacity (32 signalfds) it would read past the end of the array. In every case, it would always skip the entry at position [0], leading to a leak. The swap-with-tail removal of the matched item used the post-decrement operator, leading to accessing the array slot just beyond the tail. Finally, it didn't break after finding a match. Probably harmless, but there isn't expected to be more than a single entry per fd, as far as I can tell.
author Matthew Wild <mwild1@gmail.com>
date Mon, 25 May 2026 16:02:39 +0100
parents c673ff1075bd
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1522
569d58d21612 Add copyright header to those files missing one
Matthew Wild <mwild1@gmail.com>
parents: 1238
diff changeset
1 -- Prosody IM
2923
b7049746bd29 Update copyright headers for 2010
Matthew Wild <mwild1@gmail.com>
parents: 2795
diff changeset
2 -- Copyright (C) 2008-2010 Matthew Wild
b7049746bd29 Update copyright headers for 2010
Matthew Wild <mwild1@gmail.com>
parents: 2795
diff changeset
3 -- Copyright (C) 2008-2010 Waqas Hussain
5776
bd0ff8ae98a8 Remove all trailing whitespace
Florian Zeitz <florob@babelmonkeys.de>
parents: 5452
diff changeset
4 --
1522
569d58d21612 Add copyright header to those files missing one
Matthew Wild <mwild1@gmail.com>
parents: 1238
diff changeset
5 -- This project is MIT/X11 licensed. Please see the
569d58d21612 Add copyright header to those files missing one
Matthew Wild <mwild1@gmail.com>
parents: 1238
diff changeset
6 -- COPYING file in the source package for more information.
569d58d21612 Add copyright header to those files missing one
Matthew Wild <mwild1@gmail.com>
parents: 1238
diff changeset
7 --
569d58d21612 Add copyright header to those files missing one
Matthew Wild <mwild1@gmail.com>
parents: 1238
diff changeset
8
4623
403b56b78018 mod_posix, mod_bosh, mod_admin_telnet: Use module:set_global()
Kim Alvefur <zash@zash.se>
parents: 3555
diff changeset
9 module:set_global(); -- we're a global module
587
43f509a1519a Add mod_posix, fixes #5
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
10
13461
c673ff1075bd mod_posix: Move everything to util.startup
Kim Alvefur <zash@zash.se>
parents: 13452
diff changeset
11 -- TODO delete this whole concept