Mercurial > prosody-hg
annotate plugins/mod_pep_plus.lua @ 14181:6fb6e383123f 13.0
util.signal: Fix signalfd closure on non-Linux systems
The loop was incorrect for 0-indexed arrays. It started at signalfd_num, which
is the total number of signalfds, and decremented to 1 (condition was >0). So
if 1 signalfd was registered, it would check only signalfds[1]. At capacity
(32 signalfds) it would read past the end of the array. In every case, it
would always skip the entry at position [0], leading to a leak.
The swap-with-tail removal of the matched item used the post-decrement
operator, leading to accessing the array slot just beyond the tail.
Finally, it didn't break after finding a match. Probably harmless, but there
isn't expected to be more than a single entry per fd, as far as I can tell.
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Mon, 25 May 2026 16:02:39 +0100 |
| parents | 0462405b1cfb |
| children |
| rev | line source |
|---|---|
|
9074
0462405b1cfb
mod_pep -> mod_pep_simple, mod_pep_plus -> mod_pep
Matthew Wild <mwild1@gmail.com>
parents:
9061
diff
changeset
|
1 module:log("error", "mod_pep_plus has been renamed to mod_pep, please update your config file. Auto-loading mod_pep..."); |
|
0462405b1cfb
mod_pep -> mod_pep_simple, mod_pep_plus -> mod_pep
Matthew Wild <mwild1@gmail.com>
parents:
9061
diff
changeset
|
2 module:depends("pep"); |
