annotate spec/net_http_server_spec.lua @ 11592:64cfa396bb84

net.server_epoll: Fix reporting of socket connect timeout If the underlying TCP connection times out before the write timeout kicks in, end up here with err="timeout", which the following code treats as a minor issue. Then, due to epoll apparently returning the EPOLLOUT (writable) event too, we go on and try to write to the socket (commonly stream headers). This fails because the socket is closed, which becomes the error returned up the stack to the rest of Prosody. This also trips the 'onconnect' signal, which has effects on various things, such as the net.connect state machine. Probably undesirable effects. With this, we instead return "connection timeout", like server_event, and destroy the connection handle properly. And then nothing else happens because the connection has been destroyed.
author Kim Alvefur <zash@zash.se>
date Mon, 07 Jun 2021 17:37:14 +0200
parents ee01578c67cb
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
8413
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
1 describe("net.http.server", function ()
8687
ee01578c67cb net.http.server: Prevent loading of net.server in tests (breaks unrelated tests for some reason)
Kim Alvefur <zash@zash.se>
parents: 8413
diff changeset
2 package.loaded["net.server"] = {}
8413
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
3 local server = require "net.http.server";
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
4 describe("events", function ()
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
5 it("should work with util.helpers", function ()
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
6 -- See #1044
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
7 server.add_handler("GET host/foo/*", function () end, 0);
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
8 server.add_handler("GET host/foo/bar", function () end, 0);
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
9 local helpers = require "util.helpers";
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
10 assert.is.string(helpers.show_events(server._events));
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
11 end);
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
12 end);
9a234e25b35b spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff changeset
13 end);