annotate net/httpserver.lua @ 11592:64cfa396bb84

net.server_epoll: Fix reporting of socket connect timeout If the underlying TCP connection times out before the write timeout kicks in, end up here with err="timeout", which the following code treats as a minor issue. Then, due to epoll apparently returning the EPOLLOUT (writable) event too, we go on and try to write to the socket (commonly stream headers). This fails because the socket is closed, which becomes the error returned up the stack to the rest of Prosody. This also trips the 'onconnect' signal, which has effects on various things, such as the net.connect state machine. Probably undesirable effects. With this, we instead return "connection timeout", like server_event, and destroy the connection handle properly. And then nothing else happens because the connection has been destroyed.
author Kim Alvefur <zash@zash.se>
date Mon, 07 Jun 2021 17:37:14 +0200
parents adc17a2bd6fd
children ba409c67353b
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
4784
e10b623ccecb net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
1 -- COMPAT w/pre-0.9
e10b623ccecb net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
2 local log = require "util.logger".init("net.httpserver");
e10b623ccecb net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
3 local traceback = debug.traceback;
e10b623ccecb net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
4
6780
647adfd8f738 net.*: Remove use of module() function
Kim Alvefur <zash@zash.se>
parents: 4797
diff changeset
5 local _ENV = nil;
8555
4f0f5b49bb03 vairious: Add annotation when an empty environment is set [luacheck]
Kim Alvefur <zash@zash.se>
parents: 7359
diff changeset
6 -- luacheck: std none
4784
e10b623ccecb net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
7
8679
adc17a2bd6fd net.httpserver: Make function local, fixes loading since there is no environment [luacheck]
Kim Alvefur <zash@zash.se>
parents: 8555
diff changeset
8 local function fail()
7359
a5a080c12c96 Update every link to the documentation to use HTTPS
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
parents: 6780
diff changeset
9 log("error", "Attempt to use legacy HTTP API. For more info see https://prosody.im/doc/developers/legacy_http");
4784
e10b623ccecb net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
10 log("error", "Legacy HTTP API usage, %s", traceback("", 2));
e10b623ccecb net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
11 end
e10b623ccecb net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
12
6780
647adfd8f738 net.*: Remove use of module() function
Kim Alvefur <zash@zash.se>
parents: 4797
diff changeset
13 return {
647adfd8f738 net.*: Remove use of module() function
Kim Alvefur <zash@zash.se>
parents: 4797
diff changeset
14 new = fail;
647adfd8f738 net.*: Remove use of module() function
Kim Alvefur <zash@zash.se>
parents: 4797
diff changeset
15 new_from_config = fail;
647adfd8f738 net.*: Remove use of module() function
Kim Alvefur <zash@zash.se>
parents: 4797
diff changeset
16 set_default_handler = fail;
647adfd8f738 net.*: Remove use of module() function
Kim Alvefur <zash@zash.se>
parents: 4797
diff changeset
17 };